Skip to content

Commit

Permalink
Remove BUILD env var for cibuild script
Browse files Browse the repository at this point in the history
Fix brave#8777

Auditors: @bsclifton
  • Loading branch information
bbondy authored and kspearrin committed May 11, 2017
1 parent 34b48d3 commit cdf7445
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 13 deletions.
2 changes: 1 addition & 1 deletion .npmrc
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,4 @@ brave_electron_version = 3.0.1
chromedriver_version = 2.27
target = v3.0.1
disturl=http://brave-laptop-binaries.s3.amazonaws.com/atom-shell/dist/
build_from_source = true
build_from_source = true
14 changes: 2 additions & 12 deletions tools/upload.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,13 @@

BROWSER_LAPTOP_REPO = 'brave/browser-laptop'
TARGET_ARCH= os.environ['TARGET_ARCH'] if os.environ.has_key('TARGET_ARCH') else 'x64'
RELEASE_NAME = ('PRE (DO NOT DOWNLOAD UNLESS YOU ARE TESTING '
'THIS RELEASE CANDIDATE) Dev Channel Beta')
RELEASE_NAME = 'Dev Channel Beta'

def main():
github = GitHub(auth_token())
releases = github.repos(BROWSER_LAPTOP_REPO).releases.get()
tag = ('v' + json.load(open('package.json'))['version'] +
release_channel() + '-' + build_label())
release_channel())
tag_exists = False
for release in releases:
if not release['draft'] and release['tag_name'] == tag:
Expand Down Expand Up @@ -94,15 +93,6 @@ def release_channel():
assert channel, message
return channel

def build_label():
build = os.environ['BUILD']
message = ('Error: Please set the $BUILD '
'environment variable, which is your build label '
'Examples: beta5, or RC1')
assert build, message
return build


if __name__ == '__main__':
import sys
sys.exit(main())

0 comments on commit cdf7445

Please sign in to comment.