Skip to content
This repository has been archived by the owner on Sep 16, 2024. It is now read-only.

Language switching and translations #3

Open
ktrue opened this issue Jan 11, 2019 · 6 comments
Open

Language switching and translations #3

ktrue opened this issue Jan 11, 2019 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@ktrue
Copy link
Owner

ktrue commented Jan 11, 2019

The current CU version does not switch DarkSky language automatically.

Some blocks have non-translated text.

This issue is opened to provide tracking as the fixes are worked up.

@ktrue ktrue self-assigned this Jan 11, 2019
@ktrue ktrue added the bug Something isn't working label Jan 11, 2019
ktrue pushed a commit that referenced this issue Jan 16, 2019
Merge pull request #9 from MatsA/master
@ktrue ktrue added enhancement New feature or request and removed bug Something isn't working labels Jan 28, 2019
@ktrue
Copy link
Owner Author

ktrue commented Jan 28, 2019

Ok, this is more an enhancement project than a 'bug'... changing classification.

@ktrue
Copy link
Owner Author

ktrue commented Jan 31, 2019

The #28 merge provided automatic language switching for DarkSky forecasts (and conditions display for DS) when the menu language flags are clicked.
Note: the first load of the main page after that may have no DS forecast visible.. reloading the page suffices to get the forecast. This is due to the way the template handles language switching so a jsondata/wuupdate.php is not immediately requested when the language is first selected. Maybe I can fix this.. maybe not.
Leaving this enhancement thread open as further language-enabled updates will follow for other parts of the template set.

@ktrue
Copy link
Owner Author

ktrue commented Mar 21, 2019

I've opened a new branch to begin work on this major effort.

@jomimota
Copy link

jomimota commented Feb 23, 2020

lang.pt.php.zip
I have a portuguese translation.
How can I include it in the code?
Thanks in Advance.

Jorge Mota

@ktrue
Copy link
Owner Author

ktrue commented Feb 24, 2020

Thanks Jorge,
I've downloaded your contribution and will merge with the distribution.
Best regards,
Ken

@ktrue
Copy link
Owner Author

ktrue commented Feb 24, 2020

Jorge,
I've merged the update (with the associated changes) into the master distribution. Thanks for doing the translation for Portuguese.
Best regards,
Ken

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants