Now makes sure XML-defined FKs point to PKs. If not then assumes it s…

…hould have been a PK (with a warning).
kuali · Feb 9, 2011 · 1143a7f · 1143a7f
1 parent 1a241e1
commit 1143a7f
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/src/net/sourceforge/schemaspy/model/Database.java b/src/net/sourceforge/schemaspy/model/Database.java
@@ -975,7 +975,7 @@ private void updateFromXmlMetadata(SchemaMeta schemaMeta) throws SQLException {
             for (TableMeta tableMeta : schemaMeta.getTables()) {
                 Table table;
 
-                if (tableMeta.getRemoteSchema() != null) {
+                if (tableMeta.getRemoteCatalog() != null || tableMeta.getRemoteSchema() != null) {
                     table = remoteTables.get(getRemoteTableKey(tableMeta.getRemoteCatalog(), tableMeta.getRemoteSchema(), tableMeta.getName()));
                 } else {
                     table = combined.get(tableMeta.getName());

diff --git a/src/net/sourceforge/schemaspy/model/Table.java b/src/net/sourceforge/schemaspy/model/Table.java
@@ -1133,6 +1133,12 @@ public String getName() {
                                     return "Defined in XML";
                                 }
                             };
+
+                            // they forgot to say it was a primary key
+                            if (!parentColumn.isPrimary()) {
+                                logger.warning("Assuming " + parentColumn.getTable() + "." + parentColumn + " is a primary key due to being referenced by " + col.getTable() + "." + col);
+                                parent.setPrimaryColumn(parentColumn);
+                            }
                         }
                     } else {
                         logger.warning("Undefined table '" + fk.getTableName() + "' referenced by '" + getName() + '.' + col.getName() + "' in XML metadata");