Use StringBuilder instead of StringBuffer (synchronized)

src/net/sourceforge/schemaspy/model/Database.java

@@ -365,7 +365,7 @@ private void initColumnComments(Properties properties) throws SQLException {
      * @return PreparedStatement
      */
     public PreparedStatement prepareStatement(String sql, String tableName) throws SQLException {
-        StringBuffer sqlBuf = new StringBuffer(sql);
+        StringBuilder sqlBuf = new StringBuilder(sql);
         List<String> sqlParams = getSqlParams(sqlBuf, tableName); // modifies sqlBuf
         PreparedStatement stmt = getConnection().prepareStatement(sqlBuf.toString());
 
@@ -536,7 +536,7 @@ private Pattern getInvalidIdentifierPattern() throws SQLException {
      *
      * @see #prepareStatement(String, String)
      */
-    private List<String> getSqlParams(StringBuffer sql, String tableName) {
+    private List<String> getSqlParams(StringBuilder sql, String tableName) {
         Map<String, String> namedParams = new HashMap<String, String>();
         @SuppressWarnings("hiding")
         String schema = getSchema();

src/net/sourceforge/schemaspy/model/ForeignKeyConstraint.java

@@ -120,7 +120,7 @@ public static String toString(List<TableColumn> columns) {
      */
     @Override
     public String toString() {
-        StringBuffer buf = new StringBuffer();
+        StringBuilder buf = new StringBuilder();
         buf.append(childTable.getName());
         buf.append('.');
         buf.append(toString(childColumns));

src/net/sourceforge/schemaspy/model/ImpliedForeignKeyConstraint.java

@@ -30,7 +30,7 @@ public boolean isImplied() {
      */
     @Override
     public String toString() {
-        StringBuffer buf = new StringBuffer();
+        StringBuilder buf = new StringBuilder();
 
         buf.append(getChildTable());
         buf.append(".");

src/net/sourceforge/schemaspy/model/Table.java

@@ -220,7 +220,7 @@ private void initColumnAutoUpdate(Database db, boolean forceQuotes) throws SQLEx
         // we've got to get a result set with all the columns in it
         // so we can ask if the columns are auto updated
         // Ugh!!!  Should have been in DatabaseMetaData instead!!!
-        StringBuffer sql = new StringBuffer("select * from ");
+        StringBuilder sql = new StringBuilder("select * from ");
         if (getSchema() != null) {
             sql.append(getSchema());
             sql.append('.');
@@ -747,7 +747,7 @@ protected int fetchNumRows(Database db, Properties properties) throws SQLExcepti
     protected int fetchNumRows(Database db, String clause, boolean forceQuotes) throws SQLException {
         PreparedStatement stmt = null;
         ResultSet rs = null;
-        StringBuffer sql = new StringBuffer("select ");
+        StringBuilder sql = new StringBuilder("select ");
         sql.append(clause);
         sql.append(" from ");
         if (getSchema() != null) {

src/net/sourceforge/schemaspy/model/TableColumn.java

@@ -57,7 +57,7 @@ public class TableColumn {
         else
             length = rs.getInt("COLUMN_SIZE");
 
-        StringBuffer buf = new StringBuffer();
+        StringBuilder buf = new StringBuilder();
         buf.append(length);
         if (decimalDigits > 0) {
             buf.append(',');

src/net/sourceforge/schemaspy/model/TableIndex.java

@@ -78,7 +78,7 @@ public boolean isUnique() {
      * @return
      */
     public String getColumnsAsString() {
-        StringBuffer buf = new StringBuffer();
+        StringBuilder buf = new StringBuilder();
 
         for (TableColumn column : columns) {
             if (buf.length() > 0)

src/net/sourceforge/schemaspy/util/Dot.java

@@ -194,7 +194,7 @@ public boolean supportsRenderer(@SuppressWarnings("hiding") String renderer) {
      * Using the specified .dot file generates an image returning the image's image map.
      */
     public String generateDiagram(File dotFile, File diagramFile) throws DotFailure {
-        StringBuffer mapBuffer = new StringBuffer(1024);
+        StringBuilder mapBuffer = new StringBuilder(1024);
 
         BufferedReader mapReader = null;
         // this one is for executing.  it can (hopefully) deal with funky things in filenames.
@@ -245,7 +245,7 @@ public DotFailure(String msg) {
     }
 
     private static String getDisplayableCommand(String[] command) {
-        StringBuffer displayable = new StringBuffer();
+        StringBuilder displayable = new StringBuilder();
         for (int i = 0; i < command.length; ++i) {
             displayable.append(command[i]);
             if (i + 1 < command.length)

src/net/sourceforge/schemaspy/view/DotConnector.java

@@ -73,7 +73,7 @@ public void connectToChildTitle() {
 
     @Override
     public String toString() {
-        StringBuffer edge = new StringBuffer();
+        StringBuilder edge = new StringBuilder();
         edge.append("  \"");
         edge.append(childTable.getName());
         edge.append("\":\"");

src/net/sourceforge/schemaspy/view/DotNode.java

@@ -62,7 +62,7 @@ public void excludeColumn(TableColumn column) {
     @Override
     public String toString() {
         StyleSheet css = StyleSheet.getInstance();
-        StringBuffer buf = new StringBuffer();
+        StringBuilder buf = new StringBuilder();
         String tableName = table.getName();
         String colspan = config.showColumnDetails ? "COLSPAN=\"2\" " : "COLSPAN=\"3\" ";
 
@@ -166,7 +166,7 @@ else if (indexColumns.contains(column))
      * @return
      */
     private static String toNCR(String str) {
-        StringBuffer result = new StringBuffer();
+        StringBuilder result = new StringBuilder();
         for (int i = 0; i < str.length(); ++i) {
             char ch = str.charAt(i);
             if (ch <= 127) {    // don't confuse things unless necessary

src/net/sourceforge/schemaspy/view/HtmlColumnsPage.java

@@ -180,7 +180,7 @@ public void writeMainTableHeader(boolean hasTableIds, ColumnInfo selectedColumn,
     }
 
     private String getTH(ColumnInfo selectedColumn, String columnName, String title, String align) {
-        StringBuffer buf = new StringBuffer("  <th");
+        StringBuilder buf = new StringBuilder("  <th");
 
         if (align != null) {
             buf.append(" align='");

src/net/sourceforge/schemaspy/view/HtmlFormatter.java

@@ -115,7 +115,7 @@ protected void writeTableOfContents(boolean showOrphans, LineWriter html) throws
     }
 
     protected String getDescription(Database db, Table table, String text, boolean hoverHelp) {
-        StringBuffer description = new StringBuffer();
+        StringBuilder description = new StringBuilder();
         if (table != null) {
             if (table.isView())
                 description.append("View ");

src/net/sourceforge/schemaspy/view/HtmlOrphansPage.java

@@ -38,7 +38,7 @@ public boolean write(Database db, List<Table> orphanTables, File diagramDir, Lin
 
         html.writeln("<a name='diagram'>");
         try {
-            StringBuffer maps = new StringBuffer(64 * 1024);
+            StringBuilder maps = new StringBuilder(64 * 1024);
 
             for (Table table : orphanTables) {
                 String dotBaseFilespec = table.getName();

src/net/sourceforge/schemaspy/view/StyleSheet.java

@@ -41,7 +41,7 @@ public class StyleSheet {
 
     private StyleSheet(BufferedReader cssReader) throws IOException {
         String lineSeparator = System.getProperty("line.separator");
-        StringBuffer data = new StringBuffer();
+        StringBuilder data = new StringBuilder();
         String line;
 
         while ((line = cssReader.readLine()) != null) {