Merge pull request Expensify#46732 from margelo/e2e/lower-is-better

[NoQA] e2e: add `lowerIsBetter` for e2e metrics
kubabutkiewicz · Aug 5, 2024 · 40a6c76 · 40a6c76
2 parents 66ae374 + 83e36dd
commit 40a6c76
Showing 1 changed file with 10 additions and 1 deletion.
diff --git a/tests/e2e/compare/compare.ts b/tests/e2e/compare/compare.ts
@@ -29,6 +29,15 @@ const PROBABILITY_CONSIDERED_SIGNIFICANCE = 0.02;
  */
 const DURATION_DIFF_THRESHOLD_SIGNIFICANCE = 100;
 
+const LowerIsBetter: Record<Unit, boolean> = {
+    ms: true,
+    MB: true,
+    // eslint-disable-next-line @typescript-eslint/naming-convention
+    '%': true,
+    renders: true,
+    FPS: false,
+};
+
 function buildCompareEntry(name: string, compare: Stats, baseline: Stats, unit: Unit): Entry {
     const diff = compare.mean - baseline.mean;
     const relativeDurationDiff = diff / baseline.mean;
@@ -44,7 +53,7 @@ function buildCompareEntry(name: string, compare: Stats, baseline: Stats, unit:
         baseline,
         current: compare,
         diff,
-        relativeDurationDiff,
+        relativeDurationDiff: LowerIsBetter[unit] ? relativeDurationDiff : -relativeDurationDiff,
         isDurationDiffOfSignificance,
     };
 }