Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add govulncheck scan to Makefile #262

Merged
merged 2 commits into from
Oct 18, 2023
Merged

add govulncheck scan to Makefile #262

merged 2 commits into from
Oct 18, 2023

Conversation

sheharyaar
Copy link
Contributor

Signed-off-by: Mohammad Shehar Yaar Tausif sheharyaar48@gmail.com

@sheharyaar
Copy link
Contributor Author

It includes the test files via the -test flag

Copy link
Member

@kranurag7 kranurag7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @sheharyaar With the latest version of govulncheck, -v flag is not defined anymore, so we don't need that anymore. Rest looks good to me.

@sheharyaar
Copy link
Contributor Author

Sure, will make the required changes.

Signed-off-by: Mohammad Shehar Yaar Tausif <sheharyaar48@gmail.com>
@sheharyaar
Copy link
Contributor Author

@kranurag7 it's done

Copy link
Member

@kranurag7 kranurag7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @sheharyaar, thanks for working on this.

Makefile Outdated Show resolved Hide resolved
Signed-off-by: Mohammad Shehar Yaar Tausif <sheharyaar48@gmail.com>
@sheharyaar
Copy link
Contributor Author

It's done

@daemon1024
Copy link
Member

Will adding it to CI be a different task, @kranurag7 @sheharyaar ?

@kranurag7
Copy link
Member

Will adding it to CI be a different task, @kranurag7 @sheharyaar ?

Can be handled in a separate PR using this reusable action https://github.com/golang/govulncheck-action
It also requires more work, I'm not sure if the action returns a non-zero exit code when it finds some vulnerabilities. A good thing would be to take a look at how other repos are using this reusable action.
Ref: https://github.com/search?q=path%3A%2F%5E.github%5C%2Fworkflows%2F+golang%2Fgovulncheck&type=code

@kranurag7 kranurag7 merged commit 489d159 into kubearmor:main Oct 18, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants