Fix errors when running the test on Apple Silicon M1 #1886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We need to merge this PR after merging #1882. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gaocegege, tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
tenzen-y
force-pushed
the
specify-cpu-arch
branch
from
b60690d
to
03e96d9
Compare
|
I have fixed an error from shellcheck. |
johnugeorge
reviewed
Jun 6, 2022
|
/lgtm |
|
@johnugeorge @gaocegege Thanks for your review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
I fixed the following errors when running the test on Apple Silicon M1.
It seems that this error occurred when
setup-envtesttried to download the Kubernetes components binary for darwin/arm64 as described in this issue.So I specified CPU architecture when running the
setup-envtest.It seems that this error occurred since darwin/arm64 is not supported by the
github.com/shirou/gopsutilv2 as described in this issue.So I upgraded the
github.com/shirou/gopsutilversion to v3.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Checklist: