Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK] Fix types error #2424

Merged
merged 1 commit into from
Sep 5, 2024
Merged

Conversation

helenxie-bit
Copy link
Contributor

What this PR does / why we need it:
This PR adds __init__.py in types holder.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2422

Checklist:

  • Docs included if any changes are user facing

Signed-off-by: helenxie-bit <helenxiehz@gmail.com>
@andreyvelich
Copy link
Member

@helenxie-bit Thanks for fixing this, please can you verify locally that it resolves the issue ?
E.g. install SDK from your local branch, and test it:

pip install git+https://github.com/helenxie-bit/katib.git@<BRANCH>#subdirectory=sdk/python/v1beta1

@helenxie-bit
Copy link
Contributor Author

helenxie-bit commented Sep 5, 2024

@helenxie-bit Thanks for fixing this, please can you verify locally that it resolves the issue ? E.g. install SDK from your local branch, and test it:

pip install git+https://github.com/helenxie-bit/katib.git@<BRANCH>#subdirectory=sdk/python/v1beta1

@andreyvelich @Electronic-Waste I have tested the example code in the issue locally with this version of SDK and it finished successfully. It should fix the problem.

@Electronic-Waste
Copy link
Member

Thanks @helenxie-bit, it works!

@helenxie-bit
Copy link
Contributor Author

Thanks @helenxie-bit, it works!

@Electronic-Waste Glad to hear that!

@andreyvelich Please review when you have time. Thanks!

Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @helenxie-bit!
/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit bc09cfd into kubeflow:master Sep 5, 2024
63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SDK is broken when installed by git+https
3 participants