Skip to content

Commit

Permalink
Update comments
Browse files Browse the repository at this point in the history
Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
  • Loading branch information
andreyvelich committed Aug 26, 2024
1 parent 06e7653 commit 7aa4094
Showing 1 changed file with 1 addition and 6 deletions.
7 changes: 1 addition & 6 deletions pkg/apis/kubeflow.org/v2alpha1/trainingruntime_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,6 @@ type TrainingRuntimeList struct {

// TrainingRuntimeSpec represents a specification of the desired training runtime.
type TrainingRuntimeSpec struct {

// Configuration for the model training with ML-specific parameters.
MLPolicy *MLPolicy `json:"mlPolicy,omitempty"`

Expand All @@ -103,24 +102,22 @@ type JobSetTemplateSpec struct {

// PodGroupPolicy represents a PodGroup configuration for gang-scheduling.
type PodGroupPolicy struct {

// Configuration for gang-scheduling using various plugins.
PodGroupPolicySource `json:",inline"`
}

// PodGroupPolicySource represents supported plugins for gang-scheduling.
// Only one of its members may be specified.
type PodGroupPolicySource struct {

// Coscheduling plugin from the Kubernetes scheduler-plugins for gang-scheduling.
Coscheduling *CoschedulingPodGroupPolicySource `json:"coscheduling,omitempty"`

// TODO (andreyvelich): Add support for Volcano gang-scheduler.
}

// CoschedulingPodGroupPolicySource represents configuration for coscheduling plugin.
// The number of min members in the PodGroupSpec is always equal to the number of nodes.
type CoschedulingPodGroupPolicySource struct {

// Time threshold to schedule PodGroup for gang-scheduling.
// If the scheduling timeout is equal to 0, the default value is used.
// Defaults to 60 seconds.
Expand All @@ -129,7 +126,6 @@ type CoschedulingPodGroupPolicySource struct {

// MLPolicy represents configuration for the model trining with ML-specific parameters.
type MLPolicy struct {

// Number of training nodes.
// Defaults to 1.
NumNodes *int32 `json:"numNodes,omitempty"`
Expand All @@ -142,7 +138,6 @@ type MLPolicy struct {
// MLPolicySource represents the runtime-specific configuration for various technologies.
// One of the following specs can be set.
type MLPolicySource struct {

// Configuration for the PyTorch runtime.
Torch *TorchMLPolicySource `json:"torch,omitempty"`

Expand Down

0 comments on commit 7aa4094

Please sign in to comment.