Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP Fix peer dependencies and engine strict issue #4596

Closed
wants to merge 6 commits into from
Closed

WIP Fix peer dependencies and engine strict issue #4596

wants to merge 6 commits into from

Conversation

KhizerRehan
Copy link
Contributor

What this PR does / why we need it

This PR fix node_modules resolution on latest branch as some of the peer-dependencies are not installing due to v14 angular upgrade.

Dependencies Issue:

Secondly, Now it will throw an error if user doesn't have minimum node/npm version version defined in package.json file under engines property.

ℹ️ package.json doesn't support engineStrict as it only WARN but still install dependencies:

Which issue(s) this PR fixes

NONE

Special notes for your reviewer

Release note

NONE

@KhizerRehan
Throw error on node/npm version mismatch from package.json file
4fdc0d5 
Signed-off-by: KhizerRehan <khizerrehan92@gmail.com>
@KhizerRehan
Fix peer dependencies due to angular upgrade to v14
281cc13 
Signed-off-by: KhizerRehan <khizerrehan92@gmail.com>
@kubermatic-bot kubermatic-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Jun 15, 2022
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: KhizerRehan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 15, 2022
ahmedwaleedmalik and others added 4 commits June 15, 2022 18:01
@ahmedwaleedmalik
Upgrade to kubermatic build image with node v16.15.1
7499304 
Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
@KhizerRehan
Merge branch 'master' into fix-peer-dependecies-and-engine-strict-issue
87d2d21 
# Conflicts:
#	package-lock.json
@KhizerRehan
Update lock file for peer dependencies due to angular upgrade to v14
df16ae2 
Signed-off-by: KhizerRehan <khizerrehan92@gmail.com>
@KhizerRehan
Merge branch 'fix-peer-dependecies-and-engine-strict-issue' of github…
a861e31 
….com:KhizerRehan/dashboard into fix-peer-dependecies-and-engine-strict-issue
@kubermatic-bot
Copy link
Contributor

@KhizerRehan: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pre-dashboard-test-e2e a861e31 link false /test pre-dashboard-test-e2e
pre-dashboard-test-unit a861e31 link true /test pre-dashboard-test-unit
pre-dashboard-check-static a861e31 link true /test pre-dashboard-check-static
pre-dashboard-test-e2e-ce a861e31 link false /test pre-dashboard-test-e2e-ce
pre-dashboard-build-image-ce a861e31 link true /test pre-dashboard-build-image-ce
pre-dashboard-build-image a861e31 link true /test pre-dashboard-build-image

Full PR test history

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@KhizerRehan
Copy link
Contributor Author

/hold

@kubermatic-bot kubermatic-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 16, 2022
@KhizerRehan KhizerRehan changed the title Fix peer dependencies and engine strict issue ~~Hold-till-3rd-parties-dependencies are not updated ~~Fix peer dependencies and engine strict issue Jun 17, 2022
@KhizerRehan KhizerRehan changed the title ~~Hold-till-3rd-parties-dependencies are not updated ~~Fix peer dependencies and engine strict issue WIP Fix peer dependencies and engine strict issue Jun 17, 2022
@kubermatic-bot kubermatic-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 17, 2022
@ahmedwaleedmalik
Copy link
Member

Closing this PR in favor of #4699

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KhizerRehan @kubermatic-bot @ahmedwaleedmalik