This repository has been archived by the owner on Mar 6, 2024. It is now read-only.
Ferry service cluster #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubermatic-bot
added
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nmiculinic The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubermatic-bot
added
approved
…ster # Conflicts: # pkg/ferry/ferry.go
…cluster # Conflicts: # Makefile # config/internal/ferry/default/kustomization.yaml # config/internal/ferry/rbac/role.yaml # config/internal/manager/crd/kustomization.yaml # config/operator/crd/bases/operator.kubecarrier.io_serviceclusterregistrations.yaml # config/operator/crd/kustomization.yaml # hack/codegen.sh # hack/gen-intelij-tasks.sh # pkg/apis/operator/v1alpha1/serviceclusterregistration_types.go # pkg/ferry/ferry.go # pkg/internal/resources/ferry/ferry.go # pkg/internal/resources/ferry/ferry.golden.yaml # pkg/internal/resources/ferry/statik.go # pkg/internal/resources/manager/manager.golden.yaml # pkg/internal/resources/manager/statik.go # pkg/internal/resources/operator/operator.golden.yaml # pkg/internal/resources/operator/statik.go # pkg/operator/operator.go # test/admin/ferry.go
kubermatic-bot
added
the
needs-rebase
nmiculinic
changed the title
Co-Authored-By: Nico Schieder <nico@loodse.com>
nmiculinic
force-pushed
the
federation-service-cluster
branch
from
6f7686e
to
42e8a6c
Compare
kubermatic-bot
removed
the
needs-rebase
nmiculinic
force-pushed
the
federation-service-cluster
branch
from
acc8953
to
b0cc814
Compare
jiachengxu
suggested changes
Jan 14, 2020
kubermatic-bot
added
the
needs-rebase
kubermatic-bot
removed
the
needs-rebase
|
LGTM label has been added. Git tree hash: 3917ba0f583271f975abadb06929a6bdeb3fe73c
|
|
/unhold |
kubermatic-bot
removed
the
do-not-merge/hold
thetechnick
added a commit
that referenced
this pull request
Jan 27, 2020
* Added tender controller & serviceclusterregistration object * Updated the tender role & added serviceClusterRegistration to the operator * moved serviceclusterregistration ControllerObjects closer to their usage * Added cmd logging mixin * Added tender cmd log mixing * update * Renamed tender to ferry * small nit * minor update * updated inline with master * Added service cluster controller * fixed e2e test and made sure it's working * renamed components * Refactored and simplified ferry main.go * fixed merging * Fixed rest of forgotten merge conflicts screwing up the e2e tests * lint * Changed group from core.kubecarrier.io to kubecarrier.io * Update pkg/ferry/internal/controllers/servicecluster_controller.go Co-Authored-By: Nico Schieder <nico@loodse.com> * Added display name to serviceCluster printer column * Made ServiceCluster upsert operation result more verbose * renamed upsert to create or update * renamed service-cluster to serviceCluster * WIP --> debugging why merging master broke the build * fixed e2e tests * Made serviceCluster query serviceClusterVersion * renamed cluster version to only Version * update Co-authored-by: Nico Schieder <Nico.schieder@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds ServiceCluster controller to the Ferry. It periodically checks the service clusters' status and reports back to the master cluster, which is an appropriate object in the provider namespace.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #90