Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix multiple load balancers in one tenant #62

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Fix multiple load balancers in one tenant #62

merged 1 commit into from
Sep 11, 2024

Conversation

jan-walther
Copy link
Contributor

@jan-walther jan-walther commented Sep 10, 2024 •
edited by ahmedwaleedmalik
Loading

What this PR does / why we need it:
This PR fixes having multiple load balancer for a single tenant. If you continue after checking if the addressesMap, no second cluster and listener(s) will be created leaving only a single service on the load balancer.

Which issue(s) this PR fixes:

Fixes #

What type of PR is this?
/kind bug

Special notes for your reviewer:
This blocks a customer, a fast review would be appreciated.

Does this PR introduce a user-facing change? Then add your Release Note here:

Fix a bug that prevented multiple load balancers from a single tenant.

Documentation:

NONE

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. dco-signoff: no Denotes that at least one commit in the pull request doesn't have a valid DCO signoff message. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 10, 2024
@kubermatic-bot
Copy link
Contributor

Hi @jan-walther. Thanks for your PR.

I'm waiting for a kubermatic member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubermatic-bot kubermatic-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 10, 2024
@kubermatic-bot kubermatic-bot added dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. and removed dco-signoff: no Denotes that at least one commit in the pull request doesn't have a valid DCO signoff message. labels Sep 10, 2024
@embik
Copy link
Member

embik commented Sep 10, 2024

/ok-to-test

@kubermatic-bot kubermatic-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 10, 2024
ahmedwaleedmalik
ahmedwaleedmalik reviewed Sep 11, 2024
View reviewed changes
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jan-walther for the contribution. Left a comment and can you please fix the failing CI jobs/tests.

internal/envoy/resource.go Show resolved Hide resolved
@jan-walther
Fix multiple load balancers in one tenant
68a3ca3 
Signed-off-by: Jan Walther <jan.walther@sva.de>
@jan-walther
Copy link
Contributor Author

/retest

ahmedwaleedmalik
ahmedwaleedmalik approved these changes Sep 11, 2024
View reviewed changes
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

I'll move ahead and merge this PR. I can take a look at #62 (comment) in a follow-up PR.

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 11, 2024
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7ea4dd3e2866dbd22c17260e1fd49af9aa5a9d30

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 11, 2024
@kubermatic-bot kubermatic-bot merged commit 70c5280 into kubermatic:main Sep 11, 2024
12 checks passed
@ahmedwaleedmalik ahmedwaleedmalik mentioned this pull request Sep 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmedwaleedmalik ahmedwaleedmalik ahmedwaleedmalik approved these changes

Assignees

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jan-walther @kubermatic-bot @embik @ahmedwaleedmalik