Deploy default-storage-class addon by default #3332
Conversation
Unless it's already configured and there is no another default StorageClass Signed-off-by: Artiom Diomin <artiom@kubermatic.com>
kubermatic-bot
added
docs/tbd
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubermatic-bot
added
the
size/M
Signed-off-by: Artiom Diomin <artiom@kubermatic.com>
| if !foundDefaultStorageClass { | ||
| addonsToDeploy = append(addonsToDeploy, addonAction{ | ||
| name: resources.AddonDefaultStorageClass, | ||
| }) | ||
| } |
There was a problem hiding this comment.
We should have a way to disable deployment of this addon. Do we already have that in place?
There was a problem hiding this comment.
no. there was no such way.
There was a problem hiding this comment.
Well, with delete: true it will be deleted everytime (which after the first time will have no affect any more). And once the used will have own default SC, this addon will be stopped from adding.
Unless it's already configured and there is no another default StorageClass
Which issue(s) this PR fixes:
Fixes #2708
What type of PR is this?
/kind feature
Special notes for your reviewer:
Does this PR introduce a user-facing change? Then add your Release Note here:
Documentation: