Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

one snapshot create many snap file & much slow #243

Closed
daresheep opened this issue Feb 2, 2021 · 5 comments
Closed

one snapshot create many snap file & much slow #243

daresheep opened this issue Feb 2, 2021 · 5 comments
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@daresheep
Copy link

daresheep commented Feb 2, 2021

Dears,

csi-driver-host-path version : V1.4 /V1.5
external-snapshotter: v4.0

kubectl get pvc           
NAME            STATUS   VOLUME                                     CAPACITY   ACCESS MODES   STORAGECLASS      AGE
iso-win         Bound    pvc-d9de552d-0e49-4abd-a368-f22b9c92010b   28Gi       RWO            csi-hostpath-sc   38m
iso-win-block   Bound    pvc-16e7d86f-fd29-4bb9-b5cd-0f4c37af2d9d   28Gi       RWO            csi-hostpath-sc   19m

try to create a snapshot for iso-win use below yaml:

apiVersion: snapshot.storage.k8s.io/v1beta1
kind: VolumeSnapshot
metadata:
  name: new-snapshot-demo
spec:
  volumeSnapshotClassName: csi-hostpath-snapclass
  source:
    persistentVolumeClaimName: iso-win
kubectl apply -f csi-snapshot-v1beta1.yaml 
volumesnapshot.snapshot.storage.k8s.io/new-snapshot-demo created

watch at csi-data-path ,a lot of snap files created. each 1min .

image

image

Here is some logs for hostpath

kubectl logs -f csi-hostpathplugin-0 hostpath

I0203 11:12:21.879787       1 identityserver.go:40] Using default GetPluginInfo
I0203 11:12:21.879795       1 server.go:123] GRPC response: {"name":"hostpath.csi.k8s.io","vendor_version":"v1.4.0-rc2-0-gee6beeaf"}
I0203 11:12:21.883128       1 server.go:117] GRPC call: /csi.v1.Controller/CreateSnapshot
I0203 11:12:21.883142       1 server.go:118] GRPC request: {"name":"snapshot-023764b9-7119-4acf-8cd7-33ba0712c5cf","source_volume_id":"e5b4c966-656e-11eb-894d-5e012443d7b4"}
I0203 11:12:21.883640       1 controllerserver.go:337] Creating snapshot of Raw Block Mode Volume


I0203 11:14:21.875027       1 identityserver.go:40] Using default GetPluginInfo
I0203 11:14:21.875035       1 server.go:123] GRPC response: {"name":"hostpath.csi.k8s.io","vendor_version":"v1.4.0-rc2-0-gee6beeaf"}
I0203 11:14:21.877528       1 server.go:117] GRPC call: /csi.v1.Controller/CreateSnapshot
I0203 11:14:21.877539       1 server.go:118] GRPC request: {"name":"snapshot-023764b9-7119-4acf-8cd7-33ba0712c5cf","source_volume_id":"e5b4c966-656e-11eb-894d-5e012443d7b4"}
I0203 11:14:21.878870       1 controllerserver.go:337] Creating snapshot of Raw Block Mode Volume


I0203 11:15:21.891059       1 identityserver.go:40] Using default GetPluginInfo
I0203 11:15:21.891067       1 server.go:123] GRPC response: {"name":"hostpath.csi.k8s.io","vendor_version":"v1.4.0-rc2-0-gee6beeaf"}
I0203 11:15:21.892157       1 server.go:117] GRPC call: /csi.v1.Controller/CreateSnapshot
I0203 11:15:21.892163       1 server.go:118] GRPC request: {"name":"snapshot-023764b9-7119-4acf-8cd7-33ba0712c5cf","source_volume_id":"e5b4c966-656e-11eb-894d-5e012443d7b4"}
I0203 11:15:21.892466       1 controllerserver.go:337] Creating snapshot of Raw Block Mode Volume
I0203 11:15:23.578579       1 server.go:117] GRPC call: /csi.v1.Identity/Probe


I0203 11:17:21.870112       1 server.go:123] GRPC response: {"name":"hostpath.csi.k8s.io","vendor_version":"v1.4.0-rc2-0-gee6beeaf"}
I0203 11:17:21.872851       1 server.go:117] GRPC call: /csi.v1.Controller/CreateSnapshot
I0203 11:17:21.872873       1 server.go:118] GRPC request: {"name":"snapshot-023764b9-7119-4acf-8cd7-33ba0712c5cf","source_volume_id":"e5b4c966-656e-11eb-894d-5e012443d7b4"}
I0203 11:17:21.873669       1 controllerserver.go:337] Creating snapshot of Raw Block Mode Volume
I0203 11:17:23.578983       1 server.go:117] GRPC call: /csi.v1.Identity/Probe

@aayushrangwala
Copy link
Contributor

@daresheep Can you please confirm and post the cmd output, if multiple snapshots are created for the same PV and same VolumeSnapshot CR. Or if not, then can you please monitor the generation id is same everytime on the reconciliation or the controller is creating the same snapshot multiple times.

As discussed in the other PR, the logs with CreateSnapshot seems to be just the reconcilation log for checking the snapshot

@k8s-triage-robot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 26, 2021
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 25, 2021
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

@k8s-ci-robot
Copy link
Contributor

@k8s-triage-robot: Closing this issue.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

xing-yang added a commit to xing-yang/csi-driver-host-path that referenced this issue Nov 27, 2023
f8c8cc4c Merge pull request kubernetes-csi#237 from msau42/prow
b36b5bfd Merge pull request kubernetes-csi#240 from dannawang0221/upgrade-go-version
adfddcc9 Merge pull request kubernetes-csi#243 from pohly/git-subtree-pull-fix
c4650889 pull-test.sh: avoid "git subtree pull" error
7b175a1e Update csi-test version to v5.2.0
987c90cc Update go version to 1.21 to match k/k
2c625d41 Add script to generate patch release notes
f9d5b9c0 Merge pull request kubernetes-csi#236 from mowangdk/feature/bump_csi-driver-host-path_version
b01fd537 Bump csi-driver-host-path version up to v1.12.0
984feece Merge pull request kubernetes-csi#234 from siddhikhapare/csi-tools
1f7e6059 fixed broken links of testgrid dashboard
de2fba88 Merge pull request kubernetes-csi#233 from andyzhangx/andyzhangx-patch-1
cee895e1 remove windows 20H2 build since it's EOL long time ago
670bb0ef Merge pull request kubernetes-csi#229 from marosset/fix-codespell-errors
35d5e783 Merge pull request kubernetes-csi#219 from yashsingh74/update-registry
63473cc9 Merge pull request kubernetes-csi#231 from coulof/bump-go-version-1.20.5
29a5c76c Merge pull request kubernetes-csi#228 from mowangdk/chore/adopt_kubernetes_recommand_labels
8dd28211 Update cloudbuild image with go 1.20.5
1df23dba Merge pull request kubernetes-csi#230 from msau42/prow
1f92b7e7 Add ginkgo timeout to e2e tests to help catch any stuck tests
2b8b80ea fixing some codespell errors
c10b6780 Merge pull request kubernetes-csi#227 from coulof/check-sidecar-supported-versions
72984ec0 chore: adopt kubernetes recommand label
b0555351 Header
bd0a10b6 typo
c39d73c3 Add comments
f6491af0 Script to verify EOL sidecar version
901bcb5a Update registry k8s.gcr.io -> registry.k8s.io

git-subtree-dir: release-tools
git-subtree-split: f8c8cc4c7414c11526f14649856ff8e6b8a4e67c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

4 participants