-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
merge mock and hostpath driver #247
Comments
We discussed this and came to the conclusion that as long as we only need to maintain one driver it doesn't matter too much which one we pick. However, the hostpath driver seems to be a better starting point because it is more widely used (several Prow jobs), is more realistic (actual mounts) and more complete (raw block support), and can be released independently because it is in its own repo. The mock driver currently must be released together with csi-sanity. So here's a tentative plan:
|
With #269 and the below changes in Kubernetes e2e, I could able to run mock csi storage tests:
|
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-contributor-experience at kubernetes/community. |
/reopen All functionality was moved over into csi-driver-host-path and only that driver is used now. However, we still need to remove the mock driver source code and then at some point do a csi-test release without it. |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-contributor-experience at kubernetes/community. |
/remove-lifecycle rotten |
49676850 Merge pull request kubernetes-csi#254 from bells17/add-github-actions d9bd160c Update skip list in codespell GitHub Action adb3af9d Merge pull request kubernetes-csi#252 from bells17/update-go-version f5aebfc9 Add GitHub Actions workflows b82ee388 Merge pull request kubernetes-csi#253 from bells17/fix-typo c3174562 Fix typo 0a785056 Bump to Go 1.22.3 edd89ad5 Merge pull request kubernetes-csi#251 from jsafrane/add-logcheck 043fd099 Add test-logcheck target d7535ae0 Merge pull request kubernetes-csi#250 from jsafrane/go-1.22 b52e7ad3 Update go to 1.22.2 14fdb6f6 Merge pull request kubernetes-csi#247 from msau42/prow 9b4352e9 Update release playbook c7bb972c Fix release notes script to use fixed tags 463a0e9f Add script to update specific go modules git-subtree-dir: release-tools git-subtree-split: 49676850e1c9c41b263720e1756322d9e35edd73
Both mock and hostpath driver are used for testing, just in different configurations and with different capabilities of the driver. It's not clear whether there actually is a reason to maintain two different drivers. Perhaps they should be merged into one.
Existing capabilities:
Missing capabilities:
The text was updated successfully, but these errors were encountered: