Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update release tools #235

Merged
merged 2 commits into from
Jan 26, 2021
Merged

Conversation

kvaps
Copy link
Contributor

@kvaps kvaps commented Jan 18, 2021

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR is needed to test the functionality introduced in kubernetes-csi/csi-release-tools#121

Squashed 'release-tools/' changes from c6a88c6e..ece0f500

ece0f500 check namespace for snapshot-controller
3b6d17b1 Merge pull request #118 from pohly/cloud-build-timeout
9318c6cc cloud build: double the timeout, now 1 hour
86ff5802 Merge pull request #116 from andyzhangx/export-image-name
c3a96625 allow export image name and registry name

git-subtree-dir: release-tools
git-subtree-split: ece0f500ed9ee6c197ffce6d410d12edd8bf7365

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. labels Jan 18, 2021
@k8s-ci-robot
Copy link
Contributor

Welcome @kvaps!

It looks like this is your first PR to kubernetes-csi/csi-driver-host-path 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-csi/csi-driver-host-path has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @kvaps. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 18, 2021
@xing-yang
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 19, 2021
@xing-yang
Copy link
Contributor

/assign @pohly

Copy link
Contributor

@pohly pohly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please re-do the git subtree pull with the --squash option.

I know, we (someone?) needs to update the README.md...

@kvaps kvaps closed this Jan 19, 2021
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 19, 2021
@pohly
Copy link
Contributor

pohly commented Jan 19, 2021

There are no changes left?

I think this was supposed to be a test PR for kubernetes-csi/csi-release-tools#121, right?

That means you have to point git subtree at a repo and commit which includes the non-upstream csi-release-tools changes.

@kvaps kvaps reopened this Jan 19, 2021
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 19, 2021
@kvaps
Copy link
Contributor Author

kvaps commented Jan 19, 2021

Yeah, sorry, I was just bit confused by amount of repos 😅 and forget to do subtree pull in this one

@xing-yang
Copy link
Contributor

Please copy the commit message from "5961195" to the PR description for the record.

@xing-yang
Copy link
Contributor

/hold

This is a test PR. Adding hold to avoid it from being merged.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 19, 2021
@pohly
Copy link
Contributor

pohly commented Jan 19, 2021

Looks good to me.

@pohly
Copy link
Contributor

pohly commented Jan 19, 2021

/hold

This is a test PR. Adding hold to avoid it from being merged.

We used to have a unit test which prevents merging if it detects new commits, but squashing circumvents that check.

I guess our rule should be:

  • squash if you intend to get the PR merged and the squashed commit is really from upstream csi-release-tools
  • don't squash when testing additional commits before merging into csi-release-tools

Oh, and a PR description which makes the intention clear 😉

Copy link
Contributor

@pohly pohly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 25, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kvaps, pohly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 25, 2021
@pohly
Copy link
Contributor

pohly commented Jan 25, 2021

It's okay to merge this because it squashed the exact same commit that I just approved for csi-release-tools.

@pohly
Copy link
Contributor

pohly commented Jan 25, 2021

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 25, 2021
@kvaps
Copy link
Contributor Author

kvaps commented Jan 25, 2021

/retest

@pohly
Copy link
Contributor

pohly commented Jan 25, 2021

Fix for failing tests is here: kubernetes/test-infra#20596

fe1f2848 Merge pull request kubernetes-csi#121 from kvaps/namespace-check
8fdf0f78 Merge pull request kubernetes-csi#128 from fengzixu/master
1c94220d fix: fix a bug of csi-sanity
a4c41e6a Merge pull request kubernetes-csi#127 from pohly/fix-boilerplate
ece0f50 check namespace for snapshot-controller
dbd89672 verify-boilerplate.sh: fix path to script
9289fd16 Merge pull request kubernetes-csi#125 from sachinkumarsingh092/optional-spelling-boilerplate-checks
ad29307f Make the spelling and boilerplate checks optional
5f06d024 Merge pull request kubernetes-csi#124 from sachinkumarsingh092/fix-spellcheck-boilerplate-tests
48186eba Fix spelling and boilerplate errors
71690aff Merge pull request kubernetes-csi#122 from sachinkumarsingh092/include-spellcheck-boilerplate-tests
981be3fe Adding spelling and boilerplate checks.
2bb7525 Merge pull request kubernetes-csi#117 from fengzixu/master
3b6d17b Merge pull request kubernetes-csi#118 from pohly/cloud-build-timeout
9318c6c cloud build: double the timeout, now 1 hour
4ab8b15 use the tag to replace commit of csi-test
5d74e45 change the csi-test import path to v4
7dcd0a9 upgrade csi-test to v4.0.2
86ff580 Merge pull request kubernetes-csi#116 from andyzhangx/export-image-name
c3a9662 allow export image name and registry name

git-subtree-dir: release-tools
git-subtree-split: fe1f284817af983ce0f0329fa3a0d55f577aa727
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 25, 2021
@pohly
Copy link
Contributor

pohly commented Jan 26, 2021

/retest

@pohly
Copy link
Contributor

pohly commented Jan 26, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 26, 2021
@k8s-ci-robot
Copy link
Contributor

@kvaps: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kubernetes-csi-csi-driver-host-path-1-17-on-kubernetes-1-17 a489085 link /test pull-kubernetes-csi-csi-driver-host-path-1-17-on-kubernetes-1-17
pull-kubernetes-csi-csi-driver-host-path-1-20-on-kubernetes-1-20 44fb49f link /test pull-kubernetes-csi-csi-driver-host-path-1-20-on-kubernetes-1-20

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot merged commit 3707289 into kubernetes-csi:master Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants