Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust the tag in deployment of node plugin yaml #78

Merged
merged 2 commits into from
Dec 17, 2021
Merged

Adjust the tag in deployment of node plugin yaml #78

merged 2 commits into from
Dec 17, 2021

Conversation

humblec
Copy link
Contributor

@humblec humblec commented Dec 17, 2021

/kind bug
/kind cleanup

What this PR does / why we need it:
The deployment fails as by default latest tag has been fetched from the dockerhub. This commit changes the tag to canary till we have a release tag

This PR also change the deployment yaml name of example pod from nginx.yaml to pod.yaml.

in the staging repo

NONE

@humblec
rename nginx.yaml to pod.yaml in the examples directory
f18a178 
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
@humblec
The deployment fails as by default latest tag has been fetched
75a857a 
This commit changes the tag to canary till we have a release tag
in the staging repo

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 17, 2021
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 17, 2021
@humblec
Copy link
Contributor Author

humblec commented Dec 17, 2021

/assign @andyzhangx

andyzhangx
andyzhangx approved these changes Dec 17, 2021
View reviewed changes
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 17, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, humblec

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 62a068d into kubernetes-csi:master Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyzhangx andyzhangx andyzhangx approved these changes

@chrishenzie chrishenzie Awaiting requested review from chrishenzie

@jingxu97 jingxu97 Awaiting requested review from jingxu97

Assignees

@andyzhangx andyzhangx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@humblec @k8s-ci-robot @andyzhangx