Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: parsing driver parameter issue #96

Merged
merged 7 commits into from
Feb 4, 2022
Merged

fix: parsing driver parameter issue #96

merged 7 commits into from
Feb 4, 2022

Conversation

andyzhangx
Copy link
Member

@andyzhangx andyzhangx commented Feb 2, 2022 •
edited
Loading

What type of PR is this?
/kind bug

What this PR does / why we need it:
fix: parsing driver parameter issue

it works now with this image: andyzhangx/iscsi-csi:v0.1.6

Which issue(s) this PR fixes:

Fixes #93, #94

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

fix: parsing driver parameter issue

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. labels Feb 2, 2022
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 2, 2022
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 2, 2022
@humblec
Copy link
Contributor

humblec commented Feb 2, 2022

@andyzhangx Thanks !! one small thing about the vendor lib.. I have to push the changes to the upstream lib and sync it though. 👍

@humblec
Copy link
Contributor

humblec commented Feb 4, 2022

Thanks @andyzhangx , once the test pass, we will get this in. 👍

@andyzhangx andyzhangx mentioned this pull request Feb 4, 2022
Closed
@humblec
Copy link
Contributor

humblec commented Feb 4, 2022

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 4, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, humblec

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 735d8a5 into kubernetes-csi:master Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@humblec humblec Awaiting requested review from humblec

@j-griffith j-griffith Awaiting requested review from j-griffith

@xing-yang xing-yang Awaiting requested review from xing-yang

Assignees

@humblec humblec

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

errcode:(executable file not found in $PATH)** output:()
3 participants
@andyzhangx @humblec @k8s-ci-robot