Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable spelling and boilerplate check #128

Closed
andyzhangx opened this issue Jan 3, 2021 · 3 comments · Fixed by kubernetes-csi/csi-release-tools#122 or #134
Closed

enable spelling and boilerplate check #128

andyzhangx opened this issue Jan 3, 2021 · 3 comments · Fixed by kubernetes-csi/csi-release-tools#122 or #134
Assignees
@sachinkumarsingh092
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. sig/testing Categorizes an issue or PR as relevant to SIG Testing.

Comments

@andyzhangx
Copy link
Member

andyzhangx commented Jan 3, 2021 •
edited
Loading

Is your feature request related to a problem?/Why is this needed

Describe the solution you'd like in detail

#127 disabled following two checks:

  • verify-spelling.sh
  • verify-boilerplate.sh

need to upstream the above two scripts to https://github.com/kubernetes-csi/csi-release-tools.git and then re-enable these two scripts in this project

Describe alternatives you've considered

Additional context

error: docs/csi-dev.md:38:12: "environmnet" is a misspelling of "environments"
error: docs/csi-dev.md:89:6: "environmnet" is a misspelling of "environments"
error: release-tools/SIDECAR_RELEASE_PROCESS.md:14:17: "maintainence" is a misspelling of "maintenance"
error: release-tools/prow.sh:76:31: "seperately" is a misspelling of "separately"
error: release-tools/prow.sh:296:37: "seperated" is a misspelling of "separated"
error: release-tools/prow.sh:1001:32: "succesful" is a misspelling of "successful"
Found spelling errors!
Cleaning up...
Makefile:46: recipe for target 'verify' failed
make: *** [verify] Error 1
Error: Process completed with exit code 2.
@andyzhangx andyzhangx added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jan 3, 2021
@andyzhangx
Copy link
Member Author

@sachinkumarsingh092 could you help? thanks.

@sachinkumarsingh092
Copy link
Contributor

sachinkumarsingh092 commented Jan 5, 2021 •
edited
Loading

So we just have to push the hack/boilerplate, hack/verify-spellcheck.sh and hack/boilerplate.sh to https://github.com/kubernetes-csi/csi-release-tools.git, modify the build.make there to include these tests and after this is merged we can git subtree pull it for this repo. Is this correct or am I missing something?

/assign

@andyzhangx
Copy link
Member Author

So we just have to push the hack/boilerplate, hack/verify-spellcheck.sh and hack/boilerplate.sh to https://github.com/kubernetes-csi/csi-release-tools.git, modify the build.make there to include these tests and after this is merged we can git subtree pull it for this repo. Is this correct or am I missing something?

/assign

correct, thanks.

@sachinkumarsingh092 sachinkumarsingh092 mentioned this issue Jan 6, 2021
Merged
@andyzhangx andyzhangx reopened this Jan 7, 2021
This was referenced Jan 12, 2021
Merged
Merged
@pohly pohly mentioned this issue Jan 26, 2021
Merged
pohly added a commit to pohly/csi-driver-nfs that referenced this issue Jan 26, 2021
@pohly
Squashed 'release-tools/' changes from 9289fd1..1d60e77
7ca2890 
1d60e77 Merge pull request kubernetes-csi#131 from pohly/kubernetes-1.20-tag
9f10459 prow.sh: support building Kubernetes for a specific version
fe1f284 Merge pull request kubernetes-csi#121 from kvaps/namespace-check
8fdf0f7 Merge pull request kubernetes-csi#128 from fengzixu/master
1c94220 fix: fix a bug of csi-sanity
a4c41e6 Merge pull request kubernetes-csi#127 from pohly/fix-boilerplate
ece0f50 check namespace for snapshot-controller
dbd8967 verify-boilerplate.sh: fix path to script

git-subtree-dir: release-tools
git-subtree-split: 1d60e7792624a9938c0bd1b045211fbb89e513d6
dobsonj pushed a commit to dobsonj/csi-driver-nfs that referenced this issue Oct 16, 2023
@openshift-merge-robot
Merge pull request kubernetes-csi#128 from shiftstack/merge-bot-master
28c0ed3 
Merge https://github.com/kubernetes-csi/csi-driver-nfs:master into master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sachinkumarsingh092 sachinkumarsingh092

Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. sig/testing Categorizes an issue or PR as relevant to SIG Testing.
Projects
None yet
Milestone
No milestone
2 participants
@andyzhangx @sachinkumarsingh092