Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: upgrade to csi-provisioner v5.0.2 on v4.8.0 chart #750

Merged
merged 2 commits into from
Aug 29, 2024
Merged

fix: upgrade to csi-provisioner v5.0.2 on v4.8.0 chart #750

merged 2 commits into from
Aug 29, 2024

Conversation

andyzhangx
Copy link
Member

@andyzhangx andyzhangx commented Aug 28, 2024 •
edited
Loading

What type of PR is this?
/kind bug

What this PR does / why we need it:
fix: upgrade to csi-provisioner v5.0.2 on v4.8.0 chart

This PR upgrades csi-provisioner to v5.0.2 to avoid DeleteVolume twice
this PR also disables remove-archived-volume-path by default

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

fix: upgrade to csi-provisioner v5.0.2 on v4.8.0 chart

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 28, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 28, 2024
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 28, 2024
@coveralls
Copy link

coveralls commented Aug 28, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10598355920

Details

  • 2 of 7 (28.57%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 78.659%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/nfs/controllerserver.go 1 6 16.67%
Totals Coverage Status
Change from base Build 10588000119: -0.2%
Covered Lines: 903
Relevant Lines: 1148
💛 - Coveralls

@andyzhangx andyzhangx changed the title fix: disable archiving InternalVolumePath by default fix: upgrade to csi-provisioner v5.0.2 Aug 28, 2024
@andyzhangx andyzhangx changed the title fix: upgrade to csi-provisioner v5.0.2 fix: upgrade to csi-provisioner v5.0.2 on v4.8.0 chart Aug 28, 2024
@andyzhangx andyzhangx force-pushed the disable-archivedInternalVolumePath branch from 77b8700 to ab06ad3 Compare August 28, 2024 11:58
@andyzhangx andyzhangx merged commit d3d72c7 into kubernetes-csi:master Aug 29, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlory carlory Awaiting requested review from carlory

@pohly pohly Awaiting requested review from pohly

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andyzhangx @k8s-ci-robot @coveralls