Add StartOnAddress function to listen on unix:// paths #165
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/S
| @@ -61,6 +61,12 @@ func (m *MockCSIDriver) Start() error { | |||
| return nil | |||
| } | |||
|
|
|||
| // StartOnAddress starts a new gRPC server listening on a random TCP loopback port. | |||
| func (m *MockCSIDriver) Start() error { | |||
There was a problem hiding this comment.
Comment doesn't match the method.
I know it wasn't document before either (or at least not here), but when using random port allocation, how does the caller determine how to reach the mock driver, i.e. determine the port?
There was a problem hiding this comment.
Good catch, comment is fixed now. Caller can call MockCSIDriver.Address() to get the actual address.
jsafrane
force-pushed
the
add-mock-address
branch
from
ba7d9d3
to
ddb689f
Compare
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jsafrane, pohly The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
@lpabon, can you please release new version of csi-test? It blocks kubernetes-csi/external-attacher#123 |
|
I'd like to see PR #156 merged first. Then the new release becomes the first real-world test of image publishing with those build rules. |
Cherry-pick #165 to release-1.0: Add StartOnAddress function to listen on unix:// paths
Add StartOnAddress function to listen on unix:// paths
No description provided.