Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual cherry pick of #1250: Update lib-external-provisioner to v10.0.1 #1251

Conversation

jsafrane
Copy link
Contributor

@jsafrane jsafrane commented Aug 6, 2024

Cherry pick of #1250 on release-5.0.

#1250: Update lib-external-provisioner to v10.0.1

This is not a simple cherry pick

  • I had to partially cherry-pick Promote CSINodeExpandSecret to GA #1218 to fix typos in pkg/controller/controller_test.go (without actually updating the feature to GA)
  • I had to update release-tools to fix a typo in release-tools/SIDECAR_RELEASE_PROCESS.md.

For details on the cherry pick process, see the cherry pick requests page.

* Fixed removal of PV protection finalizer. PVs are no longer Terminating forever after PVC deletion.
* Updated go to 1.22.5

Update sigs.k8s.io/sig-storage-lib-external-provisioner to the latest
release to fix removal of the PV finalizer.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 6, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Aug 6, 2024
This is a partial cherry pick of 6625a06 that fixed typos in the master
branch. These typos block merges in github.
988496a1f Merge pull request kubernetes-csi#257 from jakobmoellerdev/csi-prow-sidecar-e2e-path
028f8c698 chore: bump to Go 1.22.5
69bd71e8a chore: add CSI_PROW_SIDECAR_E2E_PATH
f40f0ccd4 Merge pull request kubernetes-csi#256 from solumath/master
cfa92106c Instruction update
379a1bb9b Merge pull request kubernetes-csi#255 from humblec/sidecar-md
a5667bbbb fix typo in sidecar release process
49676850e Merge pull request kubernetes-csi#254 from bells17/add-github-actions
d9bd160c2 Update skip list in codespell GitHub Action
f5aebfc9f Add GitHub Actions workflows

git-subtree-dir: release-tools
git-subtree-split: 988496a1fc3849ed793e03012fdd56813d13d46c
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 6, 2024
@jsafrane jsafrane changed the title Automated cherry pick of #1250: Update lib-external-provisioner to v10.0.1 Manual cherry pick of #1250: Update lib-external-provisioner to v10.0.1 Aug 6, 2024
Copy link
Contributor

@bertinatto bertinatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 6, 2024
@k8s-ci-robot k8s-ci-robot merged commit d90c325 into kubernetes-csi:release-5.0 Aug 6, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants