If driver can't delete PVC when it still has snapshots, when deleting the PVC, maybe it can't delete the PVC in the etcd?

[zhucan]

Version:
external-snapshotter: v1.0.1
kubernetes: v1.13.0

Details:
If driver can't delete PVC when it still has snapshots, when I delete the PVC with snapshots，the PVC in the etcd has been delete，but in fact, delete the PVC failed.

Expectation：
If driver can't delete PVC when it still has snapshots， it can't delete the pvc in etcd.

[xing-yang]

Thanks @zhucan for reporting this issue! It was a design decision not to prevent PVC with snapshots from being deleted because some drivers do support that, but I think we should re-evaluate and figure out how to handle this better.

[xing-yang]

In this case, driver can return success but need to know that PVC already deleted in k8s. After all snapshots are deleted, driver should delete the volume itself.

We need to add documentation in Kubernetes-CSI and CSI for this.

[msau42]

In this case, shouldn't PV object still exist because DeleteVolume() will fail?

Can the presence of PVs in Released state indicate that something in the deletion is not working? PVC deletion is how we signal to the driver to start volume deletion.

[xing-yang]

We should add a test to make sure PVC can be deleted when there are still snapshots.

[xing-yang]

We discussed about this in the snapshot meeting. We want this to be handled consistently. So driver should return success and both PV and PVC will be deleted successfully. Driver needs to handle the cleanup of the volume resource on the storage system after all snapshots are deleted.

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[xing-yang]

/remove-lifecycle rotten
We still need to discuss and figure out a better way to handle this.

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[xing-yang]

/remove-lifecycle stale

[xing-yang]

This issue is discussed here as well: kubernetes-csi/external-provisioner#252

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[fejta-bot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

[k8s-ci-robot]

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[xing-yang]

/reopen

[k8s-ci-robot]

@xing-yang: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[fejta-bot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

[k8s-ci-robot]

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.