Skip to content
This repository has been archived by the owner on Mar 16, 2021. It is now read-only.

Image driver #133

Closed
wants to merge 5 commits into from
Closed

Conversation

kfox1111
Copy link

@kfox1111 kfox1111 commented Jan 3, 2019

This is a prototype for a csi driver that uses a raw docker image as a volume source.

This adds a container based volume driver. It takes in an image name
and mounts it as a volume.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 3, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kfox1111
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: chakri-nelluri

If they are not already assigned, you can assign the PR to them by writing /assign @chakri-nelluri in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pohly
Copy link
Contributor

pohly commented Jan 4, 2019

SIG-storage is trying to move each driver into its own repository, which will allow releasing them independently. I doubt that this driver (regardless of its merits) will be accepted here. Can't you just create your own repo and publish it from there?

@kfox1111
Copy link
Author

kfox1111 commented Jan 4, 2019

Yeah, that is issue #81. its been stalled for a very long time.

We need to get csi pod inline support into k8s for 1.14 and if we have some drivers in tree to test against, it would be better. last I talked to @vladimirvivien he mentioned just putting the pr against drivers for now until someone can actually finish up the splitting up of the drivers repo.

I'm a bit afraid sig-storage is holding up work because it wants to do everything perfect from the get go, rather then getting stuff contributed and then keep working on making it better. For API's, its really important to get them as right as possible from the start. For drivers themselves, its not so critical. Please, lets keep making progress on them.

@pohly
Copy link
Contributor

pohly commented Jan 4, 2019

@kfox1111 I was just describing the current situation. I don't have any strong opinions on this. I'll let @saad-ali decide where this driver should go.

@kfox1111
Copy link
Author

kfox1111 commented Jan 4, 2019

yeah. not mad or anything. just stating that we've been struggling to contribute for a long time and keep getting stalled out. Just trying to figure out ways to make progress.

@kfox1111
Copy link
Author

kfox1111 commented Jan 4, 2019

Oh, and this is also related to #85

@kfox1111
Copy link
Author

kfox1111 commented Feb 5, 2019

Its looking like the hostpath driver has finally been split out from drivers? Can we fork it for the image-driver? I'd be happy to rebase this top of that if someone can create it.

@saad-ali
Copy link
Contributor

Let's move this in to it's own repo under kubernetes-csi.

Open an issue here https://github.com/kubernetes/org/issues

@kfox1111
Copy link
Author

Closing in favour of kubernetes-retired/csi-driver-image-populator#1

@kfox1111 kfox1111 closed this Apr 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants