Skip to content

Commit

Permalink
fix naming mistake in clusterrolebinding, add env var to controller yaml
Browse files Browse the repository at this point in the history
  • Loading branch information
vdhanan committed May 11, 2021
1 parent bddf586 commit b706b5e
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -11,5 +11,5 @@ subjects:
namespace: {{ .Release.Namespace }}
roleRef:
kind: ClusterRole
name: ebs-external-attacher-role
name: ebs-csi-node-role

This comment has been minimized.

Copy link
@ArchiFleKs

ArchiFleKs May 20, 2021

This breaks update as roleref cannot be updated :/

This comment has been minimized.

Copy link
@vdhanan

vdhanan May 20, 2021

Author Contributor

yes, this was reported in #883 . i have a PR out to fix this issue: #894

apiGroup: rbac.authorization.k8s.io
4 changes: 4 additions & 0 deletions charts/aws-ebs-csi-driver/templates/controller.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,10 @@ spec:
env:
- name: CSI_ENDPOINT
value: unix:///var/lib/csi/sockets/pluginproxy/csi.sock
- name: CSI_NODE_NAME
valueFrom:
fieldRef:
fieldPath: spec.nodeName
- name: AWS_ACCESS_KEY_ID
valueFrom:
secretKeyRef:
Expand Down
2 changes: 1 addition & 1 deletion deploy/kubernetes/base/clusterrolebinding-csi-node.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,5 +12,5 @@ subjects:
namespace: default
roleRef:
kind: ClusterRole
name: ebs-external-attacher-role
name: ebs-csi-node-role
apiGroup: rbac.authorization.k8s.io
4 changes: 4 additions & 0 deletions deploy/kubernetes/base/controller.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,10 @@ spec:
env:
- name: CSI_ENDPOINT
value: unix:///var/lib/csi/sockets/pluginproxy/csi.sock
- name: CSI_NODE_NAME
valueFrom:
fieldRef:
fieldPath: spec.nodeName
- name: AWS_ACCESS_KEY_ID
valueFrom:
secretKeyRef:
Expand Down

0 comments on commit b706b5e

Please sign in to comment.