Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update golang.org/x/crypto for CVE-2022-27191 #1210

Merged
merged 1 commit into from
May 3, 2022

Conversation

jsafrane
Copy link
Contributor

golang.org/x/crypto/ssh server can crash in certain conditions. This CSI driver most probably does not run any ssh server, but update the package to a safe version to be 100% sure and prevent dumb dep scanning tools from raising an issue. Using today's golang.org master, they don't use tags.

Updated using these commands, they updated few additional libs:

go get -u golang.org/x/crypto
go mod tidy
go mod vendor

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 13, 2022
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Apr 13, 2022
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 22, 2022
@jsafrane
Copy link
Contributor Author

/assign @wongma7

@rdpsin
Copy link
Contributor

rdpsin commented Apr 22, 2022

/assign gtxu

@gtxu
Copy link
Contributor

gtxu commented Apr 22, 2022

Hi @jsafrane , thank you for the contribution. This PR need modify, we are awaiting it for merge.

@gtxu
Copy link
Contributor

gtxu commented Apr 22, 2022

/retest

golang.org/x/crypto/ssh server can crash in certain conditions. This CSI driver most probably does not run any ssh server, but update the package to a safe version to be 100% sure and prevent dumb dep scanning tools from raising an issue. Using today's golang.org master, they don't use tags.

Updated using these commands, they updated few additional libs:

go get -u golang.org/x/crypto
go mod tidy
go mod vendor
@gtxu
Copy link
Contributor

gtxu commented May 3, 2022

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 3, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gtxu, jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants