Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Post-release v1.10.0 #1325

Merged
merged 2 commits into from
Jul 27, 2022
Merged

Post-release v1.10.0 #1325

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f6c2b16
Post-release v1.10.0
torredil Jul 27, 2022
7746003
Run hack/update-gofm with go1.19rc2
torredil Jul 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
# v1.10.0
### Notable Changes
* Validate fs type before mounting ([#1319](https://github.com/kubernetes-sigs/aws-ebs-csi-driver/pull/1319), [@torredil](https://github.com/torredil))
## Announcement
* OS/Architecture specific tags are no longer being pushed to public ECR ([#1315](https://github.com/kubernetes-sigs/aws-ebs-csi-driver/issues/1315))

### Miscellaneous
* Validate `csi.storage.k8s.io/fstype` before mounting ([#1319](https://github.com/kubernetes-sigs/aws-ebs-csi-driver/pull/1319), [@torredil](https://github.com/torredil))
* Update install.md ([#1313](https://github.com/kubernetes-sigs/aws-ebs-csi-driver/pull/1313), [@torredil](https://github.com/torredil))

# v1.9.0
Expand Down
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ The [Amazon Elastic Block Store](https://aws.amazon.com/ebs/) Container Storage
| AWS EBS CSI Driver / Kubernetes Version| v1.12 | v1.13 | v1.14 | v1.15 | v1.16 | v1.17 | v1.18+|
|----------------------------------------|-------|-------|-------|-------|-------|-------|-------|
| master branch | no | no | no | no | no | yes | yes |
| v0.9.x-v1.6.x | no | no | no | no | no | yes | yes |
| v0.9.x-v1.10.x | no | no | no | no | no | yes | yes |
| v0.5.0-v0.8.x | no | no | yes | yes | yes | yes | yes |
| v0.4.0 | no | no | yes | yes | no | no | no |
| v0.3.0 | no | no | yes | no | no | no | no |
Expand All @@ -80,7 +80,7 @@ The [Amazon Elastic Block Store](https://aws.amazon.com/ebs/) Container Storage
| AWS EBS CSI Driver / CSI Version | v0.3.0| v1.0.0 | v1.1.0 |
|----------------------------------------|-------|--------|--------|
| master branch | no | no | yes |
| v0.4.0-v1.6.x | no | no | yes |
| v0.4.0-v1.10.x | no | no | yes |
| v0.2.0-v0.3.0 | no | yes | no |
| v0.1.0 | yes | no | no |

Expand Down
5 changes: 3 additions & 2 deletions charts/aws-ebs-csi-driver/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
# Helm chart

## v2.8.2
* Update controller and node templates to include envFrom property
## v2.9.0
* Bump app/driver to version `v1.10.0`
* Feature: Reference `configMaps` across multiple resources using `envFrom` ([#1312](https://github.com/kubernetes-sigs/aws-ebs-csi-driver/pull/1312), [@jebbens](https://github.com/jebbens))

## v2.8.1
* Bump app/driver to version `v1.9.0`
Expand Down
4 changes: 2 additions & 2 deletions charts/aws-ebs-csi-driver/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
apiVersion: v2
appVersion: 1.9.0
appVersion: 1.10.0
name: aws-ebs-csi-driver
description: A Helm chart for AWS EBS CSI Driver
version: 2.8.1
version: 2.9.0
kubeVersion: ">=1.17.0-0"
home: https://github.com/kubernetes-sigs/aws-ebs-csi-driver
sources:
Expand Down
2 changes: 1 addition & 1 deletion deploy/kubernetes/overlays/stable/gcr/kustomization.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ bases:
- ../../../base
images:
- name: k8s.gcr.io/provider-aws/aws-ebs-csi-driver
newTag: v1.9.0
newTag: v1.10.0
- name: k8s.gcr.io/sig-storage/csi-attacher
newTag: v3.4.0
- name: k8s.gcr.io/sig-storage/csi-node-driver-registrar
Expand Down
2 changes: 1 addition & 1 deletion docs/install.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ Please see the compatibility matrix before you deploy the driver

To deploy the CSI driver:
```sh
kubectl apply -k "github.com/kubernetes-sigs/aws-ebs-csi-driver/deploy/kubernetes/overlays/stable/?ref=release-1.9"
kubectl apply -k "github.com/kubernetes-sigs/aws-ebs-csi-driver/deploy/kubernetes/overlays/stable/?ref=release-1.10"
```

Verify driver is running:
Expand Down
3 changes: 2 additions & 1 deletion pkg/cloud/cloud.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,8 @@ const (

// AWS provisioning limits.
// Source:
// https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/Using_Tags.html#tag-restrictions
//
// https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/Using_Tags.html#tag-restrictions
const (
// MaxNumTagsPerResource represents the maximum number of tags per AWS resource.
MaxNumTagsPerResource = 50
Expand Down
4 changes: 3 additions & 1 deletion pkg/cloud/devicemanager/allocator.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,9 @@ var _ NameAllocator = &nameAllocator{}

// GetNext gets next available device given existing names that are being used
// This function iterate through the device names in deterministic order of:
// ba, ... ,bz, ca, ... , cz
//
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that lint plugin add these empty line? Or an intentional formatting?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NVM, saw that update-gofm, lgtm

// ba, ... ,bz, ca, ... , cz
//
// and return the first one that is not used yet.
func (d *nameAllocator) GetNext(existingNames ExistingNames) (string, error) {
for _, c1 := range []string{"b", "c"} {
Expand Down
18 changes: 9 additions & 9 deletions pkg/cloud/volume_limits.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import (
"strings"
)

/// https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/instance-types.html#ec2-nitro-instances
// / https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/instance-types.html#ec2-nitro-instances
const (
highMemoryMetalInstancesMaxVolumes = 19
highMemoryVirtualInstancesMaxVolumes = 27
Expand All @@ -14,14 +14,14 @@ const (
nitroMaxAttachments = 28
)

/// It is possible to have an instance family where the virtualized instances are Nitro
/// and metal instances are not
// / It is possible to have an instance family where the virtualized instances are Nitro
// / and metal instances are not
var nonNitroInstances = map[string]struct{}{
"c6i.metal": {},
"g5g.metal": {},
}

/// List of nitro instance types can be found here: https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/instance-types.html#ec2-nitro-instances
// / List of nitro instance types can be found here: https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/instance-types.html#ec2-nitro-instances
var nonNitroInstanceFamilies = map[string]struct{}{
"t2": {},
"c7g": {},
Expand Down Expand Up @@ -63,8 +63,8 @@ func GetMaxAttachments(nitro bool) int {
return nonNitroMaxAttachments
}

/// Some instance types have a maximum limit of EBS volumes
/// https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/instance-types.html#ec2-nitro-instances
// / Some instance types have a maximum limit of EBS volumes
// / https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/instance-types.html#ec2-nitro-instances
var maxVolumeLimits = map[string]int{
"d3.8xlarge": 3,
"d3.12xlarge": 3,
Expand Down Expand Up @@ -111,9 +111,9 @@ func GetNVMeInstanceStoreVolumesForInstanceType(it string) int {
return 0
}

/// https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/InstanceStorage.html#instance-store-volumes
/// IMDS does not provide NVMe instance store data; we'll just list all instances here
/// TODO: See if we can get these values from DescribeInstanceTypes API
// / https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/InstanceStorage.html#instance-store-volumes
// / IMDS does not provide NVMe instance store data; we'll just list all instances here
// / TODO: See if we can get these values from DescribeInstanceTypes API
var nvmeInstanceStoreVolumes = map[string]int{
"c5ad.large": 1,
"c5ad.xlarge": 1,
Expand Down
5 changes: 3 additions & 2 deletions pkg/mounter/safe_mounter_windows.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,8 +165,9 @@ func (mounter *CSIProxyMounter) IsMountPointMatch(mp mount.MountPoint, dir strin
}

// IsLikelyMountPoint - If the directory does not exists, the function will return os.ErrNotExist error.
// If the path exists, call to CSI proxy will check if its a link, if its a link then existence of target
// path is checked.
//
// If the path exists, call to CSI proxy will check if its a link, if its a link then existence of target
// path is checked.
func (mounter *CSIProxyMounter) IsLikelyNotMountPoint(path string) (bool, error) {
isExists, err := mounter.ExistsPath(path)
if err != nil {
Expand Down