Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Eddie Torres torredil@amazon.com
What is this PR about? / Why do we need it?
The
vendor
directory was removed in Remove/vendor
directory #1328 to address Remove/vendor
directory #1326. As a result of this change, we need to account for two scenarios:go get
will use a direct connection to the VCS (e.g github.com). This is causing our build to timeout, sincego mod download
takes nearly 30 minutes to complete. Addressed by this PR.Why do we need it?
GOPROXY
.GOPROXY
serves the source code over HTTP, thus not requiring the overhead when pulling from a VCS which fetches the whole repository.What testing is done?