Namespace-scoped leases permissions #1614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/M
|
/retest |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/lgtm |
|
/lgtm |
This commit modifies the driver's access to the 'leases' resource, restricting it to the namespace scope. The previously used ClusterRole and ClusterRoleBinding have been replaced by a Role and RoleBinding to ensure the driver's permissions are limited to its containing namespace, aligning with security best practices. Signed-off-by: Eddie Torres <torredil@amazon.com>
k8s-ci-robot
removed
the
lgtm
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: torredil The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the overly broad permissions previously granted to the
AWS EBS CSI driver for managing 'leases'. It replaces the
ClusterRoleandClusterRoleBinding, which provided cluster-wide access, with aRoleandRoleBinding, limiting access to the namespace in which the driver is deployed.What is this PR about? / Why do we need it?
The original configuration granted the driver access to leases across all
namespaces, which was unnecessary. By limiting access to the namespace in which the driver is deployed, we can enhance our security posture.
closes #1564
What testing is done?