Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup README and examples #232

Merged
merged 1 commit into from
Mar 6, 2019
Merged

Cleanup README and examples #232

merged 1 commit into from
Mar 6, 2019

Conversation

dkoshkin
Copy link
Contributor

@dkoshkin dkoshkin commented Mar 5, 2019

Is this a bug fix or adding new feature?
Doc enhancement.

What is this PR about? / Why do we need it?
Cleanup the README and examples/

What testing is done?
Manually ran through the 2 examples.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 5, 2019
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 5, 2019
@dkoshkin dkoshkin force-pushed the dkoshkin/readme-and-examples branch 2 times, most recently from 8072f78 to 7e691e5 Compare March 5, 2019 20:41
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 5, 2019
@coveralls
Copy link

coveralls commented Mar 5, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 503

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 67.773%
Totals Coverage Status
Change from base Build 490: 0.0%
Covered Lines: 980
Relevant Lines: 1446
💛 - Coveralls

leakingtapan
leakingtapan reviewed Mar 5, 2019
View reviewed changes
docs/README.md Outdated Show resolved Hide resolved
examples/kubernetes/dynamic-scheduling/README.md Outdated Show resolved Hide resolved
docs/README.md Outdated Show resolved Hide resolved
examples/kubernetes/snapshot/README.md Outdated Show resolved Hide resolved
hack/feature-gates.yaml Outdated Show resolved Hide resolved
@dkoshkin dkoshkin force-pushed the dkoshkin/readme-and-examples branch 2 times, most recently from f229712 to 220bd68 Compare March 6, 2019 01:22
@dkoshkin
Copy link
Contributor Author

dkoshkin commented Mar 6, 2019

/retest

@dkoshkin dkoshkin force-pushed the dkoshkin/readme-and-examples branch from 220bd68 to 0aee350 Compare March 6, 2019 01:52
@dkoshkin dkoshkin force-pushed the dkoshkin/readme-and-examples branch from 0aee350 to 2d5f5b1 Compare March 6, 2019 02:31
@leakingtapan
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 6, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dkoshkin, leakingtapan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 6, 2019
@k8s-ci-robot k8s-ci-robot merged commit 5ffb002 into kubernetes-sigs:master Mar 6, 2019
@dkoshkin dkoshkin deleted the dkoshkin/readme-and-examples branch March 6, 2019 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leakingtapan leakingtapan leakingtapan left review comments

@bertinatto bertinatto Awaiting requested review from bertinatto

@ddebroy ddebroy Awaiting requested review from ddebroy

Assignees

@leakingtapan leakingtapan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dkoshkin @coveralls @leakingtapan @k8s-ci-robot