Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update manifest for Kubernetes 1.15 #322

Merged
merged 2 commits into from
Jul 31, 2019
Merged

Update manifest for Kubernetes 1.15 #322

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a9a90b9
Remove cluster-driver-registrar
jsafrane Jul 25, 2019
de2dda9
Update the manifest to Kubernetes 1.15
jsafrane Jul 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
62 changes: 17 additions & 45 deletions deploy/kubernetes/manifest.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,43 +83,17 @@ roleRef:

---

kind: ClusterRole
apiVersion: rbac.authorization.k8s.io/v1
metadata:
name: ebs-cluster-driver-registrar-role
rules:
- apiGroups: ["apiextensions.k8s.io"]
resources: ["customresourcedefinitions"]
verbs: ["create", "list", "watch", "delete"]
- apiGroups: ["csi.storage.k8s.io"]
resources: ["csidrivers"]
verbs: ["create", "delete"]

---

kind: ClusterRoleBinding
apiVersion: rbac.authorization.k8s.io/v1
metadata:
name: ebs-csi-driver-registrar-binding
subjects:
- kind: ServiceAccount
name: ebs-csi-controller-sa
namespace: kube-system
roleRef:
kind: ClusterRole
name: ebs-cluster-driver-registrar-role
apiGroup: rbac.authorization.k8s.io

---

kind: StatefulSet
apiVersion: apps/v1beta1
apiVersion: apps/v1
metadata:
name: ebs-csi-controller
namespace: kube-system
spec:
serviceName: ebs-csi-controller
replicas: 1
selector:
matchLabels:
app: ebs-csi-controller
template:
metadata:
labels:
Expand Down Expand Up @@ -167,20 +141,8 @@ spec:
timeoutSeconds: 3
periodSeconds: 10
failureThreshold: 5
- name: cluster-driver-registrar
image: quay.io/k8scsi/csi-cluster-driver-registrar:v1.0.1
args:
- --csi-address=$(ADDRESS)
- --driver-requires-attachment=true
- --v=5
env:
- name: ADDRESS
value: /csi/csi.sock
volumeMounts:
- name: socket-dir
mountPath: /csi
- name: csi-provisioner
image: quay.io/k8scsi/csi-provisioner:v1.1.0
image: quay.io/k8scsi/csi-provisioner:v1.3.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change compatible with k8s 1.14? We are planing to do a 0.4 release with is supposed to be compatible with 1.14. So don't want to break the driver on 1.14

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kubernetes docs claim that 1.3.0 works with 1.14
https://kubernetes-csi.github.io/docs/external-provisioner.html

args:
- --provisioner=ebs.csi.aws.com
- --csi-address=$(ADDRESS)
Expand All @@ -193,7 +155,7 @@ spec:
- name: socket-dir
mountPath: /var/lib/csi/sockets/pluginproxy/
- name: csi-attacher
image: quay.io/k8scsi/csi-attacher:v1.1.0
image: quay.io/k8scsi/csi-attacher:v1.2.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above question

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://kubernetes-csi.github.io/docs/external-attacher.html

args:
- --csi-address=$(ADDRESS)
- --v=5
Expand All @@ -218,7 +180,7 @@ spec:
---
# Node Service
kind: DaemonSet
apiVersion: apps/v1beta2
apiVersion: apps/v1
metadata:
name: ebs-csi-node
namespace: kube-system
Expand Down Expand Up @@ -313,3 +275,13 @@ spec:
hostPath:
path: /dev
type: Directory

---

apiVersion: storage.k8s.io/v1beta1
kind: CSIDriver
metadata:
name: ebs.csi.aws.com
spec:
attachRequired: true
podInfoOnMount: false