Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update helm manifest for 1.15 #327

Merged
merged 1 commit into from
Aug 8, 2019

Conversation

wongma7
Copy link
Contributor

@wongma7 wongma7 commented Aug 6, 2019

Is this a bug fix or adding new feature?

What is this PR about? / Why do we need it? keep the helm manifest up to date with the deploy/kubernetes manifest updated in #322

What testing is done? ran helm install like
helm install --name aws-ebs-csi-driver
--set enableVolumeScheduling=true
--set enableVolumeResizing=true
--set enableVolumeSnapshot=true
--set image.repository=$IMAGE_NAME
--set image.tag=$IMAGE_TAG
./aws-ebs-csi-driver

and all containers go Running without issue.

@k8s-ci-robot
Copy link
Contributor

Welcome @wongma7!

It looks like this is your first PR to kubernetes-sigs/aws-ebs-csi-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-ebs-csi-driver has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 6, 2019
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 6, 2019
@coveralls
Copy link

Pull Request Test Coverage Report for Build 704

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 71.308%

Totals Coverage Status
Change from base Build 698: 0.0%
Covered Lines: 1178
Relevant Lines: 1652

💛 - Coveralls

@leakingtapan
Copy link
Contributor

Thanks for the change

@leakingtapan
Copy link
Contributor

The verify/sanity/unit failures are being fixed at: #325 e2e tests seems are having similar issue too.

@leakingtapan
Copy link
Contributor

/retest

2 similar comments
@leakingtapan
Copy link
Contributor

/retest

@leakingtapan
Copy link
Contributor

/retest

@leakingtapan
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 7, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leakingtapan, wongma7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 7, 2019
@leakingtapan
Copy link
Contributor

/retest

@k8s-ci-robot k8s-ci-robot merged commit 9ffd9dc into kubernetes-sigs:master Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants