Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spelling in README.md #414

Merged

Conversation

jnaulty
Copy link
Contributor

@jnaulty jnaulty commented Nov 22, 2019

Is this a bug fix or adding new feature?
Bug Fix

What is this PR about? / Why do we need it?
Fixes two spelling issues

What testing is done?
N/A

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 22, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @jnaulty. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 22, 2019
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 22, 2019
@jnaulty
Copy link
Contributor Author

jnaulty commented Nov 22, 2019

/assign @bertinatto

@coveralls
Copy link

Pull Request Test Coverage Report for Build 943

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 70.681%

Totals Coverage Status
Change from base Build 939: 0.0%
Covered Lines: 1215
Relevant Lines: 1719

💛 - Coveralls

@bertinatto
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 22, 2019
@bertinatto
Copy link
Member

/test pull-aws-ebs-csi-driver-e2e-single-az

@jnaulty
Copy link
Contributor Author

jnaulty commented Nov 22, 2019

Logs from latest pull-aws-ebs-csi-driver-e2e-single-az failure test failure link

STEP: Destroying namespace "ebs-9811" for this suite.
Nov 22 09:48:09.271: INFO: Waiting up to 30s for server preferred namespaced resources to be successfully discovered
Nov 22 09:48:11.331: INFO: namespace ebs-9811 deletion completed in 8.228708227s
• Failure [1527.259 seconds]
[ebs-csi-e2e] [single-az] Dynamic Provisioning
/home/prow/go/src/github.com/kubernetes-sigs/aws-ebs-csi-driver/tests/e2e/dynamic_provisioning.go:40
  should create a volume on demand with volume type "sc1" and fs type "ext2" [It]
  /home/prow/go/src/github.com/kubernetes-sigs/aws-ebs-csi-driver/tests/e2e/dynamic_provisioning.go:59
  Expected error:
      
      <*errors.errorString | 0xc0007fde80>: {
          s: "Gave up after waiting 15m0s for pod \"ebs-volume-tester-4zmgm\" to be \"success or failure\"",
      }
      Gave up after waiting 15m0s for pod "ebs-volume-tester-4zmgm" to be "success or failure"
  not to have occurred
  /home/prow/go/src/github.com/kubernetes-sigs/aws-ebs-csi-driver/tests/e2e/testsuites/testsuites.go:512
------------------------------
Summarizing 1 Failure:
[Fail] [ebs-csi-e2e] [single-az] Dynamic Provisioning [It] should create a volume on demand with volume type "sc1" and fs type "ext2" 
/home/prow/go/src/github.com/kubernetes-sigs/aws-ebs-csi-driver/tests/e2e/testsuites/testsuites.go:512

@bertinatto
Copy link
Member

/test pull-aws-ebs-csi-driver-e2e-single-az

@jnaulty
Copy link
Contributor Author

jnaulty commented Nov 22, 2019

@bertinatto
I created the issue #415 to track the flaky test.

Copy link
Member

@bertinatto bertinatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks for your PR, @jnaulty!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 22, 2019
@jnaulty
Copy link
Contributor Author

jnaulty commented Nov 22, 2019

Thanks for your PR, @jnaulty!

No Problem, @bertinatto. Are you able to mark this PR as approved, or is something needed on my end?

@leakingtapan
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jnaulty, leakingtapan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 22, 2019
@k8s-ci-robot k8s-ci-robot merged commit 3621851 into kubernetes-sigs:master Nov 22, 2019
@jnaulty jnaulty deleted the jnaulty/README-grammar-fix branch November 23, 2019 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants