Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nodeAffinity to avoid Fargate worker nodes #488

Merged
merged 2 commits into from
Apr 26, 2020

Conversation

bgsilvait
Copy link
Contributor

Is this a bug fix or adding new feature?
bug fix

What is this PR about? / Why do we need it?
Add nodeAffinity in the daemonset to avoid schedule ebs-csi-node pods on Fargate worker nodes, as Fargate does not support ebs.

If there is a pod running in Fargate, the daemoset tries to place ebs-csi-node pod in the same node, with causes the pod to Pending state.

What testing is done?
Apply the original with kubectl apply -k "github.com/kubernetes-sigs/aws-ebs-csi-driver/deploy/kubernetes/overlays/stable/?ref=master" -> pods Pending.

Adding the nodeAffinity, all pods in the Pending state on Fargate are deleted and new are only created at EC2 nodes

Add nodeAffinity in the daemonset to avoid schedule ebs-csi-node pods on Fargate worker nodes, as Fargate does not support ebs
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Apr 23, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @bgsilvait!

It looks like this is your first PR to kubernetes-sigs/aws-ebs-csi-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-ebs-csi-driver has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @bgsilvait. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 23, 2020
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 23, 2020
@coveralls
Copy link

coveralls commented Apr 23, 2020

Pull Request Test Coverage Report for Build 1082

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 78.871%

Totals Coverage Status
Change from base Build 1078: 0.0%
Covered Lines: 1411
Relevant Lines: 1789

💛 - Coveralls

@bgsilvait
Copy link
Contributor Author

/assign @wongma7

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Apr 23, 2020
@bgsilvait
Copy link
Contributor Author

I signed it

@wongma7
Copy link
Contributor

wongma7 commented Apr 23, 2020

/lgtm

This is the same way we avoid scheduling kube-proxy there

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 23, 2020
@wongma7
Copy link
Contributor

wongma7 commented Apr 23, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 23, 2020
@bgsilvait
Copy link
Contributor Author

bgsilvait commented Apr 23, 2020

@wongma7 I see these 2 e2e tests failed:

[ebs-csi-e2e] [single-az] Dynamic Provisioning should create a volume on demand with volume type "sc1" and fs type "ext2"

and

[ebs-csi-e2e] [single-az] Snapshot should create a pod, write and read to it, take a volume snapshot, and create another pod from the snapshot

I don't see how my PR with nodeAffinity can cause that errors. Yes is the same way used to avoid scheduling kube-proxy on Fargate

@wongma7
Copy link
Contributor

wongma7 commented Apr 23, 2020

/test pull-aws-ebs-csi-driver-e2e-single-az

@bgsilvait
Copy link
Contributor Author

/retest

@bgsilvait
Copy link
Contributor Author

/test pull-aws-ebs-csi-driver-e2e-single-az

Copy link
Contributor

@leakingtapan leakingtapan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the helm char as well here.

add nodeAffinity rule to avoid pods on AWS Fargate.
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 26, 2020
@bgsilvait
Copy link
Contributor Author

@leakingtapan Ok, helm chart fixed.

@leakingtapan
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 26, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bgsilvait, leakingtapan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@leakingtapan
Copy link
Contributor

/retest

@k8s-ci-robot k8s-ci-robot merged commit ce88e5f into kubernetes-sigs:master Apr 26, 2020
@bgsilvait bgsilvait deleted the patch-1 branch April 26, 2020 19:32
@bgsilvait bgsilvait restored the patch-1 branch April 26, 2020 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants