Update hack/run-e2e-test to be more idempotent and pleasant to use #616

wongma7 · 2020-11-20T23:18:07Z

Is this a bug fix or adding new feature?

What is this PR about? / Why do we need it? Used this PR to debug migration, it is still broken pending kubernetes/kubernetes#96821 but there are various fixes I made to the script along the way .

What testing is done?

TEST_ID=18512 CLEAN=false KOPS_STATE_FILE=s3://aws-ebs-csi-driver-e2e AWS_REGION=us-west-2 AWS_AVAILABILITY_ZONES=us-west-2a GINKGO_FOCUS=Dynamic.*xfs.*should.store.data GINKGO_NODES=1 ./hack/run-e2e-test

wongma7 · 2020-11-20T23:18:27Z

/test migration-test-latest

not sure if this works

k8s-ci-robot · 2020-11-20T23:18:29Z

@wongma7: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

/test pull-aws-ebs-csi-driver-verify
/test pull-aws-ebs-csi-driver-unit
/test pull-aws-ebs-csi-driver-e2e-single-az
/test pull-aws-ebs-csi-driver-e2e-multi-az
/test pull-aws-ebs-csi-driver-migration-test-latest

Use /test all to run the following jobs:

pull-aws-ebs-csi-driver-verify
pull-aws-ebs-csi-driver-unit
pull-aws-ebs-csi-driver-e2e-single-az
pull-aws-ebs-csi-driver-e2e-multi-az

In response to this:

/test migration-test-latest

not sure if this works

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

wongma7 · 2020-11-20T23:18:36Z

/test pull-aws-ebs-csi-driver-migration-test-latest

wongma7 · 2020-11-21T00:15:35Z

/test pull-aws-ebs-csi-driver-migration-test-latest

wongma7 · 2020-11-21T00:36:57Z

STEP: Collecting events from namespace "volume-9070".
STEP: Found 6 events.
Nov 21 00:35:24.591: INFO: At 2020-11-21 00:30:15 +0000 UTC - event for exec-volume-test-aws-f9vm: {default-scheduler } Scheduled: Successfully assigned volume-9070/exec-volume-test-aws-f9vm to ip-172-20-57-44.us-west-2.compute.internal
Nov 21 00:35:24.591: INFO: At 2020-11-21 00:30:21 +0000 UTC - event for exec-volume-test-aws-f9vm: {attachdetach-controller } SuccessfulAttachVolume: AttachVolume.Attach succeeded for volume "ebs.csi.aws.com-aws://us-west-2a/vol-06e0182b17e4a1450" 
Nov 21 00:35:24.591: INFO: At 2020-11-21 00:30:23 +0000 UTC - event for exec-volume-test-aws-f9vm: {kubelet ip-172-20-57-44.us-west-2.compute.internal} Pulling: Pulling image "docker.io/library/nginx:1.14-alpine"
Nov 21 00:35:24.591: INFO: At 2020-11-21 00:30:26 +0000 UTC - event for exec-volume-test-aws-f9vm: {kubelet ip-172-20-57-44.us-west-2.compute.internal} Pulled: Successfully pulled image "docker.io/library/nginx:1.14-alpine"
Nov 21 00:35:24.591: INFO: At 2020-11-21 00:30:26 +0000 UTC - event for exec-volume-test-aws-f9vm: {kubelet ip-172-20-57-44.us-west-2.compute.internal} Failed: Error: Error response from daemon: invalid mode: /vol1
Nov 21 00:35:24.591: INFO: At 2020-11-21 00:30:27 +0000 UTC - event for exec-volume-test-aws-f9vm: {kubelet ip-172-20-57-44.us-west-2.compute.internal} Pulled: Container image "docker.io/library/nginx:1.14-alpine" already present on machine

coveralls · 2020-11-21T02:59:27Z

Pull Request Test Coverage Report for Build 1314

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 81.253%

Totals
Change from base Build 1304:	0.0%
Covered Lines:	1595
Relevant Lines:	1963

💛 - Coveralls

wongma7 · 2020-11-23T20:13:09Z

invalid mode:

k get po aws-injector -n volume-365 -o yaml
apiVersion: v1
kind: Pod
metadata:
  creationTimestamp: "2020-11-23T20:09:59Z"
  labels:
    role: aws-injector
  managedFields:
  - apiVersion: v1
    fieldsType: FieldsV1
    fieldsV1:
      f:metadata:
        f:labels:
          .: {}
          f:role: {}
      f:spec:
        f:containers:
          k:{"name":"aws-injector"}:
            .: {}
            f:command: {}
            f:image: {}
            f:imagePullPolicy: {}
            f:name: {}
            f:resources: {}
            f:securityContext:
              .: {}
              f:privileged: {}
            f:terminationMessagePath: {}
            f:terminationMessagePolicy: {}
            f:volumeMounts:
              .: {}
              k:{"mountPath":"/opt/0"}:
                .: {}
                f:mountPath: {}
                f:name: {}
            f:workingDir: {}
        f:dnsPolicy: {}
        f:enableServiceLinks: {}
        f:nodeSelector:
          .: {}
          f:failure-domain.beta.kubernetes.io/zone: {}
        f:restartPolicy: {}
        f:schedulerName: {}
        f:securityContext:
          .: {}
          f:seLinuxOptions:
            .: {}
            f:level: {}
        f:terminationGracePeriodSeconds: {}
        f:volumes:
          .: {}
          k:{"name":"aws-volume-0"}:
            .: {}
            f:awsElasticBlockStore:
              .: {}
              f:fsType: {}
              f:volumeID: {}
            f:name: {}
    manager: e2e-migration.test
    operation: Update
    time: "2020-11-23T20:09:59Z"
  - apiVersion: v1
    fieldsType: FieldsV1
    fieldsV1:
      f:status:
        f:conditions:
          k:{"type":"ContainersReady"}:
            .: {}
            f:lastProbeTime: {}
            f:lastTransitionTime: {}
            f:message: {}
            f:reason: {}
            f:status: {}
            f:type: {}
          k:{"type":"Initialized"}:
            .: {}
            f:lastProbeTime: {}
            f:lastTransitionTime: {}
            f:status: {}
            f:type: {}
          k:{"type":"Ready"}:
            .: {}
            f:lastProbeTime: {}
            f:lastTransitionTime: {}
            f:message: {}
            f:reason: {}
            f:status: {}
            f:type: {}
        f:containerStatuses: {}
        f:hostIP: {}
        f:podIP: {}
        f:podIPs:
          .: {}
          k:{"ip":"100.96.2.98"}:
            .: {}
            f:ip: {}
        f:startTime: {}
    manager: kubelet
    operation: Update
    time: "2020-11-23T20:10:32Z"
  name: aws-injector
  namespace: volume-365
  resourceVersion: "902200"
  selfLink: /api/v1/namespaces/volume-365/pods/aws-injector
  uid: e89a8ac7-7ab1-4f6c-b7e8-7248d821a286
spec:
  containers:
  - command:
    - /bin/sh
    - -c
    - 'while true ; do sleep 2; done '
    image: docker.io/library/busybox:1.29
    imagePullPolicy: IfNotPresent
    name: aws-injector
    resources: {}
    securityContext:
      privileged: true
    terminationMessagePath: /dev/termination-log
    terminationMessagePolicy: File
    volumeMounts:
    - mountPath: /opt/0
      name: aws-volume-0
    - mountPath: /var/run/secrets/kubernetes.io/serviceaccount
      name: default-token-lnzzq
      readOnly: true
    workingDir: /opt
  dnsPolicy: ClusterFirst
  enableServiceLinks: true
  nodeName: ip-172-20-49-41.us-west-2.compute.internal
  nodeSelector:
    failure-domain.beta.kubernetes.io/zone: us-west-2a
  priority: 0
  restartPolicy: Always
  schedulerName: default-scheduler
  securityContext:
    seLinuxOptions:
      level: s0:c0,c1
  serviceAccount: default
  serviceAccountName: default
  terminationGracePeriodSeconds: 1
  tolerations:
  - effect: NoExecute
    key: node.kubernetes.io/not-ready
    operator: Exists
    tolerationSeconds: 300
  - effect: NoExecute
    key: node.kubernetes.io/unreachable
    operator: Exists
    tolerationSeconds: 300
  volumes:
  - awsElasticBlockStore:
      fsType: ext4
      volumeID: aws://us-west-2a/vol-0818b380d4fc22bec
    name: aws-volume-0
  - name: default-token-lnzzq
    secret:
      defaultMode: 420
      secretName: default-token-lnzzq
status:
  conditions:
  - lastProbeTime: null
    lastTransitionTime: "2020-11-23T20:09:59Z"
    status: "True"
    type: Initialized
  - lastProbeTime: null
    lastTransitionTime: "2020-11-23T20:09:59Z"
    message: 'containers with unready status: [aws-injector]'
    reason: ContainersNotReady
    status: "False"
    type: Ready
  - lastProbeTime: null
    lastTransitionTime: "2020-11-23T20:09:59Z"
    message: 'containers with unready status: [aws-injector]'
    reason: ContainersNotReady
    status: "False"
    type: ContainersReady
  - lastProbeTime: null
    lastTransitionTime: "2020-11-23T20:09:59Z"
    status: "True"
    type: PodScheduled
  containerStatuses:
  - image: docker.io/library/busybox:1.29
    imageID: ""
    lastState: {}
    name: aws-injector
    ready: false
    restartCount: 0
    started: false
    state:
      waiting:
        message: 'Error response from daemon: invalid mode: /opt/0'
        reason: CreateContainerError
  hostIP: 172.20.49.41
  phase: Pending
  podIP: 100.96.2.98
  podIPs:
  - ip: 100.96.2.98
  qosClass: BestEffort
  startTime: "2020-11-23T20:09:59Z"

wongma7 · 2020-11-23T20:57:46Z

/test pull-aws-ebs-csi-driver-migration-test-latest

wongma7 · 2020-11-23T21:15:10Z

I1123 21:01:36.246438       1 node.go:160] NodeStageVolume: find device path /dev/xvdba -> /dev/xvdba
I1123 21:01:36.246748       1 node.go:195] NodeStageVolume: formatting /dev/xvdba and mounting at /var/lib/kubelet/plugins/kubernetes.io/csi/pv/ebs.csi.aws.com-aws:/us-west-2a/vol-0a4910df43136ea3e/globalmount with fstype ext3
I1123 21:01:36.246764       1 mount_linux.go:274] Checking for issues with fsck on disk: /dev/xvdba
I1123 21:01:36.275235       1 mount_linux.go:287] `fsck` error fsck from util-linux 2.33.1
fsck.ext2: Bad magic number in super-block while trying to open /dev/xvdba
/dev/xvdba: 
The superblock could not be read or does not describe a valid ext2/ext3/ext4
filesystem.  If the device is valid and it really contains an ext2/ext3/ext4
filesystem (and not swap or ufs or something else), then the superblock
is corrupt, and you might try running e2fsck with an alternate superblock:
    e2fsck -b 8193 <device>
 or
    e2fsck -b 32768 <device>

I1123 21:01:36.275253       1 mount_linux.go:293] Attempting to mount disk: ext3 /dev/xvdba /var/lib/kubelet/plugins/kubernetes.io/csi/pv/ebs.csi.aws.com-aws:/us-west-2a/vol-0a4910df43136ea3e/globalmount
I1123 21:01:36.275270       1 mount_linux.go:135] Mounting cmd (mount) with arguments ([-t ext3 -o defaults /dev/xvdba /var/lib/kubelet/plugins/kubernetes.io/csi/pv/ebs.csi.aws.com-aws:/us-west-2a/vol-0a4910df43136ea3e/globalmount])
E1123 21:01:36.281272       1 mount_linux.go:140] Mount failed: exit status 32
Mounting command: mount
Mounting arguments: -t ext3 -o defaults /dev/xvdba /var/lib/kubelet/plugins/kubernetes.io/csi/pv/ebs.csi.aws.com-aws:/us-west-2a/vol-0a4910df43136ea3e/globalmount
Output: mount: /var/lib/kubelet/plugins/kubernetes.io/csi/pv/ebs.csi.aws.com-aws:/us-west-2a/vol-0a4910df43136ea3e/globalmount: wrong fs type, bad option, bad superblock on /dev/xvdba, missing codepage or helper program, or other error.

I1123 21:01:36.281302       1 mount_linux.go:346] Attempting to determine if disk "/dev/xvdba" is formatted using blkid with args: ([-p -s TYPE -s PTTYPE -o export /dev/xvdba])
I1123 21:01:36.294810       1 mount_linux.go:349] Output: "", err: exit status 2
I1123 21:01:36.294833       1 mount_linux.go:322] Disk "/dev/xvdba" appears to be unformatted, attempting to format as type: "ext3" with options: [-F -m0 /dev/xvdba]
I1123 21:01:39.306421       1 mount_linux.go:326] Disk successfully formatted (mkfs): ext3 - /dev/xvdba /var/lib/kubelet/plugins/kubernetes.io/csi/pv/ebs.csi.aws.com-aws:/us-west-2a/vol-0a4910df43136ea3e/globalmount
I1123 21:01:39.306453       1 mount_linux.go:135] Mounting cmd (mount) with arguments ([-t ext3 -o defaults /dev/xvdba /var/lib/kubelet/plugins/kubernetes.io/csi/pv/ebs.csi.aws.com-aws:/us-west-2a/vol-0a4910df43136ea3e/globalmount])
I1123 21:01:39.321963       1 node.go:145] NodeStageVolume: volume="vol-0a4910df43136ea3e" operation finished
I1123 21:01:39.322044       1 node.go:147] donedone
I1123 21:01:39.324508       1 node.go:351] NodeGetCapabilities: called with args {XXX_NoUnkeyedLiteral:{} XXX_unrecognized:[] XXX_sizecache:0}
I1123 21:01:39.328592       1 node.go:281] NodePublishVolume: called with args {VolumeId:vol-0a4910df43136ea3e PublishContext:map[devicePath:/dev/xvdba] StagingTargetPath:/var/lib/kubelet/plugins/kubernetes.io/csi/pv/ebs.csi.aws.com-aws:/us-west-2a/vol-0a4910df43136ea3e/globalmount TargetPath:/var/lib/kubelet/pods/017390c5-0c21-404b-a850-228c4311dd36/volumes/kubernetes.io~csi/ebs.csi.aws.com-aws:~~us-west-2a~vol-0a4910df43136ea3e/mount VolumeCapability:mount:<fs_type:"ext3" > access_mode:<mode:SINGLE_NODE_WRITER >  Readonly:false Secrets:map[] VolumeContext:map[partition:0] XXX_NoUnkeyedLiteral:{} XXX_unrecognized:[] XXX_sizecache:0}
I1123 21:01:39.328639       1 node.go:454] NodePublishVolume: creating dir /var/lib/kubelet/pods/017390c5-0c21-404b-a850-228c4311dd36/volumes/kubernetes.io~csi/ebs.csi.aws.com-aws:~~us-west-2a~vol-0a4910df43136ea3e/mount
I1123 21:01:39.328669       1 node.go:464] NodePublishVolume: mounting /var/lib/kubelet/plugins/kubernetes.io/csi/pv/ebs.csi.aws.com-aws:/us-west-2a/vol-0a4910df43136ea3e/globalmount at /var/lib/kubelet/pods/017390c5-0c21-404b-a850-228c4311dd36/volumes/kubernetes.io~csi/ebs.csi.aws.com-aws:~~us-west-2a~vol-0a4910df43136ea3e/mount with option [bind] as fstype ext3
I1123 21:01:39.328685       1 mount_linux.go:135] Mounting cmd (mount) with arguments ([-t ext3 -o bind /var/lib/kubelet/plugins/kubernetes.io/csi/pv/ebs.csi.aws.com-aws:/us-west-2a/vol-0a4910df43136ea3e/globalmount /var/lib/kubelet/pods/017390c5-0c21-404b-a850-228c4311dd36/volumes/kubernetes.io~csi/ebs.csi.aws.com-aws:~~us-west-2a~vol-0a4910df43136ea3e/mount])
I1123 21:01:39.333332       1 mount_linux.go:135] Mounting cmd (mount) with arguments ([-t ext3 -o bind,remount /var/lib/kubelet/plugins/kubernetes.io/csi/pv/ebs.csi.aws.com-aws:/us-west-2a/vol-0a4910df43136ea3e/globalmount /var/lib/kubelet/pods/017390c5-0c21-404b-a850-228c4311dd36/volumes/kubernetes.io~csi/ebs.csi.aws.com-aws:~~us-west-2a~vol-0a4910df43136ea3e/mount])```

wongma7 · 2020-11-23T21:17:44Z

Nov 23 21:01:36 ip-172-20-49-41 kubelet[5351]: I1123 21:01:36.141788 5351 operation_generator.go:1332] Controller attach succeeded for volume "ebs.csi.aws.com-aws://us-west-2a/vol-0a4910df43136ea3e" (UniqueName: "kubernetes.io/csi/ebs.csi.aws.com^vol-0a4910df43136ea3e") pod "exec-volume-test-aws-8r7l" (UID: "017390c5-0c21-404b-a850-228c4311dd36") device path: ""
Nov 23 21:01:36 ip-172-20-49-41 kubelet[5351]: I1123 21:01:36.239623 5351 reconciler.go:269] operationExecutor.MountVolume started for volume "ebs.csi.aws.com-aws://us-west-2a/vol-0a4910df43136ea3e" (UniqueName: "kubernetes.io/csi/ebs.csi.aws.com^vol-0a4910df43136ea3e") pod "exec-volume-test-aws-8r7l" (UID: "017390c5-0c21-404b-a850-228c4311dd36")
Nov 23 21:01:36 ip-172-20-49-41 kubelet[5351]: I1123 21:01:36.239908 5351 operation_generator.go:558] MountVolume.WaitForAttach entering for volume "ebs.csi.aws.com-aws://us-west-2a/vol-0a4910df43136ea3e" (UniqueName: "kubernetes.io/csi/ebs.csi.aws.com^vol-0a4910df43136ea3e") pod "exec-volume-test-aws-8r7l" (UID: "017390c5-0c21-404b-a850-228c4311dd36") DevicePath ""
Nov 23 21:01:36 ip-172-20-49-41 kubelet[5351]: I1123 21:01:36.242091 5351 operation_generator.go:567] MountVolume.WaitForAttach succeeded for volume "ebs.csi.aws.com-aws://us-west-2a/vol-0a4910df43136ea3e" (UniqueName: "kubernetes.io/csi/ebs.csi.aws.com^vol-0a4910df43136ea3e") pod "exec-volume-test-aws-8r7l" (UID: "017390c5-0c21-404b-a850-228c4311dd36") DevicePath "csi-3f99ef764cc033bc9304e6f1d65fa3516bb721b2edbccf21247696f38e282680"
Nov 23 21:01:39 ip-172-20-49-41 kubelet[5351]: I1123 21:01:39.322585 5351 operation_generator.go:596] MountVolume.MountDevice succeeded for volume "ebs.csi.aws.com-aws://us-west-2a/vol-0a4910df43136ea3e" (UniqueName: "kubernetes.io/csi/ebs.csi.aws.com^vol-0a4910df43136ea3e") pod "exec-volume-test-aws-8r7l" (UID: "017390c5-0c21-404b-a850-228c4311dd36") device mount path "/var/lib/kubelet/plugins/kubernetes.io/csi/pv/ebs.csi.aws.com-aws:/us-west-2a/vol-0a4910df43136ea3e/globalmount"
Nov 23 21:01:39 ip-172-20-49-41 kubelet[5351]: I1123 21:01:39.335780 5351 operation_generator.go:657] MountVolume.SetUp succeeded for volume "ebs.csi.aws.com-aws://us-west-2a/vol-0a4910df43136ea3e" (UniqueName: "kubernetes.io/csi/ebs.csi.aws.com^vol-0a4910df43136ea3e") pod "exec-volume-test-aws-8r7l" (UID: "017390c5-0c21-404b-a850-228c4311dd36")

wongma7 · 2020-11-23T21:24:41Z

inline path looks wonky.

/var/lib/kubelet/pods/017390c5-0c21-404b-a850-228c4311dd36/volumes/kubernetes.io~csi/ebs.csi.aws.com-aws:~~us-west-2a~vol-0a4910df43136ea3e/mount

VS

/var/lib/kubelet/pods/25ece527-2b12-42b5-b8ac-63bf55307b33/volumes/kubernetes.io~csi/pvc-bcfdb60c-ed8b-4ed2-b9e6-c7433c2e8ba9/mount/

Nov 23 21:34:59 ip-172-20-49-41 kubelet[952074]: I1123 21:34:59.474275 952074 csi_mounter.go:87] kubernetes.io/csi: mounter.GetPath generated [/var/lib/kubelet/pods/017390c5-0c21-404b-a850-228c4311dd36/volumes/kubernetes.io~csi/ebs.csi.aws.com-aws:~~us-west-2a~vol-0a4910df43136ea3e/mount]

wongma7 · 2020-11-23T22:10:29Z

I think the colon is messing with docker.

wongma7 · 2020-11-23T22:26:59Z

I am pretty sure it is the colon, I will do more testing and see if a patch in kubelet fixes it. In-tree is not affected because instead of putting spec.volumeHandle/volumeID they use spec.volumeName which I think will never have a colon in it

https://github.com/kubernetes/kubernetes/blob/6d5cb36d36f34cb4f5735b6adcd5ea8ebb4440ba/pkg/volume/awsebs/aws_ebs.go#L172

https://github.com/kubernetes/kubernetes/blob/6d5cb36d36f34cb4f5735b6adcd5ea8ebb4440ba/pkg/volume/awsebs/aws_ebs.go#L63

https://github.com/kubernetes/kubernetes/blob/6d5cb36d36f34cb4f5735b6adcd5ea8ebb4440ba/pkg/volume/csi/csi_mounter.go#L93

https://github.com/kubernetes/kubernetes/blob/cea1d4e20b4a7886d8ff65f34c6d4f95efcb4742/pkg/kubelet/dockershim/helpers.go#L120

https://github.com/moby/moby/blob/46cdcd206c56172b95ba5c77b827a722dab426c5/volume/mounts/parser_test.go#L283

wongma7 · 2020-11-23T22:27:57Z

translation should prevent this

https://github.com/kubernetes/kubernetes/blob/cea1d4e20b4a7886d8ff65f34c6d4f95efcb4742/staging/src/k8s.io/csi-translation-lib/plugins/aws_ebs.go#L213

~~edit: but I dont think GetPath goes through translation https://github.com/kubernetes/kubernetes/blob/6d5cb36d36f34cb4f5735b6adcd5ea8ebb4440ba/pkg/volume/csi/csi_mounter.go#L87~~

wongma7 · 2020-11-23T22:30:33Z

csi should be using spec.name too hmmm https://github.com/kubernetes/kubernetes/blob/6d5cb36d36f34cb4f5735b6adcd5ea8ebb4440ba/pkg/volume/csi/csi_plugin.go#L430

wongma7 · 2020-11-23T22:45:44Z

OK, volumeID is not translated and used as the PV name which is then used as mounter's spec.Name, that is how colon slips through. will fix in translation lib.

https://github.com/kubernetes/kubernetes/blob/cea1d4e20b4a7886d8ff65f34c6d4f95efcb4742/staging/src/k8s.io/csi-translation-lib/plugins/aws_ebs.go#L101

k8s-ci-robot · 2020-12-02T20:38:45Z

@wongma7: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
pull-aws-ebs-csi-driver-migration-test-latest	`81546db`	link	`/test pull-aws-ebs-csi-driver-migration-test-latest`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

ayberk · 2020-12-02T21:45:41Z

hack/utils/kops.sh

+    KOPS_DOWNLOAD_URL=https://github.com/kubernetes/kops/releases/download/v${KOPS_VERSION}/kops-${OS_ARCH}
+    curl -L -X GET "${KOPS_DOWNLOAD_URL}" -o "${INSTALL_PATH}"/kops
+    chmod +x "${INSTALL_PATH}"/kops
+  fi


Not critical, but it would be helpful to log something in the else such as kops is already installed, not reinstalling.

the curl is not silent, so in a roundabout way it is still possible to tell if the install is being skipped. But yeah, the more logging the better.

ayberk · 2020-12-02T21:46:44Z

hack/run-e2e-test

+
+KUBECONFIG=${KUBECONFIG:-"${HOME}/.kube/config"}
+ARTIFACTS=${ARTIFACTS:-"${TEST_DIR}/artifacts"}
+GINKGO_FOCUS=${GINKGO_FOCUS:-"\[ebs-csi-migration\]"}


Just to verify, we're changing from ebs-csi-e2e to ebs-csi-migration?

yeah, just for the default. The non-migration tests currently go through the tester binary instead of this script anyway. (the theory behind the tester binary is that we can update it once to update all 3 aws csi drivers, so we don't need to maintain 3 almost-identical kops "run-e2e-test" scripts in all 3 repos, but in practice we need to do that anyway since the binary configuratoin yaml is effectively a script: https://github.com/kubernetes-sigs/aws-ebs-csi-driver/blob/master/tester/single-az-config.yaml)

ayberk · 2020-12-02T21:48:38Z

/lgtm

k8s-ci-robot · 2020-12-02T21:48:39Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ayberk, wongma7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [wongma7]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot · 2020-12-02T21:48:46Z

@ayberk: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

wongma7 · 2020-12-02T21:55:00Z

/retest

cluster create failed ...but it is not using this script so it's not related

nckturner · 2020-12-02T23:16:01Z

/lgtm

k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 20, 2020

k8s-ci-robot requested review from d-nishi and leakingtapan November 20, 2020 23:18

k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 20, 2020

wongma7 force-pushed the debugmigration branch 2 times, most recently from 8595420 to 6b396cf Compare November 21, 2020 00:15

wongma7 force-pushed the debugmigration branch from 6b396cf to 81546db Compare November 23, 2020 19:13

Update hack/run-e2e-test to be more idempotent and pleasant to use

cc0305f

wongma7 force-pushed the debugmigration branch from 81546db to cc0305f Compare December 2, 2020 20:14

wongma7 changed the title ~~WIP debug migration~~ Update hack/run-e2e-test to be more idempotent and pleasant to use Dec 2, 2020

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 2, 2020

ayberk reviewed Dec 2, 2020

View reviewed changes

ayberk approved these changes Dec 2, 2020

View reviewed changes

k8s-ci-robot assigned nckturner Dec 2, 2020

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 2, 2020

k8s-ci-robot merged commit 9ba3b8d into kubernetes-sigs:master Dec 2, 2020

wongma7 mentioned this pull request Dec 4, 2020

Remove more skip patterns #410

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update hack/run-e2e-test to be more idempotent and pleasant to use #616

Update hack/run-e2e-test to be more idempotent and pleasant to use #616

wongma7 commented Nov 20, 2020 •

edited

Loading

wongma7 commented Nov 20, 2020

k8s-ci-robot commented Nov 20, 2020

wongma7 commented Nov 20, 2020

wongma7 commented Nov 21, 2020

wongma7 commented Nov 21, 2020

coveralls commented Nov 21, 2020 •

edited

Loading

wongma7 commented Nov 23, 2020

wongma7 commented Nov 23, 2020

wongma7 commented Nov 23, 2020 •

edited

Loading

wongma7 commented Nov 23, 2020

wongma7 commented Nov 23, 2020 •

edited

Loading

wongma7 commented Nov 23, 2020

wongma7 commented Nov 23, 2020

wongma7 commented Nov 23, 2020 •

edited

Loading

wongma7 commented Nov 23, 2020

wongma7 commented Nov 23, 2020

k8s-ci-robot commented Dec 2, 2020 •

edited

Loading

ayberk Dec 2, 2020 •

edited

Loading

wongma7 Dec 2, 2020

ayberk Dec 2, 2020

wongma7 Dec 2, 2020

ayberk commented Dec 2, 2020

k8s-ci-robot commented Dec 2, 2020

k8s-ci-robot commented Dec 2, 2020

wongma7 commented Dec 2, 2020

nckturner commented Dec 2, 2020

Update hack/run-e2e-test to be more idempotent and pleasant to use #616

Update hack/run-e2e-test to be more idempotent and pleasant to use #616

Conversation

wongma7 commented Nov 20, 2020 • edited Loading

wongma7 commented Nov 20, 2020

k8s-ci-robot commented Nov 20, 2020

wongma7 commented Nov 20, 2020

wongma7 commented Nov 21, 2020

wongma7 commented Nov 21, 2020

coveralls commented Nov 21, 2020 • edited Loading

Pull Request Test Coverage Report for Build 1314

💛 - Coveralls

wongma7 commented Nov 23, 2020

wongma7 commented Nov 23, 2020

wongma7 commented Nov 23, 2020 • edited Loading

wongma7 commented Nov 23, 2020

wongma7 commented Nov 23, 2020 • edited Loading

wongma7 commented Nov 23, 2020

wongma7 commented Nov 23, 2020

wongma7 commented Nov 23, 2020 • edited Loading

wongma7 commented Nov 23, 2020

wongma7 commented Nov 23, 2020

k8s-ci-robot commented Dec 2, 2020 • edited Loading

ayberk Dec 2, 2020 • edited Loading

Choose a reason for hiding this comment

wongma7 Dec 2, 2020

Choose a reason for hiding this comment

ayberk Dec 2, 2020

Choose a reason for hiding this comment

wongma7 Dec 2, 2020

Choose a reason for hiding this comment

ayberk commented Dec 2, 2020

k8s-ci-robot commented Dec 2, 2020

k8s-ci-robot commented Dec 2, 2020

wongma7 commented Dec 2, 2020

nckturner commented Dec 2, 2020

wongma7 commented Nov 20, 2020 •

edited

Loading

coveralls commented Nov 21, 2020 •

edited

Loading

wongma7 commented Nov 23, 2020 •

edited

Loading

wongma7 commented Nov 23, 2020 •

edited

Loading

wongma7 commented Nov 23, 2020 •

edited

Loading

k8s-ci-robot commented Dec 2, 2020 •

edited

Loading

ayberk Dec 2, 2020 •

edited

Loading