hack/e2e: Support passing helm values as values.yaml and make other similar files optional #787
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wongma7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
Pull Request Test Coverage Report for Build 1710
💛 - Coveralls |
| git read-tree --prefix=hack/e2e/ -u ebs/master:hack/e2e | ||
| ``` | ||
|
|
||
| To commit changes and submit them as a PR back to the ebs repo: |
There was a problem hiding this comment.
Can you elaborate on this? Why are we doing this instead of a regular PR?
There was a problem hiding this comment.
if you've read-treed this director ythen youa re in another repo (efs). so if you want to commit your changes back to theoriginal repo (ebs) you need to do this. does it make sense, not sure what to add here
There was a problem hiding this comment.
Yeah got it. That's what I kind of guessed but wanted to make sure. lgtm.
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Is this a bug fix or adding new feature? fix
What is this PR about? / Why do we need it? Minor changes to make the scripts more configurable and usable by EFS driver. kubernetes-sigs/aws-efs-csi-driver#354
It seems like git read tree is the simplest way to consume these scripts from EFS. subtree is more complicated because hack/e2e is a subdirectory of this repo and not its own repo
What testing is done? CI of PR kubernetes-sigs/aws-efs-csi-driver#354 and CI of this PR.