Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update driver capabilities #922

Merged
merged 2 commits into from
Jun 9, 2021
Merged

Update driver capabilities #922

merged 2 commits into from
Jun 9, 2021

Conversation

wongma7
Copy link
Contributor

@wongma7 wongma7 commented Jun 4, 2021

Is this a bug fix or adding new feature?

What is this PR about? / Why do we need it? to opt-in to (future) e2e tests from kubernetes/kubernetes, capabilities shoudl be accurate.

What testing is done?

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wongma7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 4, 2021
@wongma7
Copy link
Contributor Author

wongma7 commented Jun 4, 2021

currently the test 'should fail to schedule a pod which has topologies that conflict with AllowedTopologies' is being skipped in migration suite because we only create nodes in one zone so there's only one topology to work with. I think we already have non migration test exercising this situation though

@coveralls
Copy link

coveralls commented Jun 4, 2021 •
edited
Loading

Coverage Status

Coverage remained the same at 79.025% when pulling b7876b7 on wongma7:testcapabilities into 990cf33 on kubernetes-sigs:master.

@nckturner
Copy link

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 9, 2021
@k8s-ci-robot k8s-ci-robot merged commit ab70907 into kubernetes-sigs:master Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bertinatto bertinatto Awaiting requested review from bertinatto

@ddebroy ddebroy Awaiting requested review from ddebroy

Assignees

@nckturner nckturner

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wongma7 @k8s-ci-robot @coveralls @nckturner