Default extra-create-metadata true so that volumes get created with pvc/pv tags #937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wongma7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
|
/cc @jsafrane do you see any issue with enabling this flag on by default? imo it needs to be on by default for migration feature parity with in tree driver so that the same tags get added to volumes. I think that was your intention when you added the tagging functionality but not sure. thanks. |
|
IMO, it's good to have it on by default. |
k8s-ci-robot
added
the
lgtm
This was referenced Jun 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a bug fix or adding new feature? this flag has been in external-provisioner for a long time now, we should default it true so that volumes get created with pvc/pv tags kubernetes.io/created-for
aws-ebs-csi-driver/pkg/driver/constants.go
Line 89 in 9f4ce44
What is this PR about? / Why do we need it? people want tags #180
What testing is done?