Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--delete-access-point-root-dir parameter not working as expected #1077

Closed
rshiva777 opened this issue Jul 29, 2023 · 7 comments
Closed

--delete-access-point-root-dir parameter not working as expected #1077

rshiva777 opened this issue Jul 29, 2023 · 7 comments
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@rshiva777
Copy link

rshiva777 commented Jul 29, 2023

/kind bug

What happened?
I have deployed aws-efs-csi-driver with " - --delete-access-point-root-dir=false" flag to the efs-plugin deployment. So when i create an pvc, access point and pvc-content is created under efs data directory as expected. But when i delete the pvc, access point gets deleted, but the pvc-content is under efs data directory is not getting deleted

What you expected to happen?
pvc-content under efs data directory should be deleted along with pvc and access point

How to reproduce it (as minimally and precisely as possible)?
Install aws-efs-csi-driver with " - --delete-access-point-root-dir=false" flag to the efs-plugin deployment

Anything else we need to know?:

Environment

  • Kubernetes version (use kubectl version): 1.25
  • Driver version: v1.5.8

Please also attach debug logs to help us better diagnose

  • Instructions to gather debug logs can be found here
@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Jul 29, 2023
@rshiva777 rshiva777 changed the title Files not getting deleted on the EFS when PVCs & Access Points are Deleted --delete-access-point-root-dir parameter not working as expected Jul 29, 2023
@rshiva777
Copy link
Author

rshiva777 commented Jul 29, 2023

So, as mentioned in the issue #411 i updated the " - --delete-access-point-root-dir=true" flag to the efs-plugin deployment

Now, when i create an pvc, access point and pvc-content is created under efs data directory as expected. But when i delete the pvc, access point is not deleted, and pvc-content is under efs data directory is not getting deleted

pv status is in released state, actually it should be deleted from cluster

when i check the efs-csi-controller logs, found there is some error as below

image

@alexander-maksymiw-bl
Copy link

I had the same issue, IAM policies are according to documentation.
It looks like it's again working when downgrading the aws-efs-csi-driver to e.g. 1.5.4 (the version I was running before)
Could this be related to #1055 or #1001 ?

@RyanStan
Copy link
Contributor

RyanStan commented Aug 8, 2023

Hi @rshiva777 and @alexander-maksymiw-bl , thank you for bringing this to our attention. Yes, we need to re-add privileged: true to the controller Deployment, since the controller Pods perform a mount to the filesystem to delete the access point directory.

We will push out a new Helm chart release to fix this. And add an integration test to our E2E tests to cover the delete access point root dir option so this doesn't happen again.

@RyanStan
Copy link
Contributor

/close

This has been fixed in the latest release.

@k8s-ci-robot
Copy link
Contributor

@RyanStan: You can't close an active issue/PR unless you authored it or you are a collaborator.

In response to this:

/close

This has been fixed in the latest release.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mskanth972
Copy link
Contributor

/close

@k8s-ci-robot
Copy link
Contributor

@mskanth972: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

5 participants