Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v1.2.0 #370

Merged
merged 4 commits into from
Mar 19, 2021
Merged

Release v1.2.0 #370

merged 4 commits into from
Mar 19, 2021

Conversation

wongma7
Copy link
Contributor

@wongma7 wongma7 commented Mar 18, 2021

Is this a bug fix or adding new feature?

What is this PR about? / Why do we need it? this is a cherry-pick of #368 on master to update docs and such now that the images from #368 have been pushed

also #371 to make the helm chart and kustomize match the changes in release-1.2

Also I updated the kustomize install in README, missed that the first round.

What testing is done?

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 18, 2021
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 18, 2021
@wongma7
Copy link
Contributor Author

wongma7 commented Mar 18, 2021

/hold

unhold when #371 merges.

then v1.2.0 will release 100%. we are 99% of the way there since there is a GitHub release but these readme updates aren't in amster branch yet..

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 18, 2021
@jqmichael
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 18, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jqmichael, wongma7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wongma7
Copy link
Contributor Author

wongma7 commented Mar 18, 2021

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 18, 2021
@wongma7
Copy link
Contributor Author

wongma7 commented Mar 18, 2021

/test pull-aws-efs-csi-driver-e2e

failure is worrisome

@wongma7
Copy link
Contributor Author

wongma7 commented Mar 19, 2021

[Fail] [efs-csi] EFS CSI [Driver: efs.csi.aws.com] [It] should continue reading/writing without hanging after the driver pod is restarted
/home/prow/go/src/github.com/kubernetes-sigs/aws-efs-csi-driver/test/e2e/e2e.go:303
[Fail] [efs-csi] EFS CSI [Driver: efs.csi.aws.com] [Testpattern: Pre-provisioned PV (default fs)] volumes [It] should store data
/home/prow/go/pkg/mod/k8s.io/kubernetes@v1.18.10/test/e2e/storage/utils/utils.go:83

/retest

need kubernetes-sigs/aws-ebs-csi-driver#802 for debugging

@wongma7
Copy link
Contributor Author

wongma7 commented Mar 19, 2021

Also, the driver restart test coudl mess with log-collecting anyway depending on order it is run since logs from before the test would disappear.

@kbasv
Copy link

kbasv commented Mar 19, 2021

/test pull-aws-efs-csi-driver-e2e

2 similar comments
@kbasv
Copy link

kbasv commented Mar 19, 2021

/test pull-aws-efs-csi-driver-e2e

@kbasv
Copy link

kbasv commented Mar 19, 2021

/test pull-aws-efs-csi-driver-e2e

@k8s-ci-robot k8s-ci-robot merged commit b617f0b into kubernetes-sigs:master Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants