[V2] fix: replicas aren't getting cleaned up during driver uninstall

[sunpa93]

What type of PR is this?

What this PR does / why we need it:

• Replica AzVolumeAttachments need to be detached and deleted during driver uninstall.
• This PR is necessary to unblock other tasks as 1) updating driver uninstall que and 2) adding allocation map.

Which issue(s) this PR fixes:

Fixes #

Requirements:

• uses conventional commit messages
• includes documentation
• adds unit tests
• tested upgrade from previous version

Special notes for your reviewer:

Release note:

none

[edreed]

/approve
/lgtm

[landreasyan]

/hold

[landreasyan]

I think it would be better to communicate with channels here. errors or result itself could be a buffered channel that would have the result of deletion. We would then send all the errors thorough that channel and instead of wg.Wait () we can have

go func() {
		wg.Wait()
		close(errors )
	}()

then we will loop over errors to check for any error:

for error := range errors {
		// update status
	}

[sunpa93]

Yeah, I see the benefit of using a buffered channel here. Let's merge this one and I will iterate on this in a separate PR as Huichan's change has dependency on this change.

[landreasyan]

Actually, we don't even need a buffered channel. The loop will read all the errors as reported until the channel is closed.

[landreasyan]

Sure!

[landreasyan]

np: I think it would be good to document the usage here.

[landreasyan]

/approve
/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: edreed, landreasyan, sunpa93

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [edreed,landreasyan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sunpa93]

/hold cancel