Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V2] fix: add nodeDiskAvailabilityMap #1595

Conversation

alice-zheyan-yu
Copy link
Contributor

@alice-zheyan-yu alice-zheyan-yu commented Nov 12, 2022

What type of PR is this?
/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Requirements:

Passed tests:

(node's max attachment count is 8. disk MaxShares = 2)
2 nodes, 8 disks
3 nodes, 11 disks
20 nodes, 20 disks
30 nodes, 30 disks

How I verified:

$kubectl get azvolumeattachment -A | grep Replica and
$kubectl get azvolumeattachment -A | grep Primary
can print out correct azvolumeattachments

Release note:

none

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 12, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @alice-zheyan-yu. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 12, 2022
@edreed edreed changed the title fix: add nodeDiskAvailabilityMap [V2] fix: add nodeDiskAvailabilityMap Nov 14, 2022
@edreed
Copy link
Collaborator

edreed commented Nov 14, 2022

Rather than use diskAvailability, consider using availableAttachments since it's disk attachments we're tracking.

@alice-zheyan-yu alice-zheyan-yu force-pushed the add_nodeDiskAvailabilityMap_for_attachment branch from 735f7ef to 395e233 Compare November 15, 2022 01:12
@alice-zheyan-yu
Copy link
Contributor Author

I'm still working on the unit tests. In the meantime, feel free to leave any comments for the current iteration.

@alice-zheyan-yu alice-zheyan-yu force-pushed the add_nodeDiskAvailabilityMap_for_attachment branch 4 times, most recently from d3352d7 to bfea038 Compare November 16, 2022 20:18
@alice-zheyan-yu alice-zheyan-yu force-pushed the add_nodeDiskAvailabilityMap_for_attachment branch from bfea038 to cc3e1c7 Compare November 17, 2022 22:14
@edreed
Copy link
Collaborator

edreed commented Nov 17, 2022

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 17, 2022
@alice-zheyan-yu alice-zheyan-yu force-pushed the add_nodeDiskAvailabilityMap_for_attachment branch 2 times, most recently from 8405075 to 3f69a41 Compare November 18, 2022 18:26
@alice-zheyan-yu alice-zheyan-yu force-pushed the add_nodeDiskAvailabilityMap_for_attachment branch from 3f69a41 to 35648a3 Compare November 18, 2022 18:41
@edreed
Copy link
Collaborator

edreed commented Nov 18, 2022

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 18, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alice-zheyan-yu, edreed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 18, 2022
@k8s-ci-robot k8s-ci-robot merged commit ecbbf65 into kubernetes-sigs:main_v2 Nov 18, 2022
@alice-zheyan-yu alice-zheyan-yu deleted the add_nodeDiskAvailabilityMap_for_attachment branch November 21, 2022 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants