-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[V2] fix: add nodeDiskAvailabilityMap #1595
[V2] fix: add nodeDiskAvailabilityMap #1595
Conversation
Hi @alice-zheyan-yu. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Rather than use |
735f7ef
to
395e233
Compare
I'm still working on the unit tests. In the meantime, feel free to leave any comments for the current iteration. |
d3352d7
to
bfea038
Compare
bfea038
to
cc3e1c7
Compare
/ok-to-test |
8405075
to
3f69a41
Compare
3f69a41
to
35648a3
Compare
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alice-zheyan-yu, edreed The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Requirements:
Passed tests:
(node's max attachment count is 8. disk MaxShares = 2)
2 nodes, 8 disks
3 nodes, 11 disks
20 nodes, 20 disks
30 nodes, 30 disks
How I verified:
$kubectl get azvolumeattachment -A | grep Replica and
$kubectl get azvolumeattachment -A | grep Primary
can print out correct azvolumeattachments
Release note: