Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add condition to controlPlaneServiceTemplate in KubevirtCluster… #235

Merged
merged 4 commits into from
May 16, 2023
Merged

feat: add condition to controlPlaneServiceTemplate in KubevirtCluster… #235

merged 4 commits into from
May 16, 2023

Conversation

aamoyel
Copy link
Contributor

@aamoyel aamoyel commented Apr 25, 2023

Fix #219

@aamoyel
feat: add condition to controlPlaneServiceTemplate in KubevirtCluster…
ed152f9 
… CRD to deploy LB service in namespace provided in metadata
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 25, 2023
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 25, 2023
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Apr 25, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Apr 25, 2023
@aamoyel
condition to use controlPlaneEndpoint values
38960ce
@aamoyel
Revert "feat: add condition to controlPlaneServiceTemplate in Kubevir…
285f1e6 
…tCluster CRD to deploy LB service in namespace provided in metadata"

This reverts commit ed152f9.
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 25, 2023
@coveralls
Copy link

coveralls commented May 2, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 4869775871

  • 9 of 9 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 52.733%
Totals Coverage Status
Change from base Build 4542574610: 0.2%
Covered Lines: 955
Relevant Lines: 1811
💛 - Coveralls

@agradouski
Copy link
Contributor

/retest

@agradouski
Copy link
Contributor

@aamoyel - looks like we have a failing test, please take a look

@aamoyel
feat: add condition to controlPlaneServiceTemplate in KubevirtCluster…
3d35fd1 
… CRD to deploy LB service in namespace provided in metadata
@aamoyel
Copy link
Contributor Author

aamoyel commented May 3, 2023 •
edited
Loading

@aamoyel - looks like we have a failing test, please take a look

Sorry, i've forget to gen CRD's manifests, i've pushed the new version of config/crd/bases/infrastructure.cluster.x-k8s.io_kubevirtclusters.yaml file. Can you retry tests ?

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 3, 2023
@davidvossel
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label May 16, 2023
davidvossel
davidvossel reviewed May 16, 2023
View reviewed changes
Copy link
Contributor

@davidvossel davidvossel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 16, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aamoyel, agradouski, davidvossel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [agradouski,davidvossel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 1b99674 into kubernetes-sigs:main May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidvossel davidvossel davidvossel left review comments

@agradouski agradouski agradouski approved these changes

@qinqon qinqon Awaiting requested review from qinqon

Assignees

@davidvossel davidvossel

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot change LB service namespace when infraClusterSecretRef is used (kubeconfig by default)
5 participants
@aamoyel @coveralls @agradouski @davidvossel @k8s-ci-robot