Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix "should succeed with the kubevirt cluster being deleted" unit test #259

Merged
merged 2 commits into from
Aug 21, 2023
Merged

Fix "should succeed with the kubevirt cluster being deleted" unit test #259

merged 2 commits into from
Aug 21, 2023

Commits on Aug 21, 2023

  1. Fix "should succeed with the kubevirt cluster being deleted" unit test 

    this unit test is broken. This PR fixes it by populating the
`KubevirtClusterReconciler.APIReader` field in unit-test, for mocking.

Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>
    @nunnatsa
    nunnatsa committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    b9550db View commit details
    Browse the repository at this point in the history

  2. Fix make generate-kccm-flavors 

    `make generate-kccm-flavors` generates wrong manifests, setting a
constant names where we should use variables.

This commit fixes the `hack/kccm-flavor-gen.sh` script so it will
replace the hard coded names with the right variables.

Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>
    @nunnatsa
    nunnatsa committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    68fbea2 View commit details
    Browse the repository at this point in the history