Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump dependencies #283

Closed
wants to merge 4 commits into from
Closed

Bump dependencies #283

wants to merge 4 commits into from

Conversation

changjjjjjjj
Copy link
Contributor

@changjjjjjjj changjjjjjjj commented May 22, 2024 •
edited
Loading

What this PR does / why we need it:
The goal of this PR is to bump dependencies

  • cluster-api v1.7.2
  • kubevirt v1.2.0
  • go v1.22.0

Release notes:

Bump cluster-api, kubevirt, go dependencies

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 22, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: changjjjjjjj
Once this PR has been reviewed and has the lgtm label, please assign neolit123 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 22, 2024
nunnatsa
nunnatsa requested changes May 23, 2024
View reviewed changes
Copy link
Contributor

@nunnatsa nunnatsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR @changjjjjjjj !

Please use latest versions where possible. Please see the inline comments.

e2e/go.mod Outdated Show resolved Hide resolved
e2e/go.mod Outdated Show resolved Hide resolved
e2e/go.mod Outdated Show resolved Hide resolved
@changjjjjjjj
Copy link
Contributor Author

@nunnatsa I pushed another commit for your request. (It includes minor fix of pkg/webhookhandler/validator.go)

@nunnatsa
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label May 23, 2024
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 23, 2024
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 23, 2024
@nunnatsa
Copy link
Contributor

@changjjjjjjj - thanks again for this PR. I adoped and continued it at #287

@nunnatsa nunnatsa mentioned this pull request May 30, 2024
Merged
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabriziopandini fabriziopandini Awaiting requested review from fabriziopandini

@qinqon qinqon Awaiting requested review from qinqon

@nunnatsa nunnatsa Awaiting requested review from nunnatsa

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@changjjjjjjj @k8s-ci-robot @nunnatsa