Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 E2E: Add subports to trunked port to test subports deletion #2141

Conversation

mquhuy
Copy link
Contributor

@mquhuy mquhuy commented Jul 11, 2024

This is a continuation of #2081. The idea is to have subports added to trunked port, so that we could verify that subports are deleted with the trunk.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 11, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @mquhuy. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

netlify bot commented Jul 11, 2024

Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
🔨 Latest commit 567dbb3
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/66aca090bcb31a0008f46b4a
😎 Deploy Preview https://deploy-preview-2141--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@EmilienM
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 11, 2024
@mquhuy mquhuy force-pushed the mquhuy/ensure-trunkport-deletion-e2e-test branch 6 times, most recently from 14e6083 to 428bf24 Compare July 15, 2024 10:22
@jichenjc
Copy link
Contributor

/test pull-cluster-api-provider-openstack-e2e-test

@mquhuy mquhuy force-pushed the mquhuy/ensure-trunkport-deletion-e2e-test branch from 428bf24 to 6bb273f Compare July 16, 2024 07:10
test/e2e/suites/e2e/e2e_test.go Outdated Show resolved Hide resolved
test/e2e/suites/e2e/e2e_test.go Outdated Show resolved Hide resolved
@mquhuy mquhuy force-pushed the mquhuy/ensure-trunkport-deletion-e2e-test branch from 6bb273f to 2834de0 Compare July 17, 2024 10:20
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 17, 2024
@mquhuy mquhuy force-pushed the mquhuy/ensure-trunkport-deletion-e2e-test branch 7 times, most recently from 601d45b to 941da20 Compare July 19, 2024 12:55
test/e2e/suites/e2e/e2e_test.go Outdated Show resolved Hide resolved
test/e2e/suites/e2e/e2e_test.go Outdated Show resolved Hide resolved
@mquhuy mquhuy force-pushed the mquhuy/ensure-trunkport-deletion-e2e-test branch 14 times, most recently from e11cfae to 0b82c3b Compare August 2, 2024 09:01
Signed-off-by: Huy Mai <huy.mai@est.tech>
@mquhuy mquhuy force-pushed the mquhuy/ensure-trunkport-deletion-e2e-test branch from 0b82c3b to 567dbb3 Compare August 2, 2024 09:02
@EmilienM
Copy link
Contributor

EmilienM commented Aug 2, 2024

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: EmilienM

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 2, 2024
@MaysaMacedo
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 6, 2024
@k8s-ci-robot k8s-ci-robot merged commit 5d92223 into kubernetes-sigs:main Aug 6, 2024
9 checks passed
k8s-ci-robot added a commit that referenced this pull request Aug 27, 2024
k8s-ci-robot added a commit that referenced this pull request Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

6 participants