-
Notifications
You must be signed in to change notification settings - Fork 662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an extra parameter ExitCode to RemoveFailedPods #1381
Conversation
/cc @Huang-Wei |
/ok-to-test |
@yuanchen8911 could you update the readme |
Updated |
@jklaw90, may I have it reviewed? Thanks! |
/lgtm Thanks for your pr @yuanchen8911 |
Would you approve it as well? Thanks! |
README.md
Outdated
You can provide an optional parameter to filter by failed `reasons`. | ||
`reasons` can be expanded to include reasons of InitContainers as well by setting the optional parameter `includingInitContainers` to `true`. | ||
You can provide an optional parameter to filter by failed `reasons` and `exitCodes`. | ||
`reasons` and `exitCodes` can be expanded to include reasons of InitContainers as well by setting the optional parameter `includingInitContainers` to `true`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worth mentioning the exit codes apply only when the pod's phase is failed.
reasons
andexitCodes
can be expanded to include reasons of InitContainers as well by setting the optional parameterincludingInitContainers
totrue
.
Better to split the sentence into two. "can be expanded to include reasons of InitContainers" applies for reasons
only.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can provide an optional parameter to filter by failed
reasons
andexitCodes
.
You can provide an optional parameter to filter by failed reasons
or exitCodes
or both.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed the description to
Worth mentioning the exit codes apply only when the pod's phase is failed.
Here's the updated version.
"You can provide optional parameters to filter by failed pods' and containers' reasons
. and exitCodes
. exitCodes
apply to pods' containers with terminated
state only."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worth mentioning the exit codes apply only when the pod's phase is failed.
reasons
andexitCodes
can be expanded to include reasons of InitContainers as well by setting the optional parameterincludingInitContainers
totrue
.Better to split the sentence into two. "can be expanded to include reasons of InitContainers" applies for
reasons
only.
exitCode
applies to initContainer too. This is actually the main use cases of the PR. Here's the updated description.
"You can provide optional parameters to filter by failed pods' and containers' reasons
. and exitCodes
. exitCodes
apply to pods' containers with terminated
state only."
$ kubectl explain pod.status.initContainerStatuses.state.terminated
KIND: Pod
VERSION: v1
FIELD: terminated <ContainerStateTerminated>
DESCRIPTION:
Details about a terminated container
ContainerStateTerminated is a terminated state of a container.
FIELDS:
containerID <string>
Container's ID in the format '<type>://<container_id>'
exitCode <integer> -required-
Exit status from the last termination of the container
finishedAt <string>
Time at which the container last terminated
message <string>
Message regarding the last termination of the container
reason <string>
(brief) reason from the last termination of the container
signal <integer>
Signal from the last termination of the container
startedAt <string>
Time at which previous execution of the container started
```
@ingvagabund, thanks for reviewing the PR. I've made the suggested changes to address your comments. Can you take another look please? |
/lgtm |
I believe this would be the first time that we're adding a field to v1alpha2 (but not v1alpha1). I think that's ok, given that it's being deprecated and removed in 1.31. Just wanted to note that. |
Update README.md Fix README and test files Update README Address a7i's comments Update README
/approve as I believe all of @ingvagabund comments were addressed /lgtm as I believe @jklaw90 already did Thank you for your contribution @yuanchen8911 and being patient with us |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a7i The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This will be included as part of v0.30 soon 🤞🏼 ™️ |
/lgtm |
Thank you all for reviewing the PR! |
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [descheduler](https://github.com/kubernetes-sigs/descheduler) | minor | `0.29.0` -> `0.30.0` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>kubernetes-sigs/descheduler (descheduler)</summary> ### [`v0.30.0`](https://github.com/kubernetes-sigs/descheduler/releases/tag/v0.30.0): Descheduler v0.30.0 [Compare Source](https://github.com/kubernetes-sigs/descheduler/compare/v0.29.0...v0.30.0) #### What's Changed - fix(podlifetime): fix failed unittest by [@​xujihui1985](https://github.com/xujihui1985) in [kubernetes-sigs/descheduler#1334 - `PodLifeTime`: update support pods with container status and pods reason by [@​dongjiang1989](https://github.com/dongjiang1989) in [kubernetes-sigs/descheduler#1330 - v1alpha1: log deprecation notice by [@​a7i](https://github.com/a7i) in [kubernetes-sigs/descheduler#1337 - feat: Add support for topologySpreadConstraints by [@​UAntBou](https://github.com/UAntBou) in [kubernetes-sigs/descheduler#1289 - chore: update dependencies for security vulnerabilities (CVE-2023-48795) by [@​a7i](https://github.com/a7i) in [kubernetes-sigs/descheduler#1343 - trim managedFields in shared informer factory by [@​a7i](https://github.com/a7i) in [kubernetes-sigs/descheduler#1346 - fix: `RemovePodsHavingTooManyRestarts` to include `InitContainerStatuses` by [@​a7i](https://github.com/a7i) in [kubernetes-sigs/descheduler#1348 - Improve PodEvictor observability through EvictOptions by [@​tioxy](https://github.com/tioxy) in [kubernetes-sigs/descheduler#1349 - Fix node taint wrong EvictOption field by [@​tioxy](https://github.com/tioxy) in [kubernetes-sigs/descheduler#1358 - Disambiguate node fit log messages by [@​jackfrancis](https://github.com/jackfrancis) in [kubernetes-sigs/descheduler#1362 - Check whether pod matches the inter-pod anti-affinity of another Pod in a given Node in `NodeFit()` by [@​nikimanoledaki](https://github.com/nikimanoledaki) in [kubernetes-sigs/descheduler#1356 - Bump to k8s v0.30.0-alpha.3 by [@​pravarag](https://github.com/pravarag) in [kubernetes-sigs/descheduler#1359 - skip eviction when replica count is below evictor `minReplicas` threshold setting by [@​a7i](https://github.com/a7i) in [kubernetes-sigs/descheduler#1257 - Add argument to remove only pods violating allowlisted taints by [@​etoster](https://github.com/etoster) in [kubernetes-sigs/descheduler#1360 - use v1alpha2 api for helm chart default values by [@​a7i](https://github.com/a7i) in [kubernetes-sigs/descheduler#1139 - `RemoveDuplicates`: reduce cycle times identifying duplicates by [@​ls-2018](https://github.com/ls-2018) in [kubernetes-sigs/descheduler#1365 - avoid redundant type conversion of DefaultEvictorArgs parameter in DefaultEvictor by [@​fanhaouu](https://github.com/fanhaouu) in [kubernetes-sigs/descheduler#1369 - bump(golang.org/x/net)=v0.23.0 by [@​ingvagabund](https://github.com/ingvagabund) in [kubernetes-sigs/descheduler#1373 - Allow eviction of DaemonSet pods by [@​tioxy](https://github.com/tioxy) in [kubernetes-sigs/descheduler#1342 - bump to go 1.22.2 by [@​jklaw90](https://github.com/jklaw90) in [kubernetes-sigs/descheduler#1374 - helm: Allow the use of existing policy configMap by [@​agmimidi](https://github.com/agmimidi) in [kubernetes-sigs/descheduler#1376 - Fix and improve the namespace filtering description in README by [@​yuanchen8911](https://github.com/yuanchen8911) in [kubernetes-sigs/descheduler#1379 - Add an extra parameter ExitCode to RemoveFailedPods by [@​yuanchen8911](https://github.com/yuanchen8911) in [kubernetes-sigs/descheduler#1381 - 753 - Descheduling framework by [@​ingvagabund](https://github.com/ingvagabund) in [kubernetes-sigs/descheduler#1372 - KEP-753: Descheduling framework: update diagram by [@​ingvagabund](https://github.com/ingvagabund) in [kubernetes-sigs/descheduler#1396 - \[release 1.30] upgrade kubernetes version and docs by [@​a7i](https://github.com/a7i) in [kubernetes-sigs/descheduler#1400 #### New Contributors - [@​xujihui1985](https://github.com/xujihui1985) made their first contribution in [kubernetes-sigs/descheduler#1334 - [@​UAntBou](https://github.com/UAntBou) made their first contribution in [kubernetes-sigs/descheduler#1289 - [@​tioxy](https://github.com/tioxy) made their first contribution in [kubernetes-sigs/descheduler#1349 - [@​jackfrancis](https://github.com/jackfrancis) made their first contribution in [kubernetes-sigs/descheduler#1362 - [@​nikimanoledaki](https://github.com/nikimanoledaki) made their first contribution in [kubernetes-sigs/descheduler#1356 - [@​etoster](https://github.com/etoster) made their first contribution in [kubernetes-sigs/descheduler#1360 - [@​ls-2018](https://github.com/ls-2018) made their first contribution in [kubernetes-sigs/descheduler#1365 - [@​fanhaouu](https://github.com/fanhaouu) made their first contribution in [kubernetes-sigs/descheduler#1369 - [@​agmimidi](https://github.com/agmimidi) made their first contribution in [kubernetes-sigs/descheduler#1376 - [@​yuanchen8911](https://github.com/yuanchen8911) made their first contribution in [kubernetes-sigs/descheduler#1379 **Full Changelog**: kubernetes-sigs/descheduler@v0.29.0...v0.30.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNjguOSIsInVwZGF0ZWRJblZlciI6IjM3LjM2OC45IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZS9oZWxtIiwidHlwZS9taW5vciJdfQ==-->
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [descheduler](https://github.com/kubernetes-sigs/descheduler) | minor | `0.29.0` -> `0.30.0` | --- ### Release Notes <details> <summary>kubernetes-sigs/descheduler (descheduler)</summary> ### [`v0.30.0`](https://github.com/kubernetes-sigs/descheduler/releases/tag/v0.30.0): Descheduler v0.30.0 [Compare Source](https://github.com/kubernetes-sigs/descheduler/compare/v0.29.0...v0.30.0) #### What's Changed - fix(podlifetime): fix failed unittest by [@​xujihui1985](https://github.com/xujihui1985) in [kubernetes-sigs/descheduler#1334 - `PodLifeTime`: update support pods with container status and pods reason by [@​dongjiang1989](https://github.com/dongjiang1989) in [kubernetes-sigs/descheduler#1330 - v1alpha1: log deprecation notice by [@​a7i](https://github.com/a7i) in [kubernetes-sigs/descheduler#1337 - feat: Add support for topologySpreadConstraints by [@​UAntBou](https://github.com/UAntBou) in [kubernetes-sigs/descheduler#1289 - chore: update dependencies for security vulnerabilities (CVE-2023-48795) by [@​a7i](https://github.com/a7i) in [kubernetes-sigs/descheduler#1343 - trim managedFields in shared informer factory by [@​a7i](https://github.com/a7i) in [kubernetes-sigs/descheduler#1346 - fix: `RemovePodsHavingTooManyRestarts` to include `InitContainerStatuses` by [@​a7i](https://github.com/a7i) in [kubernetes-sigs/descheduler#1348 - Improve PodEvictor observability through EvictOptions by [@​tioxy](https://github.com/tioxy) in [kubernetes-sigs/descheduler#1349 - Fix node taint wrong EvictOption field by [@​tioxy](https://github.com/tioxy) in [kubernetes-sigs/descheduler#1358 - Disambiguate node fit log messages by [@​jackfrancis](https://github.com/jackfrancis) in [kubernetes-sigs/descheduler#1362 - Check whether pod matches the inter-pod anti-affinity of another Pod in a given Node in `NodeFit()` by [@​nikimanoledaki](https://github.com/nikimanoledaki) in [kubernetes-sigs/descheduler#1356 - Bump to k8s v0.30.0-alpha.3 by [@​pravarag](https://github.com/pravarag) in [kubernetes-sigs/descheduler#1359 - skip eviction when replica count is below evictor `minReplicas` threshold setting by [@​a7i](https://github.com/a7i) in [kubernetes-sigs/descheduler#1257 - Add argument to remove only pods violating allowlisted taints by [@​etoster](https://github.com/etoster) in [kubernetes-sigs/descheduler#1360 - use v1alpha2 api for helm chart default values by [@​a7i](https://github.com/a7i) in [kubernetes-sigs/descheduler#1139 - `RemoveDuplicates`: reduce cycle times identifying duplicates by [@​ls-2018](https://github.com/ls-2018) in [kubernetes-sigs/descheduler#1365 - avoid redundant type conversion of DefaultEvictorArgs parameter in DefaultEvictor by [@​fanhaouu](https://github.com/fanhaouu) in [kubernetes-sigs/descheduler#1369 - bump(golang.org/x/net)=v0.23.0 by [@​ingvagabund](https://github.com/ingvagabund) in [kubernetes-sigs/descheduler#1373 - Allow eviction of DaemonSet pods by [@​tioxy](https://github.com/tioxy) in [kubernetes-sigs/descheduler#1342 - bump to go 1.22.2 by [@​jklaw90](https://github.com/jklaw90) in [kubernetes-sigs/descheduler#1374 - helm: Allow the use of existing policy configMap by [@​agmimidi](https://github.com/agmimidi) in [kubernetes-sigs/descheduler#1376 - Fix and improve the namespace filtering description in README by [@​yuanchen8911](https://github.com/yuanchen8911) in [kubernetes-sigs/descheduler#1379 - Add an extra parameter ExitCode to RemoveFailedPods by [@​yuanchen8911](https://github.com/yuanchen8911) in [kubernetes-sigs/descheduler#1381 - 753 - Descheduling framework by [@​ingvagabund](https://github.com/ingvagabund) in [kubernetes-sigs/descheduler#1372 - KEP-753: Descheduling framework: update diagram by [@​ingvagabund](https://github.com/ingvagabund) in [kubernetes-sigs/descheduler#1396 - \[release 1.30] upgrade kubernetes version and docs by [@​a7i](https://github.com/a7i) in [kubernetes-sigs/descheduler#1400 #### New Contributors - [@​xujihui1985](https://github.com/xujihui1985) made their first contribution in [kubernetes-sigs/descheduler#1334 - [@​UAntBou](https://github.com/UAntBou) made their first contribution in [kubernetes-sigs/descheduler#1289 - [@​tioxy](https://github.com/tioxy) made their first contribution in [kubernetes-sigs/descheduler#1349 - [@​jackfrancis](https://github.com/jackfrancis) made their first contribution in [kubernetes-sigs/descheduler#1362 - [@​nikimanoledaki](https://github.com/nikimanoledaki) made their first contribution in [kubernetes-sigs/descheduler#1356 - [@​etoster](https://github.com/etoster) made their first contribution in [kubernetes-sigs/descheduler#1360 - [@​ls-2018](https://github.com/ls-2018) made their first contribution in [kubernetes-sigs/descheduler#1365 - [@​fanhaouu](https://github.com/fanhaouu) made their first contribution in [kubernetes-sigs/descheduler#1369 - [@​agmimidi](https://github.com/agmimidi) made their first contribution in [kubernetes-sigs/descheduler#1376 - [@​yuanchen8911](https://github.com/yuanchen8911) made their first contribution in [kubernetes-sigs/descheduler#1379 **Full Changelog**: kubernetes-sigs/descheduler@v0.29.0...v0.30.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNjguOSIsInVwZGF0ZWRJblZlciI6IjM3LjM2OC45IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZS9oZWxtIiwidHlwZS9taW5vciJdfQ==--> Co-authored-by: kireque-bot[bot] <143391978+kireque-bot[bot]@users.noreply.github.com>
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [descheduler](https://github.com/kubernetes-sigs/descheduler) | minor | `0.29.0` -> `0.30.1` | --- ### Release Notes <details> <summary>kubernetes-sigs/descheduler (descheduler)</summary> ### [`v0.30.1`](https://github.com/kubernetes-sigs/descheduler/compare/v0.30.0...v0.30.1) [Compare Source](https://github.com/kubernetes-sigs/descheduler/compare/v0.30.0...v0.30.1) ### [`v0.30.0`](https://github.com/kubernetes-sigs/descheduler/releases/tag/v0.30.0): Descheduler v0.30.0 [Compare Source](https://github.com/kubernetes-sigs/descheduler/compare/v0.29.0...v0.30.0) #### What's Changed - fix(podlifetime): fix failed unittest by [@​xujihui1985](https://github.com/xujihui1985) in [kubernetes-sigs/descheduler#1334 - `PodLifeTime`: update support pods with container status and pods reason by [@​dongjiang1989](https://github.com/dongjiang1989) in [kubernetes-sigs/descheduler#1330 - v1alpha1: log deprecation notice by [@​a7i](https://github.com/a7i) in [kubernetes-sigs/descheduler#1337 - feat: Add support for topologySpreadConstraints by [@​UAntBou](https://github.com/UAntBou) in [kubernetes-sigs/descheduler#1289 - chore: update dependencies for security vulnerabilities (CVE-2023-48795) by [@​a7i](https://github.com/a7i) in [kubernetes-sigs/descheduler#1343 - trim managedFields in shared informer factory by [@​a7i](https://github.com/a7i) in [kubernetes-sigs/descheduler#1346 - fix: `RemovePodsHavingTooManyRestarts` to include `InitContainerStatuses` by [@​a7i](https://github.com/a7i) in [kubernetes-sigs/descheduler#1348 - Improve PodEvictor observability through EvictOptions by [@​tioxy](https://github.com/tioxy) in [kubernetes-sigs/descheduler#1349 - Fix node taint wrong EvictOption field by [@​tioxy](https://github.com/tioxy) in [kubernetes-sigs/descheduler#1358 - Disambiguate node fit log messages by [@​jackfrancis](https://github.com/jackfrancis) in [kubernetes-sigs/descheduler#1362 - Check whether pod matches the inter-pod anti-affinity of another Pod in a given Node in `NodeFit()` by [@​nikimanoledaki](https://github.com/nikimanoledaki) in [kubernetes-sigs/descheduler#1356 - Bump to k8s v0.30.0-alpha.3 by [@​pravarag](https://github.com/pravarag) in [kubernetes-sigs/descheduler#1359 - skip eviction when replica count is below evictor `minReplicas` threshold setting by [@​a7i](https://github.com/a7i) in [kubernetes-sigs/descheduler#1257 - Add argument to remove only pods violating allowlisted taints by [@​etoster](https://github.com/etoster) in [kubernetes-sigs/descheduler#1360 - use v1alpha2 api for helm chart default values by [@​a7i](https://github.com/a7i) in [kubernetes-sigs/descheduler#1139 - `RemoveDuplicates`: reduce cycle times identifying duplicates by [@​ls-2018](https://github.com/ls-2018) in [kubernetes-sigs/descheduler#1365 - avoid redundant type conversion of DefaultEvictorArgs parameter in DefaultEvictor by [@​fanhaouu](https://github.com/fanhaouu) in [kubernetes-sigs/descheduler#1369 - bump(golang.org/x/net)=v0.23.0 by [@​ingvagabund](https://github.com/ingvagabund) in [kubernetes-sigs/descheduler#1373 - Allow eviction of DaemonSet pods by [@​tioxy](https://github.com/tioxy) in [kubernetes-sigs/descheduler#1342 - bump to go 1.22.2 by [@​jklaw90](https://github.com/jklaw90) in [kubernetes-sigs/descheduler#1374 - helm: Allow the use of existing policy configMap by [@​agmimidi](https://github.com/agmimidi) in [kubernetes-sigs/descheduler#1376 - Fix and improve the namespace filtering description in README by [@​yuanchen8911](https://github.com/yuanchen8911) in [kubernetes-sigs/descheduler#1379 - Add an extra parameter ExitCode to RemoveFailedPods by [@​yuanchen8911](https://github.com/yuanchen8911) in [kubernetes-sigs/descheduler#1381 - 753 - Descheduling framework by [@​ingvagabund](https://github.com/ingvagabund) in [kubernetes-sigs/descheduler#1372 - KEP-753: Descheduling framework: update diagram by [@​ingvagabund](https://github.com/ingvagabund) in [kubernetes-sigs/descheduler#1396 - \[release 1.30] upgrade kubernetes version and docs by [@​a7i](https://github.com/a7i) in [kubernetes-sigs/descheduler#1400 #### New Contributors - [@​xujihui1985](https://github.com/xujihui1985) made their first contribution in [kubernetes-sigs/descheduler#1334 - [@​UAntBou](https://github.com/UAntBou) made their first contribution in [kubernetes-sigs/descheduler#1289 - [@​tioxy](https://github.com/tioxy) made their first contribution in [kubernetes-sigs/descheduler#1349 - [@​jackfrancis](https://github.com/jackfrancis) made their first contribution in [kubernetes-sigs/descheduler#1362 - [@​nikimanoledaki](https://github.com/nikimanoledaki) made their first contribution in [kubernetes-sigs/descheduler#1356 - [@​etoster](https://github.com/etoster) made their first contribution in [kubernetes-sigs/descheduler#1360 - [@​ls-2018](https://github.com/ls-2018) made their first contribution in [kubernetes-sigs/descheduler#1365 - [@​fanhaouu](https://github.com/fanhaouu) made their first contribution in [kubernetes-sigs/descheduler#1369 - [@​agmimidi](https://github.com/agmimidi) made their first contribution in [kubernetes-sigs/descheduler#1376 - [@​yuanchen8911](https://github.com/yuanchen8911) made their first contribution in [kubernetes-sigs/descheduler#1379 **Full Changelog**: kubernetes-sigs/descheduler@v0.29.0...v0.30.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on saturday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/sp3nx0r/homelab). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNjguMTAiLCJ1cGRhdGVkSW5WZXIiOiIzNy4zODguMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsicmVub3ZhdGUvaGVsbSIsInR5cGUvbWlub3IiXX0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…0.30.x (#1015) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [descheduler](https://github.com/kubernetes-sigs/descheduler) | minor | `0.29.x` -> `0.30.x` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>kubernetes-sigs/descheduler (descheduler)</summary> ### [`v0.30.1`](https://github.com/kubernetes-sigs/descheduler/releases/tag/v0.30.1): Descheduler v0.30.1 [Compare Source](https://github.com/kubernetes-sigs/descheduler/compare/v0.30.0...v0.30.1) #### What's Changed - bump to to 1.22.3 to address CVE-2024-24788 by [@​a7i](https://github.com/a7i) in [kubernetes-sigs/descheduler#1408 - \[release 1.30] update kustomize image tags and helm versions by [@​a7i](https://github.com/a7i) in [kubernetes-sigs/descheduler#1405 - Automated cherry pick of [#​1378](https://github.com/kubernetes-sigs/descheduler/issues/1378): Fix the replicas type for the helm-chart [#​1390](https://github.com/kubernetes-sigs/descheduler/issues/1390): allow 'falsey' value in cmdOption [#​1412](https://github.com/kubernetes-sigs/descheduler/issues/1412): fix helm's default deschedulerPolicy [#​1413](https://github.com/kubernetes-sigs/descheduler/issues/1413): fix TOC location in Readme [#​1416](https://github.com/kubernetes-sigs/descheduler/issues/1416): use cmd context instead of using context.Background() [#​1395](https://github.com/kubernetes-sigs/descheduler/issues/1395): fix the issue that the pod anti-filtering rules are not by [@​a7i](https://github.com/a7i) in [kubernetes-sigs/descheduler#1425 **Full Changelog**: kubernetes-sigs/descheduler@v0.30.0...v0.30.1 ### [`v0.30.0`](https://github.com/kubernetes-sigs/descheduler/releases/tag/v0.30.0): Descheduler v0.30.0 [Compare Source](https://github.com/kubernetes-sigs/descheduler/compare/v0.29.0...v0.30.0) #### What's Changed - fix(podlifetime): fix failed unittest by [@​xujihui1985](https://github.com/xujihui1985) in [kubernetes-sigs/descheduler#1334 - `PodLifeTime`: update support pods with container status and pods reason by [@​dongjiang1989](https://github.com/dongjiang1989) in [kubernetes-sigs/descheduler#1330 - v1alpha1: log deprecation notice by [@​a7i](https://github.com/a7i) in [kubernetes-sigs/descheduler#1337 - feat: Add support for topologySpreadConstraints by [@​UAntBou](https://github.com/UAntBou) in [kubernetes-sigs/descheduler#1289 - chore: update dependencies for security vulnerabilities (CVE-2023-48795) by [@​a7i](https://github.com/a7i) in [kubernetes-sigs/descheduler#1343 - trim managedFields in shared informer factory by [@​a7i](https://github.com/a7i) in [kubernetes-sigs/descheduler#1346 - fix: `RemovePodsHavingTooManyRestarts` to include `InitContainerStatuses` by [@​a7i](https://github.com/a7i) in [kubernetes-sigs/descheduler#1348 - Improve PodEvictor observability through EvictOptions by [@​tioxy](https://github.com/tioxy) in [kubernetes-sigs/descheduler#1349 - Fix node taint wrong EvictOption field by [@​tioxy](https://github.com/tioxy) in [kubernetes-sigs/descheduler#1358 - Disambiguate node fit log messages by [@​jackfrancis](https://github.com/jackfrancis) in [kubernetes-sigs/descheduler#1362 - Check whether pod matches the inter-pod anti-affinity of another Pod in a given Node in `NodeFit()` by [@​nikimanoledaki](https://github.com/nikimanoledaki) in [kubernetes-sigs/descheduler#1356 - Bump to k8s v0.30.0-alpha.3 by [@​pravarag](https://github.com/pravarag) in [kubernetes-sigs/descheduler#1359 - skip eviction when replica count is below evictor `minReplicas` threshold setting by [@​a7i](https://github.com/a7i) in [kubernetes-sigs/descheduler#1257 - Add argument to remove only pods violating allowlisted taints by [@​etoster](https://github.com/etoster) in [kubernetes-sigs/descheduler#1360 - use v1alpha2 api for helm chart default values by [@​a7i](https://github.com/a7i) in [kubernetes-sigs/descheduler#1139 - `RemoveDuplicates`: reduce cycle times identifying duplicates by [@​ls-2018](https://github.com/ls-2018) in [kubernetes-sigs/descheduler#1365 - avoid redundant type conversion of DefaultEvictorArgs parameter in DefaultEvictor by [@​fanhaouu](https://github.com/fanhaouu) in [kubernetes-sigs/descheduler#1369 - bump(golang.org/x/net)=v0.23.0 by [@​ingvagabund](https://github.com/ingvagabund) in [kubernetes-sigs/descheduler#1373 - Allow eviction of DaemonSet pods by [@​tioxy](https://github.com/tioxy) in [kubernetes-sigs/descheduler#1342 - bump to go 1.22.2 by [@​jklaw90](https://github.com/jklaw90) in [kubernetes-sigs/descheduler#1374 - helm: Allow the use of existing policy configMap by [@​agmimidi](https://github.com/agmimidi) in [kubernetes-sigs/descheduler#1376 - Fix and improve the namespace filtering description in README by [@​yuanchen8911](https://github.com/yuanchen8911) in [kubernetes-sigs/descheduler#1379 - Add an extra parameter ExitCode to RemoveFailedPods by [@​yuanchen8911](https://github.com/yuanchen8911) in [kubernetes-sigs/descheduler#1381 - 753 - Descheduling framework by [@​ingvagabund](https://github.com/ingvagabund) in [kubernetes-sigs/descheduler#1372 - KEP-753: Descheduling framework: update diagram by [@​ingvagabund](https://github.com/ingvagabund) in [kubernetes-sigs/descheduler#1396 - \[release 1.30] upgrade kubernetes version and docs by [@​a7i](https://github.com/a7i) in [kubernetes-sigs/descheduler#1400 #### New Contributors - [@​xujihui1985](https://github.com/xujihui1985) made their first contribution in [kubernetes-sigs/descheduler#1334 - [@​UAntBou](https://github.com/UAntBou) made their first contribution in [kubernetes-sigs/descheduler#1289 - [@​tioxy](https://github.com/tioxy) made their first contribution in [kubernetes-sigs/descheduler#1349 - [@​jackfrancis](https://github.com/jackfrancis) made their first contribution in [kubernetes-sigs/descheduler#1362 - [@​nikimanoledaki](https://github.com/nikimanoledaki) made their first contribution in [kubernetes-sigs/descheduler#1356 - [@​etoster](https://github.com/etoster) made their first contribution in [kubernetes-sigs/descheduler#1360 - [@​ls-2018](https://github.com/ls-2018) made their first contribution in [kubernetes-sigs/descheduler#1365 - [@​fanhaouu](https://github.com/fanhaouu) made their first contribution in [kubernetes-sigs/descheduler#1369 - [@​agmimidi](https://github.com/agmimidi) made their first contribution in [kubernetes-sigs/descheduler#1376 - [@​yuanchen8911](https://github.com/yuanchen8911) made their first contribution in [kubernetes-sigs/descheduler#1379 **Full Changelog**: kubernetes-sigs/descheduler@v0.29.0...v0.30.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/teutonet/teutonet-helm-charts). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjEuOSIsInVwZGF0ZWRJblZlciI6IjM3LjQyMS45IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
The current
RemoveFailedPods
strategy includes a parameterreason
from a terminated container's status (state). In addition toreason
, the fieldexitCode
in a container's status, which describes the exit status from the last termination of a container, can provide additional and useful information about a container's termination.A common use case is AI/ML training jobs often inject/run pre-flight health checks in initContainers and take actions according to the
exitCode
value when an initContainer fails, e.g., deleting the scheduled job pod viaDescheduler
.This PR adds a terminated container's
exitCode
as an additional parameter to theRemoveFailedPods
strategy.Fix #1380