e2e: TestLeaderElection: delete the lease and increase the retry period #1469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/S
JaneLiuL
reviewed
Jul 19, 2024
| @@ -141,7 +156,11 @@ func TestLeaderElection(t *testing.T) { | |||
| t.Logf("Only the pods in %s namespace are evicted. Pods before: %s, Pods after %s", ns2, podListBOrg, podListB) | |||
| } | |||
| } else { | |||
| t.Fatalf("Pods are evicted in both namespaces. For %s namespace Pods before: %s, Pods after %s. And, for %s namespace Pods before: %s, Pods after: %s", ns1, podListAOrg, podListA, ns2, podListBOrg, podListB) | |||
| if left && right { | |||
| t.Fatalf("No pods evicted. Probably none of the deschedulers were running.") | |||
There was a problem hiding this comment.
The test needs to fail here as well. The test expect at least one descheduler running.
There was a problem hiding this comment.
Oh, ok, then lgtm now~~ thanks for your explain~
k8s-ci-robot
added
the
lgtm
a7i
reviewed
Jul 22, 2024
test/e2e/e2e_leaderelection_test.go
Outdated
| if err != nil && !apierrors.IsNotFound(err) { | ||
| t.Fatalf("Unable to remove kube-system/descheduler lease: %v", err) | ||
| } else { | ||
| t.Logf("Removed kube-system/descheduler lease") |
There was a problem hiding this comment.
a bit misleading since 'not found' doesn't actually remove
There was a problem hiding this comment.
You are right. Updated. Thx.
In some random cases none of the deschedulers acquires a lease. Making the test fail.
ingvagabund
force-pushed
the
e2e-fix-leaderelection
branch
from
5e0ecdd
to
d2bd573
Compare
k8s-ci-robot
removed
the
lgtm
6 tasks
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a7i The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
rouke-broersma
pushed a commit
to broersma-forslund/homelab
that referenced
this pull request
Sep 10, 2024
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [descheduler](https://redirect.github.com/kubernetes-sigs/descheduler) | minor | `0.30.1` -> `0.31.0` | --- ### Release Notes <details> <summary>kubernetes-sigs/descheduler (descheduler)</summary> ### [`v0.31.0`](https://redirect.github.com/kubernetes-sigs/descheduler/releases/tag/v0.31.0): Descheduler v0.31.0 [Compare Source](https://redirect.github.com/kubernetes-sigs/descheduler/compare/v0.30.1...v0.31.0) #### What's Changed - bump to to 1.22.3 to address CVE-2024-24788 by [@​a7i](https://redirect.github.com/a7i) in [kubernetes-sigs/descheduler#1408 - Fix the replicas value type for the descheduler helm-chart by [@​hanyouqing](https://redirect.github.com/hanyouqing) in [kubernetes-sigs/descheduler#1378 - Helm chart - allow 'falsey' value in cmdOption by [@​omerap12](https://redirect.github.com/omerap12) in [kubernetes-sigs/descheduler#1390 - fix helm's default deschedulerPolicy by [@​duplabe](https://redirect.github.com/duplabe) in [kubernetes-sigs/descheduler#1412 - fix TOC location in Readme by [@​duplabe](https://redirect.github.com/duplabe) in [kubernetes-sigs/descheduler#1413 - use cmd context instead of using context.Background() by [@​googs1025](https://redirect.github.com/googs1025) in [kubernetes-sigs/descheduler#1416 - fix the issue that the pod anti-filtering rules are not taking effect by [@​fanhaouu](https://redirect.github.com/fanhaouu) in [kubernetes-sigs/descheduler#1395 - Bump otel semconv to 1.24 by [@​damemi](https://redirect.github.com/damemi) in [kubernetes-sigs/descheduler#1429 - chore: reduce repetition of go versions by [@​a7i](https://redirect.github.com/a7i) in [kubernetes-sigs/descheduler#1432 - bump go to 1.22.4 for CVE-2024-24790 and CVE-2024-24789 by [@​a7i](https://redirect.github.com/a7i) in [kubernetes-sigs/descheduler#1433 - return pod qos in advance by [@​fanhaouu](https://redirect.github.com/fanhaouu) in [kubernetes-sigs/descheduler#1435 - add validation ut by [@​googs1025](https://redirect.github.com/googs1025) in [kubernetes-sigs/descheduler#1439 - refactor some methods in e2e test by [@​googs1025](https://redirect.github.com/googs1025) in [kubernetes-sigs/descheduler#1441 - Automated cherry pick of [#​1427](https://redirect.github.com/kubernetes-sigs/descheduler/issues/1427): helm: upgrade to v0.30.1 by [@​a7i](https://redirect.github.com/a7i) in [kubernetes-sigs/descheduler#1431 - chore: cleanup duplicated code by [@​googs1025](https://redirect.github.com/googs1025) in [kubernetes-sigs/descheduler#1438 - fix: return the unmatched cases first by [@​googs1025](https://redirect.github.com/googs1025) in [kubernetes-sigs/descheduler#1446 - Unit-test: add necessary ownerRef to the pod. by [@​zhifei92](https://redirect.github.com/zhifei92) in [kubernetes-sigs/descheduler#1445 - PodEvictor: refactoring and preparation for eviction requests by [@​ingvagabund](https://redirect.github.com/ingvagabund) in [kubernetes-sigs/descheduler#1447 - refactor: PodMatchNodeSelector method by [@​googs1025](https://redirect.github.com/googs1025) in [kubernetes-sigs/descheduler#1450 - return node fit error in advance by [@​fanhaouu](https://redirect.github.com/fanhaouu) in [kubernetes-sigs/descheduler#1436 - test: generate uid when building a pod by [@​ingvagabund](https://redirect.github.com/ingvagabund) in [kubernetes-sigs/descheduler#1454 - feat: pod evictor options by [@​a7i](https://redirect.github.com/a7i) in [kubernetes-sigs/descheduler#1455 - fix: indexer cache error when default evictor is re-initialized by [@​a7i](https://redirect.github.com/a7i) in [kubernetes-sigs/descheduler#1452 - fix: add info for error return by [@​googs1025](https://redirect.github.com/googs1025) in [kubernetes-sigs/descheduler#1457 - PodEvictor: turn an exceeded limit into an error by [@​ingvagabund](https://redirect.github.com/ingvagabund) in [kubernetes-sigs/descheduler#1456 - descheduler_test.go refactoring by [@​ingvagabund](https://redirect.github.com/ingvagabund) in [kubernetes-sigs/descheduler#1459 - The descheduler supports limiting the total number of pods evicted per rescheduling cycle by [@​zhifei92](https://redirect.github.com/zhifei92) in [kubernetes-sigs/descheduler#1451 - descheduler_test.go: initDescheduler: pass a new ctx with cancel inst… by [@​ingvagabund](https://redirect.github.com/ingvagabund) in [kubernetes-sigs/descheduler#1460 - pod evictor: make it thread safe by [@​ingvagabund](https://redirect.github.com/ingvagabund) in [kubernetes-sigs/descheduler#1458 - Update README about maxNoOfPodsToEvictTotal by [@​zhifei92](https://redirect.github.com/zhifei92) in [kubernetes-sigs/descheduler#1463 - refactor: replace k8s.io/utils/pointer with k8s.io/utils/ptr by [@​eminaktas](https://redirect.github.com/eminaktas) in [kubernetes-sigs/descheduler#1464 - feat: Add namespace override settings in Helm Chart by [@​ternbusty](https://redirect.github.com/ternbusty) in [kubernetes-sigs/descheduler#1444 - fix: helm leader-election typo to `resourceNamespace` by [@​a7i](https://redirect.github.com/a7i) in [kubernetes-sigs/descheduler#1443 - helm unit tests by [@​a7i](https://redirect.github.com/a7i) in [kubernetes-sigs/descheduler#1467 - feat: add init and ephemeral container checks to PodLifeTime by [@​adammw](https://redirect.github.com/adammw) in [kubernetes-sigs/descheduler#1468 - bump(github.com/golangci/golangci-lint)=v1.59.1 by [@​ingvagabund](https://redirect.github.com/ingvagabund) in [kubernetes-sigs/descheduler#1473 - e2e: TestTooManyRestarts: run descheduler as a whole instead of a single plugin by [@​ingvagabund](https://redirect.github.com/ingvagabund) in [kubernetes-sigs/descheduler#1472 - e2e: TestRemoveDuplicates: limit the tested namespace by [@​ingvagabund](https://redirect.github.com/ingvagabund) in [kubernetes-sigs/descheduler#1471 - KEP-1397: descheduler integration with evacuation API as an alternative to eviction API by [@​ingvagabund](https://redirect.github.com/ingvagabund) in [kubernetes-sigs/descheduler#1354 - skip eviction when pod creation time is below minPodAge threshold setting by [@​victorgs](https://redirect.github.com/victorgs) in [kubernetes-sigs/descheduler#1475 - fix: minor version parsing in version compatibility check by [@​a7i](https://redirect.github.com/a7i) in [kubernetes-sigs/descheduler#1430 - e2e: TestLeaderElection: delete the lease and increase the retry period by [@​ingvagabund](https://redirect.github.com/ingvagabund) in [kubernetes-sigs/descheduler#1469 - bump go to 1.22.5 by [@​shahar-h](https://redirect.github.com/shahar-h) in [kubernetes-sigs/descheduler#1476 - \[TestTooManyRestarts] e2e: build a descheduler image and run the descheduler as a pod by [@​ingvagabund](https://redirect.github.com/ingvagabund) in [kubernetes-sigs/descheduler#1474 - docs: Provide OCI annotation for where to find image sources by [@​sklirg](https://redirect.github.com/sklirg) in [kubernetes-sigs/descheduler#1479 - Remove descheduler/v1alpha1 type by [@​ingvagabund](https://redirect.github.com/ingvagabund) in [kubernetes-sigs/descheduler#1482 - tests: de-duplicate framework handle initialization by [@​ingvagabund](https://redirect.github.com/ingvagabund) in [kubernetes-sigs/descheduler#1483 - \[unit test]: test descheduling limits by [@​ingvagabund](https://redirect.github.com/ingvagabund) in [kubernetes-sigs/descheduler#1484 - \[unit test]: simplify test pod evictor reset by [@​ingvagabund](https://redirect.github.com/ingvagabund) in [kubernetes-sigs/descheduler#1485 - README: drop v1alpha1 descheduler policy mention by [@​ingvagabund](https://redirect.github.com/ingvagabund) in [kubernetes-sigs/descheduler#1498 - bump k8s.io libs to v0.31.0 by [@​a7i](https://redirect.github.com/a7i) in [kubernetes-sigs/descheduler#1496 - chore: upgrade python EOL and action versions by [@​a7i](https://redirect.github.com/a7i) in [kubernetes-sigs/descheduler#1505 - descheduler v0.31: update e2e test versions by [@​a7i](https://redirect.github.com/a7i) in [kubernetes-sigs/descheduler#1504 - feat(helm): make securityContext conditional in Deployment and CronJob by [@​bendikp](https://redirect.github.com/bendikp) in [kubernetes-sigs/descheduler#1507 - Plugin args: tag arguments with omitempty to reduce the marshalled json size by [@​ingvagabund](https://redirect.github.com/ingvagabund) in [kubernetes-sigs/descheduler#1480 - descheduler v0.31: update docs and manifests by [@​a7i](https://redirect.github.com/a7i) in [kubernetes-sigs/descheduler#1506 - \[e2e] no test timeouts, produce the same image tag as in production by [@​fanhaouu](https://redirect.github.com/fanhaouu) in [kubernetes-sigs/descheduler#1508 - chore: replace `github.com/ghodss/yaml` with `sigs.k8s.io/yaml` by [@​Juneezee](https://redirect.github.com/Juneezee) in [kubernetes-sigs/descheduler#1510 #### New Contributors - [@​hanyouqing](https://redirect.github.com/hanyouqing) made their first contribution in [kubernetes-sigs/descheduler#1378 - [@​omerap12](https://redirect.github.com/omerap12) made their first contribution in [kubernetes-sigs/descheduler#1390 - [@​duplabe](https://redirect.github.com/duplabe) made their first contribution in [kubernetes-sigs/descheduler#1412 - [@​googs1025](https://redirect.github.com/googs1025) made their first contribution in [kubernetes-sigs/descheduler#1416 - [@​zhifei92](https://redirect.github.com/zhifei92) made their first contribution in [kubernetes-sigs/descheduler#1445 - [@​ternbusty](https://redirect.github.com/ternbusty) made their first contribution in [kubernetes-sigs/descheduler#1444 - [@​adammw](https://redirect.github.com/adammw) made their first contribution in [kubernetes-sigs/descheduler#1468 - [@​shahar-h](https://redirect.github.com/shahar-h) made their first contribution in [kubernetes-sigs/descheduler#1476 - [@​sklirg](https://redirect.github.com/sklirg) made their first contribution in [kubernetes-sigs/descheduler#1479 - [@​bendikp](https://redirect.github.com/bendikp) made their first contribution in [kubernetes-sigs/descheduler#1507 - [@​Juneezee](https://redirect.github.com/Juneezee) made their first contribution in [kubernetes-sigs/descheduler#1510 **Full Changelog**: kubernetes-sigs/descheduler@v0.30.0...v0.31.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/broersma-forslund/homelab). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC41OS4yIiwidXBkYXRlZEluVmVyIjoiMzguNTkuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
spiceratops
added a commit
to spiceratops/k8s-gitops
that referenced
this pull request
Sep 10, 2024
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [descheduler](https://redirect.github.com/kubernetes-sigs/descheduler) | minor | `0.30.1` -> `0.31.0` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>kubernetes-sigs/descheduler (descheduler)</summary> ### [`v0.31.0`](https://redirect.github.com/kubernetes-sigs/descheduler/releases/tag/v0.31.0): Descheduler v0.31.0 [Compare Source](https://redirect.github.com/kubernetes-sigs/descheduler/compare/v0.30.1...v0.31.0) #### What's Changed - bump to to 1.22.3 to address CVE-2024-24788 by [@​a7i](https://redirect.github.com/a7i) in [kubernetes-sigs/descheduler#1408 - Fix the replicas value type for the descheduler helm-chart by [@​hanyouqing](https://redirect.github.com/hanyouqing) in [kubernetes-sigs/descheduler#1378 - Helm chart - allow 'falsey' value in cmdOption by [@​omerap12](https://redirect.github.com/omerap12) in [kubernetes-sigs/descheduler#1390 - fix helm's default deschedulerPolicy by [@​duplabe](https://redirect.github.com/duplabe) in [kubernetes-sigs/descheduler#1412 - fix TOC location in Readme by [@​duplabe](https://redirect.github.com/duplabe) in [kubernetes-sigs/descheduler#1413 - use cmd context instead of using context.Background() by [@​googs1025](https://redirect.github.com/googs1025) in [kubernetes-sigs/descheduler#1416 - fix the issue that the pod anti-filtering rules are not taking effect by [@​fanhaouu](https://redirect.github.com/fanhaouu) in [kubernetes-sigs/descheduler#1395 - Bump otel semconv to 1.24 by [@​damemi](https://redirect.github.com/damemi) in [kubernetes-sigs/descheduler#1429 - chore: reduce repetition of go versions by [@​a7i](https://redirect.github.com/a7i) in [kubernetes-sigs/descheduler#1432 - bump go to 1.22.4 for CVE-2024-24790 and CVE-2024-24789 by [@​a7i](https://redirect.github.com/a7i) in [kubernetes-sigs/descheduler#1433 - return pod qos in advance by [@​fanhaouu](https://redirect.github.com/fanhaouu) in [kubernetes-sigs/descheduler#1435 - add validation ut by [@​googs1025](https://redirect.github.com/googs1025) in [kubernetes-sigs/descheduler#1439 - refactor some methods in e2e test by [@​googs1025](https://redirect.github.com/googs1025) in [kubernetes-sigs/descheduler#1441 - Automated cherry pick of [#​1427](https://redirect.github.com/kubernetes-sigs/descheduler/issues/1427): helm: upgrade to v0.30.1 by [@​a7i](https://redirect.github.com/a7i) in [kubernetes-sigs/descheduler#1431 - chore: cleanup duplicated code by [@​googs1025](https://redirect.github.com/googs1025) in [kubernetes-sigs/descheduler#1438 - fix: return the unmatched cases first by [@​googs1025](https://redirect.github.com/googs1025) in [kubernetes-sigs/descheduler#1446 - Unit-test: add necessary ownerRef to the pod. by [@​zhifei92](https://redirect.github.com/zhifei92) in [kubernetes-sigs/descheduler#1445 - PodEvictor: refactoring and preparation for eviction requests by [@​ingvagabund](https://redirect.github.com/ingvagabund) in [kubernetes-sigs/descheduler#1447 - refactor: PodMatchNodeSelector method by [@​googs1025](https://redirect.github.com/googs1025) in [kubernetes-sigs/descheduler#1450 - return node fit error in advance by [@​fanhaouu](https://redirect.github.com/fanhaouu) in [kubernetes-sigs/descheduler#1436 - test: generate uid when building a pod by [@​ingvagabund](https://redirect.github.com/ingvagabund) in [kubernetes-sigs/descheduler#1454 - feat: pod evictor options by [@​a7i](https://redirect.github.com/a7i) in [kubernetes-sigs/descheduler#1455 - fix: indexer cache error when default evictor is re-initialized by [@​a7i](https://redirect.github.com/a7i) in [kubernetes-sigs/descheduler#1452 - fix: add info for error return by [@​googs1025](https://redirect.github.com/googs1025) in [kubernetes-sigs/descheduler#1457 - PodEvictor: turn an exceeded limit into an error by [@​ingvagabund](https://redirect.github.com/ingvagabund) in [kubernetes-sigs/descheduler#1456 - descheduler_test.go refactoring by [@​ingvagabund](https://redirect.github.com/ingvagabund) in [kubernetes-sigs/descheduler#1459 - The descheduler supports limiting the total number of pods evicted per rescheduling cycle by [@​zhifei92](https://redirect.github.com/zhifei92) in [kubernetes-sigs/descheduler#1451 - descheduler_test.go: initDescheduler: pass a new ctx with cancel inst… by [@​ingvagabund](https://redirect.github.com/ingvagabund) in [kubernetes-sigs/descheduler#1460 - pod evictor: make it thread safe by [@​ingvagabund](https://redirect.github.com/ingvagabund) in [kubernetes-sigs/descheduler#1458 - Update README about maxNoOfPodsToEvictTotal by [@​zhifei92](https://redirect.github.com/zhifei92) in [kubernetes-sigs/descheduler#1463 - refactor: replace k8s.io/utils/pointer with k8s.io/utils/ptr by [@​eminaktas](https://redirect.github.com/eminaktas) in [kubernetes-sigs/descheduler#1464 - feat: Add namespace override settings in Helm Chart by [@​ternbusty](https://redirect.github.com/ternbusty) in [kubernetes-sigs/descheduler#1444 - fix: helm leader-election typo to `resourceNamespace` by [@​a7i](https://redirect.github.com/a7i) in [kubernetes-sigs/descheduler#1443 - helm unit tests by [@​a7i](https://redirect.github.com/a7i) in [kubernetes-sigs/descheduler#1467 - feat: add init and ephemeral container checks to PodLifeTime by [@​adammw](https://redirect.github.com/adammw) in [kubernetes-sigs/descheduler#1468 - bump(github.com/golangci/golangci-lint)=v1.59.1 by [@​ingvagabund](https://redirect.github.com/ingvagabund) in [kubernetes-sigs/descheduler#1473 - e2e: TestTooManyRestarts: run descheduler as a whole instead of a single plugin by [@​ingvagabund](https://redirect.github.com/ingvagabund) in [kubernetes-sigs/descheduler#1472 - e2e: TestRemoveDuplicates: limit the tested namespace by [@​ingvagabund](https://redirect.github.com/ingvagabund) in [kubernetes-sigs/descheduler#1471 - KEP-1397: descheduler integration with evacuation API as an alternative to eviction API by [@​ingvagabund](https://redirect.github.com/ingvagabund) in [kubernetes-sigs/descheduler#1354 - skip eviction when pod creation time is below minPodAge threshold setting by [@​victorgs](https://redirect.github.com/victorgs) in [kubernetes-sigs/descheduler#1475 - fix: minor version parsing in version compatibility check by [@​a7i](https://redirect.github.com/a7i) in [kubernetes-sigs/descheduler#1430 - e2e: TestLeaderElection: delete the lease and increase the retry period by [@​ingvagabund](https://redirect.github.com/ingvagabund) in [kubernetes-sigs/descheduler#1469 - bump go to 1.22.5 by [@​shahar-h](https://redirect.github.com/shahar-h) in [kubernetes-sigs/descheduler#1476 - \[TestTooManyRestarts] e2e: build a descheduler image and run the descheduler as a pod by [@​ingvagabund](https://redirect.github.com/ingvagabund) in [kubernetes-sigs/descheduler#1474 - docs: Provide OCI annotation for where to find image sources by [@​sklirg](https://redirect.github.com/sklirg) in [kubernetes-sigs/descheduler#1479 - Remove descheduler/v1alpha1 type by [@​ingvagabund](https://redirect.github.com/ingvagabund) in [kubernetes-sigs/descheduler#1482 - tests: de-duplicate framework handle initialization by [@​ingvagabund](https://redirect.github.com/ingvagabund) in [kubernetes-sigs/descheduler#1483 - \[unit test]: test descheduling limits by [@​ingvagabund](https://redirect.github.com/ingvagabund) in [kubernetes-sigs/descheduler#1484 - \[unit test]: simplify test pod evictor reset by [@​ingvagabund](https://redirect.github.com/ingvagabund) in [kubernetes-sigs/descheduler#1485 - README: drop v1alpha1 descheduler policy mention by [@​ingvagabund](https://redirect.github.com/ingvagabund) in [kubernetes-sigs/descheduler#1498 - bump k8s.io libs to v0.31.0 by [@​a7i](https://redirect.github.com/a7i) in [kubernetes-sigs/descheduler#1496 - chore: upgrade python EOL and action versions by [@​a7i](https://redirect.github.com/a7i) in [kubernetes-sigs/descheduler#1505 - descheduler v0.31: update e2e test versions by [@​a7i](https://redirect.github.com/a7i) in [kubernetes-sigs/descheduler#1504 - feat(helm): make securityContext conditional in Deployment and CronJob by [@​bendikp](https://redirect.github.com/bendikp) in [kubernetes-sigs/descheduler#1507 - Plugin args: tag arguments with omitempty to reduce the marshalled json size by [@​ingvagabund](https://redirect.github.com/ingvagabund) in [kubernetes-sigs/descheduler#1480 - descheduler v0.31: update docs and manifests by [@​a7i](https://redirect.github.com/a7i) in [kubernetes-sigs/descheduler#1506 - \[e2e] no test timeouts, produce the same image tag as in production by [@​fanhaouu](https://redirect.github.com/fanhaouu) in [kubernetes-sigs/descheduler#1508 - chore: replace `github.com/ghodss/yaml` with `sigs.k8s.io/yaml` by [@​Juneezee](https://redirect.github.com/Juneezee) in [kubernetes-sigs/descheduler#1510 #### New Contributors - [@​hanyouqing](https://redirect.github.com/hanyouqing) made their first contribution in [kubernetes-sigs/descheduler#1378 - [@​omerap12](https://redirect.github.com/omerap12) made their first contribution in [kubernetes-sigs/descheduler#1390 - [@​duplabe](https://redirect.github.com/duplabe) made their first contribution in [kubernetes-sigs/descheduler#1412 - [@​googs1025](https://redirect.github.com/googs1025) made their first contribution in [kubernetes-sigs/descheduler#1416 - [@​zhifei92](https://redirect.github.com/zhifei92) made their first contribution in [kubernetes-sigs/descheduler#1445 - [@​ternbusty](https://redirect.github.com/ternbusty) made their first contribution in [kubernetes-sigs/descheduler#1444 - [@​adammw](https://redirect.github.com/adammw) made their first contribution in [kubernetes-sigs/descheduler#1468 - [@​shahar-h](https://redirect.github.com/shahar-h) made their first contribution in [kubernetes-sigs/descheduler#1476 - [@​sklirg](https://redirect.github.com/sklirg) made their first contribution in [kubernetes-sigs/descheduler#1479 - [@​bendikp](https://redirect.github.com/bendikp) made their first contribution in [kubernetes-sigs/descheduler#1507 - [@​Juneezee](https://redirect.github.com/Juneezee) made their first contribution in [kubernetes-sigs/descheduler#1510 **Full Changelog**: kubernetes-sigs/descheduler@v0.30.0...v0.31.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://redirect.github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC43My4zIiwidXBkYXRlZEluVmVyIjoiMzguNzMuMyIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsicmVub3ZhdGUvaGVsbSIsInR5cGUvbWlub3IiXX0=-->
lumiere-bot bot
added a commit
to coolguy1771/home-ops
that referenced
this pull request
Sep 19, 2024
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [descheduler](https://redirect.github.com/kubernetes-sigs/descheduler) | minor | `0.30.1` -> `0.31.0` | --- ### Release Notes <details> <summary>kubernetes-sigs/descheduler (descheduler)</summary> ### [`v0.31.0`](https://redirect.github.com/kubernetes-sigs/descheduler/releases/tag/v0.31.0): Descheduler v0.31.0 [Compare Source](https://redirect.github.com/kubernetes-sigs/descheduler/compare/v0.30.1...v0.31.0) #### What's Changed - bump to to 1.22.3 to address CVE-2024-24788 by [@​a7i](https://redirect.github.com/a7i) in [kubernetes-sigs/descheduler#1408 - Fix the replicas value type for the descheduler helm-chart by [@​hanyouqing](https://redirect.github.com/hanyouqing) in [kubernetes-sigs/descheduler#1378 - Helm chart - allow 'falsey' value in cmdOption by [@​omerap12](https://redirect.github.com/omerap12) in [kubernetes-sigs/descheduler#1390 - fix helm's default deschedulerPolicy by [@​duplabe](https://redirect.github.com/duplabe) in [kubernetes-sigs/descheduler#1412 - fix TOC location in Readme by [@​duplabe](https://redirect.github.com/duplabe) in [kubernetes-sigs/descheduler#1413 - use cmd context instead of using context.Background() by [@​googs1025](https://redirect.github.com/googs1025) in [kubernetes-sigs/descheduler#1416 - fix the issue that the pod anti-filtering rules are not taking effect by [@​fanhaouu](https://redirect.github.com/fanhaouu) in [kubernetes-sigs/descheduler#1395 - Bump otel semconv to 1.24 by [@​damemi](https://redirect.github.com/damemi) in [kubernetes-sigs/descheduler#1429 - chore: reduce repetition of go versions by [@​a7i](https://redirect.github.com/a7i) in [kubernetes-sigs/descheduler#1432 - bump go to 1.22.4 for CVE-2024-24790 and CVE-2024-24789 by [@​a7i](https://redirect.github.com/a7i) in [kubernetes-sigs/descheduler#1433 - return pod qos in advance by [@​fanhaouu](https://redirect.github.com/fanhaouu) in [kubernetes-sigs/descheduler#1435 - add validation ut by [@​googs1025](https://redirect.github.com/googs1025) in [kubernetes-sigs/descheduler#1439 - refactor some methods in e2e test by [@​googs1025](https://redirect.github.com/googs1025) in [kubernetes-sigs/descheduler#1441 - Automated cherry pick of [#​1427](https://redirect.github.com/kubernetes-sigs/descheduler/issues/1427): helm: upgrade to v0.30.1 by [@​a7i](https://redirect.github.com/a7i) in [kubernetes-sigs/descheduler#1431 - chore: cleanup duplicated code by [@​googs1025](https://redirect.github.com/googs1025) in [kubernetes-sigs/descheduler#1438 - fix: return the unmatched cases first by [@​googs1025](https://redirect.github.com/googs1025) in [kubernetes-sigs/descheduler#1446 - Unit-test: add necessary ownerRef to the pod. by [@​zhifei92](https://redirect.github.com/zhifei92) in [kubernetes-sigs/descheduler#1445 - PodEvictor: refactoring and preparation for eviction requests by [@​ingvagabund](https://redirect.github.com/ingvagabund) in [kubernetes-sigs/descheduler#1447 - refactor: PodMatchNodeSelector method by [@​googs1025](https://redirect.github.com/googs1025) in [kubernetes-sigs/descheduler#1450 - return node fit error in advance by [@​fanhaouu](https://redirect.github.com/fanhaouu) in [kubernetes-sigs/descheduler#1436 - test: generate uid when building a pod by [@​ingvagabund](https://redirect.github.com/ingvagabund) in [kubernetes-sigs/descheduler#1454 - feat: pod evictor options by [@​a7i](https://redirect.github.com/a7i) in [kubernetes-sigs/descheduler#1455 - fix: indexer cache error when default evictor is re-initialized by [@​a7i](https://redirect.github.com/a7i) in [kubernetes-sigs/descheduler#1452 - fix: add info for error return by [@​googs1025](https://redirect.github.com/googs1025) in [kubernetes-sigs/descheduler#1457 - PodEvictor: turn an exceeded limit into an error by [@​ingvagabund](https://redirect.github.com/ingvagabund) in [kubernetes-sigs/descheduler#1456 - descheduler_test.go refactoring by [@​ingvagabund](https://redirect.github.com/ingvagabund) in [kubernetes-sigs/descheduler#1459 - The descheduler supports limiting the total number of pods evicted per rescheduling cycle by [@​zhifei92](https://redirect.github.com/zhifei92) in [kubernetes-sigs/descheduler#1451 - descheduler_test.go: initDescheduler: pass a new ctx with cancel inst… by [@​ingvagabund](https://redirect.github.com/ingvagabund) in [kubernetes-sigs/descheduler#1460 - pod evictor: make it thread safe by [@​ingvagabund](https://redirect.github.com/ingvagabund) in [kubernetes-sigs/descheduler#1458 - Update README about maxNoOfPodsToEvictTotal by [@​zhifei92](https://redirect.github.com/zhifei92) in [kubernetes-sigs/descheduler#1463 - refactor: replace k8s.io/utils/pointer with k8s.io/utils/ptr by [@​eminaktas](https://redirect.github.com/eminaktas) in [kubernetes-sigs/descheduler#1464 - feat: Add namespace override settings in Helm Chart by [@​ternbusty](https://redirect.github.com/ternbusty) in [kubernetes-sigs/descheduler#1444 - fix: helm leader-election typo to `resourceNamespace` by [@​a7i](https://redirect.github.com/a7i) in [kubernetes-sigs/descheduler#1443 - helm unit tests by [@​a7i](https://redirect.github.com/a7i) in [kubernetes-sigs/descheduler#1467 - feat: add init and ephemeral container checks to PodLifeTime by [@​adammw](https://redirect.github.com/adammw) in [kubernetes-sigs/descheduler#1468 - bump(github.com/golangci/golangci-lint)=v1.59.1 by [@​ingvagabund](https://redirect.github.com/ingvagabund) in [kubernetes-sigs/descheduler#1473 - e2e: TestTooManyRestarts: run descheduler as a whole instead of a single plugin by [@​ingvagabund](https://redirect.github.com/ingvagabund) in [kubernetes-sigs/descheduler#1472 - e2e: TestRemoveDuplicates: limit the tested namespace by [@​ingvagabund](https://redirect.github.com/ingvagabund) in [kubernetes-sigs/descheduler#1471 - KEP-1397: descheduler integration with evacuation API as an alternative to eviction API by [@​ingvagabund](https://redirect.github.com/ingvagabund) in [kubernetes-sigs/descheduler#1354 - skip eviction when pod creation time is below minPodAge threshold setting by [@​victorgs](https://redirect.github.com/victorgs) in [kubernetes-sigs/descheduler#1475 - fix: minor version parsing in version compatibility check by [@​a7i](https://redirect.github.com/a7i) in [kubernetes-sigs/descheduler#1430 - e2e: TestLeaderElection: delete the lease and increase the retry period by [@​ingvagabund](https://redirect.github.com/ingvagabund) in [kubernetes-sigs/descheduler#1469 - bump go to 1.22.5 by [@​shahar-h](https://redirect.github.com/shahar-h) in [kubernetes-sigs/descheduler#1476 - \[TestTooManyRestarts] e2e: build a descheduler image and run the descheduler as a pod by [@​ingvagabund](https://redirect.github.com/ingvagabund) in [kubernetes-sigs/descheduler#1474 - docs: Provide OCI annotation for where to find image sources by [@​sklirg](https://redirect.github.com/sklirg) in [kubernetes-sigs/descheduler#1479 - Remove descheduler/v1alpha1 type by [@​ingvagabund](https://redirect.github.com/ingvagabund) in [kubernetes-sigs/descheduler#1482 - tests: de-duplicate framework handle initialization by [@​ingvagabund](https://redirect.github.com/ingvagabund) in [kubernetes-sigs/descheduler#1483 - \[unit test]: test descheduling limits by [@​ingvagabund](https://redirect.github.com/ingvagabund) in [kubernetes-sigs/descheduler#1484 - \[unit test]: simplify test pod evictor reset by [@​ingvagabund](https://redirect.github.com/ingvagabund) in [kubernetes-sigs/descheduler#1485 - README: drop v1alpha1 descheduler policy mention by [@​ingvagabund](https://redirect.github.com/ingvagabund) in [kubernetes-sigs/descheduler#1498 - bump k8s.io libs to v0.31.0 by [@​a7i](https://redirect.github.com/a7i) in [kubernetes-sigs/descheduler#1496 - chore: upgrade python EOL and action versions by [@​a7i](https://redirect.github.com/a7i) in [kubernetes-sigs/descheduler#1505 - descheduler v0.31: update e2e test versions by [@​a7i](https://redirect.github.com/a7i) in [kubernetes-sigs/descheduler#1504 - feat(helm): make securityContext conditional in Deployment and CronJob by [@​bendikp](https://redirect.github.com/bendikp) in [kubernetes-sigs/descheduler#1507 - Plugin args: tag arguments with omitempty to reduce the marshalled json size by [@​ingvagabund](https://redirect.github.com/ingvagabund) in [kubernetes-sigs/descheduler#1480 - descheduler v0.31: update docs and manifests by [@​a7i](https://redirect.github.com/a7i) in [kubernetes-sigs/descheduler#1506 - \[e2e] no test timeouts, produce the same image tag as in production by [@​fanhaouu](https://redirect.github.com/fanhaouu) in [kubernetes-sigs/descheduler#1508 - chore: replace `github.com/ghodss/yaml` with `sigs.k8s.io/yaml` by [@​Juneezee](https://redirect.github.com/Juneezee) in [kubernetes-sigs/descheduler#1510 #### New Contributors - [@​hanyouqing](https://redirect.github.com/hanyouqing) made their first contribution in [kubernetes-sigs/descheduler#1378 - [@​omerap12](https://redirect.github.com/omerap12) made their first contribution in [kubernetes-sigs/descheduler#1390 - [@​duplabe](https://redirect.github.com/duplabe) made their first contribution in [kubernetes-sigs/descheduler#1412 - [@​googs1025](https://redirect.github.com/googs1025) made their first contribution in [kubernetes-sigs/descheduler#1416 - [@​zhifei92](https://redirect.github.com/zhifei92) made their first contribution in [kubernetes-sigs/descheduler#1445 - [@​ternbusty](https://redirect.github.com/ternbusty) made their first contribution in [kubernetes-sigs/descheduler#1444 - [@​adammw](https://redirect.github.com/adammw) made their first contribution in [kubernetes-sigs/descheduler#1468 - [@​shahar-h](https://redirect.github.com/shahar-h) made their first contribution in [kubernetes-sigs/descheduler#1476 - [@​sklirg](https://redirect.github.com/sklirg) made their first contribution in [kubernetes-sigs/descheduler#1479 - [@​bendikp](https://redirect.github.com/bendikp) made their first contribution in [kubernetes-sigs/descheduler#1507 - [@​Juneezee](https://redirect.github.com/Juneezee) made their first contribution in [kubernetes-sigs/descheduler#1510 **Full Changelog**: kubernetes-sigs/descheduler@v0.30.0...v0.31.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://redirect.github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC43My4zIiwidXBkYXRlZEluVmVyIjoiMzguNzMuMyIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsicmVub3ZhdGUvaGVsbSIsInR5cGUvbWlub3IiXX0=--> Co-authored-by: lumiere-bot[bot] <98047013+lumiere-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some random cases none of the deschedulers acquires a lease. Making the test fail due to already existing lease.