Skip to content

Commit

Permalink
Remove experimental from gateway infrastructure (#3272)
Browse files Browse the repository at this point in the history
* Remove experimental from gateway infrastructure

Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>

* Codegen

Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>

* Change version of protoc-gen-grpc

Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>

* Change protoc version

Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>

* Update apis/v1/gateway_types.go

Co-authored-by: Rob Scott <rob.scott87@gmail.com>

* Add a warning about how modifying infrastructure.labels can result in pod churn

Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>

* Codegen

Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>

* Address PR feedback

Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>

* Fix whitespace

Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>

* Fixup

Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>

* Regen

Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>

* Add a git diff

Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>

* Regen after rebase

Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>

---------

Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>
Co-authored-by: Rob Scott <rob.scott87@gmail.com>
  • Loading branch information
keithmattix and robscott committed Sep 4, 2024
1 parent cb846ce commit ce6d2c6
Show file tree
Hide file tree
Showing 6 changed files with 317 additions and 36 deletions.
6 changes: 4 additions & 2 deletions apis/v1/gateway_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -224,9 +224,8 @@ type GatewaySpec struct {

// Infrastructure defines infrastructure level attributes about this Gateway instance.
//
// Support: Core
// Support: Extended
//
// <gateway:experimental>
// +optional
Infrastructure *GatewayInfrastructure `json:"infrastructure,omitempty"`

Expand Down Expand Up @@ -711,6 +710,9 @@ type GatewayInfrastructure struct {
//
// An implementation may chose to add additional implementation-specific labels as they see fit.
//
// If an implementation maps these labels to Pods, or any other resource that would need to be recreated when labels
// change, it SHOULD clearly warn about this behavior in documentation.
//
// Support: Extended
//
// +optional
Expand Down
20 changes: 12 additions & 8 deletions config/crd/experimental/gateway.networking.k8s.io_gateways.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

248 changes: 248 additions & 0 deletions config/crd/standard/gateway.networking.k8s.io_gateways.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit ce6d2c6

Please sign in to comment.