Skip to content

Commit

Permalink
Fixup
Browse files Browse the repository at this point in the history
Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>
  • Loading branch information
keithmattix committed Sep 3, 2024
1 parent 236561a commit d8aee5a
Show file tree
Hide file tree
Showing 5 changed files with 21 additions and 16 deletions.
4 changes: 4 additions & 0 deletions apis/v1/gateway_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -673,11 +673,15 @@ type GatewayStatus struct {
type GatewayInfrastructure struct {
// Labels that SHOULD be applied to any resources created in response to this Gateway.
//

// For implementations creating other Kubernetes objects, this should be the `metadata.labels` field on resources.
// For other implementations, this refers to any relevant (implementation specific) "labels" concepts.
//
// An implementation may chose to add additional implementation-specific labels as they see fit.
//
// If an implementation maps these labels to Pods, or any other resource that would need to be recreated when labels
// change, it SHOULD clearly warn about this behavior in documentation.
//
// Support: Extended
//
// +optional
Expand Down
14 changes: 8 additions & 6 deletions config/crd/experimental/gateway.networking.k8s.io_gateways.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 8 additions & 6 deletions config/crd/standard/gateway.networking.k8s.io_gateways.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 0 additions & 3 deletions geps/gep-1867/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -101,9 +101,6 @@ type GatewayInfrastructure struct {
//
// An implementation may chose to add additional implementation-specific labels as they see fit.
//
// If an implementation maps these labels to Pods, or any other resource that would need to be recreated when labels
// change, it SHOULD clearly warn about this behavior in documentation.
//
// Support: Extended
//
// +optional
Expand Down
2 changes: 1 addition & 1 deletion pkg/generated/openapi/zz_generated.openapi.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit d8aee5a

Please sign in to comment.